grommunio / grommunio-sync

version.php

Braces +1 added lines, -2 removed lines

@@ -11,8 +11,7 @@
 	$version = exec("hash git 2>/dev/null && cd {$path} >/dev/null 2>&1 && git describe  --always 2>/dev/null");
 	if ($branch && $version) {
 		define("GROMMUNIOSYNC_VERSION", $branch . '-' . $version);
-	}
-	else {
+	} else {
 		define("GROMMUNIOSYNC_VERSION", "GIT");
 	}
 }

mapi/class.meetingrequest.php

Braces +69 added lines, -138 removed lines

@@ -326,8 +326,7 @@ 
 
 			$userStore = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$userStore = $this->store;
 			$calFolder = $this->openDefaultCalendar();
 		}
@@ -396,8 +395,7 @@ 
 			// Create/modify exception
 			if ($recurr->isException($basedate)) {
 				$recurr->modifyException($exception_props, $basedate);
-			}
-			else {
+			} else {
 				// When we are creating an exception we need copy recipients from main recurring item
 				$recipTable = mapi_message_getrecipienttable($calendarItem);
 				$recips = mapi_table_queryallrows($recipTable, $this->recipprops);
@@ -415,8 +413,7 @@ 
 			if ($attach) {
 				$recurringItem = $calendarItem;
 				$calendarItem = mapi_attach_openobj($attach, MAPI_MODIFY);
-			}
-			else {
+			} else {
 				return false;
 			}
 		}
@@ -499,8 +496,7 @@ 
 			$props = [];
 			if ($messageprops[$this->proptags['counter_proposal']]) {
 				$props[$this->proptags['counter_proposal']] = true;
-			}
-			else {
+			} else {
 				$props[$this->proptags['counter_proposal']] = false;
 			}
 
@@ -556,8 +552,7 @@ 
 
 			$store = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$store = $this->store;
 			$calFolder = $this->openDefaultCalendar();
 		}
@@ -585,13 +580,11 @@ 
 
 					if ($recurr->isException($basedate)) {
 						$recurr->modifyException($messageProps, $basedate);
-					}
-					else {
+					} else {
 						$recurr->createException($messageProps, $basedate);
 					}
 				}
-			}
-			else {
+			} else {
 				// set the properties of the cancellation object
 				mapi_setprops($calendarItem, $messageProps);
 			}
@@ -645,8 +638,7 @@ 
 
 			$store = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$calFolder = $this->openDefaultCalendar();
 			$store = $this->store;
 		}
@@ -707,8 +699,7 @@ 
 		$senderEntryId = isset($messageprops[PR_SENT_REPRESENTING_ENTRYID]) ? $messageprops[PR_SENT_REPRESENTING_ENTRYID] : $messageprops[PR_SENDER_ENTRYID];
 		if (isset($messageprops[PR_RECEIVED_BY_ENTRYID]) && MAPIUtils::CompareEntryIds($senderEntryId, $messageprops[PR_RECEIVED_BY_ENTRYID])) {
 			$entryid = $this->accept(false, $sendresponse, $move, $proposeNewTimeProps, $body, true, $store, $calFolder, $basedate);
-		}
-		else {
+		} else {
 			$entryid = $this->accept($tentative, $sendresponse, $move, $proposeNewTimeProps, $body, $userAction, $store, $calFolder, $basedate);
 		}
 
@@ -762,8 +753,7 @@ 
 				if (!$calendarItem) {
 					// Recurring item not found, so create new meeting in Calendar
 					$calendarItem = mapi_folder_createmessage($calFolder);
-				}
-				else {
+				} else {
 					// we have found the main recurring item, check if this meeting request is already processed
 					if (isset($messageprops[PR_PROCESSED]) && $messageprops[PR_PROCESSED] == true) {
 						// only set required properties, other properties are already copied when processing this meeting request
@@ -784,8 +774,7 @@ 
 					if (isset($props[$this->proptags['reminderminutes']])) {
 						$props[$this->proptags['flagdueby']] = $props[$this->proptags['startdate']] - ($props[$this->proptags['reminderminutes']] * 60);
 					}
-				}
-				else {
+				} else {
 					// only get required properties so we will not overwrite existing updated properties from calendar
 					$props = mapi_getprops($this->message, [PR_ENTRYID]);
 				}
@@ -806,13 +795,11 @@ 
 				if (isset($props[$this->proptags['intendedbusystatus']])) {
 					if ($tentative && $props[$this->proptags['intendedbusystatus']] !== fbFree) {
 						$props[$this->proptags['busystatus']] = fbTentative;
-					}
-					else {
+					} else {
 						$props[$this->proptags['busystatus']] = $props[$this->proptags['intendedbusystatus']];
 					}
 					// we already have intendedbusystatus value in $props so no need to copy it
-				}
-				else {
+				} else {
 					$props[$this->proptags['busystatus']] = $tentative ? fbTentative : fbBusy;
 				}
 
@@ -875,8 +862,7 @@ 
 				}
 
 				$entryid = $props[PR_ENTRYID];
-			}
-			else {
+			} else {
 				/**
 				 * This meeting request is not recurring, so can be an exception or normal meeting.
 				 * If exception then find main recurring item and update exception
@@ -943,13 +929,11 @@ 
 						if (isset($messageprops[$this->proptags['intendedbusystatus']])) {
 							if ($tentative && $messageprops[$this->proptags['intendedbusystatus']] !== fbFree) {
 								$calItemProps[$this->proptags['busystatus']] = fbTentative;
-							}
-							else {
+							} else {
 								$calItemProps[$this->proptags['busystatus']] = $messageprops[$this->proptags['intendedbusystatus']];
 							}
 							$calItemProps[$this->proptags['intendedbusystatus']] = $messageprops[$this->proptags['intendedbusystatus']];
-						}
-						else {
+						} else {
 							$calItemProps[$this->proptags['busystatus']] = $tentative ? fbTentative : fbBusy;
 						}
 
@@ -982,8 +966,7 @@ 
 
 						$messageprops = mapi_getprops($calmsg, [PR_ENTRYID]);
 						$entryid = $messageprops[PR_ENTRYID];
-					}
-					else {
+					} else {
 						// Create a new appointment with duplicate properties and recipient, but as an IPM.Appointment
 						$new = mapi_folder_createmessage($calFolder);
 						$props = mapi_getprops($this->message);
@@ -1018,13 +1001,11 @@ 
 						if (isset($props[$this->proptags['intendedbusystatus']])) {
 							if ($tentative && $props[$this->proptags['intendedbusystatus']] !== fbFree) {
 								$props[$this->proptags['busystatus']] = fbTentative;
-							}
-							else {
+							} else {
 								$props[$this->proptags['busystatus']] = $props[$this->proptags['intendedbusystatus']];
 							}
 							// we already have intendedbusystatus value in $props so no need to copy it
-						}
-						else {
+						} else {
 							$props[$this->proptags['busystatus']] = $tentative ? fbTentative : fbBusy;
 						}
 
@@ -1056,8 +1037,7 @@ 
 							],
 							];
 							$recipients = mapi_table_queryallrows($recipientTable, $this->recipprops, $res);
-						}
-						else {
+						} else {
 							$recipients = mapi_table_queryallrows($recipientTable, $this->recipprops);
 						}
 						$this->addOrganizer($props, $recipients);
@@ -1069,8 +1049,7 @@ 
 					}
 				}
 			}
-		}
-		else {
+		} else {
 			// Here only properties are set on calendaritem, because user is responding from calendar.
 			$props = [];
 			$props[$this->proptags['responsestatus']] = $tentative ? olResponseTentative : olResponseAccepted;
@@ -1078,13 +1057,11 @@ 
 			if (isset($messageprops[$this->proptags['intendedbusystatus']])) {
 				if ($tentative && $messageprops[$this->proptags['intendedbusystatus']] !== fbFree) {
 					$props[$this->proptags['busystatus']] = fbTentative;
-				}
-				else {
+				} else {
 					$props[$this->proptags['busystatus']] = $messageprops[$this->proptags['intendedbusystatus']];
 				}
 				$props[$this->proptags['intendedbusystatus']] = $messageprops[$this->proptags['intendedbusystatus']];
-			}
-			else {
+			} else {
 				$props[$this->proptags['busystatus']] = $tentative ? fbTentative : fbBusy;
 			}
 
@@ -1107,8 +1084,7 @@ 
 
 				if ($recurr->isException($basedate)) {
 					$recurr->modifyException($proposeNewTimeProps + $props, $basedate, $recips);
-				}
-				else {
+				} else {
 					$props[$this->proptags['startdate']] = $recurr->getOccurrenceStart($basedate);
 					$props[$this->proptags['duedate']] = $recurr->getOccurrenceEnd($basedate);
 
@@ -1120,8 +1096,7 @@ 
 
 					$recurr->createException($proposeNewTimeProps + $props, $basedate, false, $recips);
 				}
-			}
-			else {
+			} else {
 				mapi_setprops($this->message, $proposeNewTimeProps + $props);
 			}
 			mapi_savechanges($this->message);
@@ -1162,8 +1137,7 @@ 
 
 			$store = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$calFolder = $this->openDefaultCalendar();
 			$store = $this->store;
 		}
@@ -1255,8 +1229,7 @@ 
 
 			$store = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$store = $this->store;
 			$calFolder = $this->openDefaultCalendar();
 		}
@@ -1288,8 +1261,7 @@ 
 						// exception found, remove it from calendar
 						$this->doRemoveExceptionFromCalendar($basedate, $calendarItem, $store);
 					}
-				}
-				else {
+				} else {
 					// remove normal / recurring series from calendar
 					$entryids = mapi_getprops($calendarItem, [PR_ENTRYID]);
 
@@ -1304,14 +1276,12 @@ 
 
 			// Move the cancellation mail to wastebasket
 			mapi_folder_copymessages($sourcefolder, [$messageprops[PR_ENTRYID]], $wastebasket, MESSAGE_MOVE);
-		}
-		else {
+		} else {
 			// Here only properties are set on calendaritem, because user is responding from calendar.
 			if ($basedate) {
 				// remove the occurrence
 				$this->doRemoveExceptionFromCalendar($basedate, $this->message, $store);
-			}
-			else {
+			} else {
 				// remove normal/recurring meeting item.
 				// Move the message to the waste basket
 				mapi_folder_copymessages($sourcefolder, [$messageprops[PR_ENTRYID]], $wastebasket, MESSAGE_MOVE);
@@ -1358,8 +1328,7 @@ 
 
 			// save changes in the message
 			mapi_savechanges($this->message);
-		}
-		else {
+		} else {
 			// cancellation of normal meeting request
 			// Send the cancellation
 			$this->updateMeetingRequest();
@@ -1499,8 +1468,7 @@ 
 					}
 				}
 			}
-		}
-		else {
+		} else {
 			// Basedate found, an exception is to be send
 			if ($basedate) {
 				$recurr = new Recurrence($this->openDefaultStore(), $this->message);
@@ -1508,8 +1476,7 @@ 
 				if ($cancel) {
 					// @TODO: remove occurrence from Resource's Calendar if resource was booked for whole series
 					$this->submitMeetingRequest($this->message, $cancel, $prefix, $basedate, $recurr, false);
-				}
-				else {
+				} else {
 					$attach = $recurr->getExceptionAttachment($basedate);
 
 					if ($attach) {
@@ -1528,8 +1495,7 @@ 
 						}
 					}
 				}
-			}
-			else {
+			} else {
 				// This is normal meeting
 				$resourceRecipData = $this->bookResources($this->message, $cancel, $prefix);
 
@@ -1606,8 +1572,7 @@ 
 
 		if (!isset($messageprops[$this->proptags['goid']])) {
 			$this->setMeetingRequest($basedate);
-		}
-		else {
+		} else {
 			$counter = $messageprops[$this->proptags['last_updatecounter']] + 1;
 
 			// increment value of last_updatecounter, last_updatecounter will be common for recurring series
@@ -1626,8 +1591,7 @@ 
 		if (!$this->isMeetingRequest($props[PR_MESSAGE_CLASS]) && !$this->isMeetingRequestResponse($props[PR_MESSAGE_CLASS]) && !$this->isMeetingCancellation($props[PR_MESSAGE_CLASS])) {
 			// we are checking with calendar item
 			$calendarItem = $this->message;
-		}
-		else {
+		} else {
 			// we are checking with meeting request / response / cancellation mail
 			// get calendar items
 			$calendarItem = $this->getCorrespondentCalendarItem(true);
@@ -1762,8 +1726,7 @@ 
 			if (isset($inboxprops[$prop])) {
 				return $inboxprops[$prop];
 			}
-		}
-		catch (MAPIException $e) {
+		} catch (MAPIException $e) {
 			// public store doesn't support this method
 			if ($e->getCode() == MAPI_E_NO_SUPPORT) {
 				// don't propagate this error to parent handlers, if store doesn't support it
@@ -1853,8 +1816,7 @@ 
 				if (($folderProps[PR_ACCESS] & MAPI_ACCESS_CREATE_CONTENTS) === MAPI_ACCESS_CREATE_CONTENTS) {
 					$accessToFolder = true;
 				}
-			}
-			catch (MAPIException $e) {
+			} catch (MAPIException $e) {
 				// we don't have rights to open folder, so return false
 				if ($e->getCode() == MAPI_E_NO_ACCESS) {
 					return $accessToFolder;
@@ -1884,8 +1846,7 @@ 
 				$delegatorStore = $this->getDelegatorStore($messageProps[PR_RCVD_REPRESENTING_ENTRYID]);
 
 				$store = $delegatorStore['store'];
-			}
-			else {
+			} else {
 				$store = $this->store;
 			}
 		}
@@ -1895,8 +1856,7 @@ 
 		if (isset($provider[PR_MDB_PROVIDER]) && $provider[PR_MDB_PROVIDER] === ZARAFA_STORE_PUBLIC_GUID) {
 			$entryid = mapi_getprops($this->message, [PR_PARENT_ENTRYID]);
 			$entryid = $entryid[PR_PARENT_ENTRYID];
-		}
-		else {
+		} else {
 			$entryid = $this->getDefaultFolderEntryID(PR_IPM_APPOINTMENT_ENTRYID, $store);
 			if ($entryid === false) {
 				$entryid = $this->getBaseEntryID(PR_IPM_APPOINTMENT_ENTRYID, $store);
@@ -1922,8 +1882,7 @@ 
 
 		try {
 			$mailuser = mapi_ab_openentry($ab, $ownerentryid);
-		}
-		catch (MAPIException $e) {
+		} catch (MAPIException $e) {
 			return;
 		}
 
@@ -1991,8 +1950,7 @@ 
 				$props[$this->proptags['meetingstatus']] = $imsgprops[$this->proptags['meetingstatus']];
 				$props[$this->proptags['responsestatus']] = $imsgprops[$this->proptags['responsestatus']];
 				$props[PR_SUBJECT] = $imsgprops[PR_SUBJECT];
-			}
-			else {
+			} else {
 				// Exceptions is deleted.
 				// Update $messageprops with timings of occurrence
 				$messageprops[$this->proptags['startdate']] = $recurr->getOccurrenceStart($basedate);
@@ -2004,8 +1962,7 @@ 
 
 			$props[$this->proptags['recurring']] = false;
 			$props[$this->proptags['is_exception']] = true;
-		}
-		else {
+		} else {
 			// we are creating a response from meeting request mail (it could be recurring or non-recurring)
 			// Send all recurrence info in response, if this is a recurrence meeting.
 			$isRecurring = isset($messageprops[$this->proptags['recurring']]) && $messageprops[$this->proptags['recurring']];
@@ -2287,8 +2244,7 @@ 
 		foreach ($recipients as $key => $recipient) {
 			if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable | recipOrganizer)) {
 				$hasOrganizer = true;
-			}
-			elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
+			} elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
 				// Recipients for an occurrence
 				$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalResponse;
 			}
@@ -2429,8 +2385,7 @@ 
 			],
 			];
 			$recipients = mapi_table_queryallrows($recipientTable, $this->recipprops, $res);
-		}
-		else {
+		} else {
 			$recipients = mapi_table_queryallrows($recipientTable, $this->recipprops);
 		}
 
@@ -2526,8 +2481,7 @@ 
 				if ($accessToFolder) {
 					$calFolder = mapi_msgstore_openentry($userStore, $userRootProps[PR_IPM_APPOINTMENT_ENTRYID]);
 				}
-			}
-			catch (MAPIException $e) {
+			} catch (MAPIException $e) {
 				$e->setHandled();
 				$this->errorSetResource = 1; // No access
 			}
@@ -2554,8 +2508,7 @@ 
 						 */
 						// $errorSetResource = 2;
 						$this->nonAcceptingResources[] = $resourceRecipients[$i];
-					}
-					else {
+					} else {
 						if ($declineRecurringMeetingRequests && !$cancel) {
 							// Check if appointment is recurring
 							if ($messageprops[$this->proptags['recurring']]) {
@@ -2616,8 +2569,7 @@ 
 					if (!$newResourceMsg) {
 						$newResourceMsg = mapi_folder_createmessage($calFolder);
 					}
-				}
-				else {
+				} else {
 					$newResourceMsg = mapi_msgstore_openentry($userStore, $rows[0]);
 				}
 
@@ -2631,8 +2583,7 @@ 
 				if ($cancel) {
 					$messageprops[$this->proptags['meetingstatus']] = olMeetingCanceled; // The meeting has been canceled
 					$messageprops[$this->proptags['busystatus']] = fbFree; // Free
-				}
-				else {
+				} else {
 					$messageprops[$this->proptags['meetingstatus']] = olMeetingReceived; // The recipient is receiving the request
 				}
 				$messageprops[$this->proptags['responsestatus']] = olResponseAccepted; // The resource automatically accepts the appointment
@@ -2676,8 +2627,7 @@ 
 						$messageprops[PR_SENT_REPRESENTING_ENTRYID] = $ownerentryid;
 						$messageprops[PR_SENT_REPRESENTING_SEARCH_KEY] = $ownersearchkey;
 					}
-				}
-				else {
+				} else {
 					// get organizer information
 					$addrinfo = $this->getOwnerAddress($this->store);
 
@@ -2713,12 +2663,10 @@ 
 					// Update occurrence
 					if ($recurr->isException($basedate)) {
 						$recurr->modifyException($messageprops, $basedate, $recips);
-					}
-					else {
+					} else {
 						$recurr->createException($messageprops, $basedate, false, $recips);
 					}
-				}
-				else {
+				} else {
 					mapi_setprops($newResourceMsg, $messageprops);
 
 					// Copy attachments
@@ -2742,8 +2690,7 @@ 
 					'msg' => $newResourceMsg,
 				];
 				$this->includesResources = true;
-			}
-			else {
+			} else {
 				/*
 				 * If no other errors occurred and you have no access to the
 				 * folder of the resource, throw an error=1.
@@ -2838,8 +2785,7 @@ 
 			],
 			];
 			$recips = mapi_table_queryallrows($reciptable, $this->recipprops, $res);
-		}
-		else {
+		} else {
 			$recips = mapi_table_queryallrows($reciptable, $this->recipprops);
 		}
 
@@ -2857,13 +2803,11 @@ 
 		if (isset($exception_props[$this->proptags['intendedbusystatus']])) {
 			if ($tentative && $exception_props[$this->proptags['intendedbusystatus']] !== fbFree) {
 				$exception_props[$this->proptags['busystatus']] = fbTentative;
-			}
-			else {
+			} else {
 				$exception_props[$this->proptags['busystatus']] = $exception_props[$this->proptags['intendedbusystatus']];
 			}
 			// we already have intendedbusystatus value in $exception_props so no need to copy it
-		}
-		else {
+		} else {
 			$exception_props[$this->proptags['busystatus']] = $tentative ? fbTentative : fbBusy;
 		}
 
@@ -2879,8 +2823,7 @@ 
 
 		if ($recurr->isException($basedate)) {
 			$recurr->modifyException($exception_props, $basedate, $recips, $occurrenceItem);
-		}
-		else {
+		} else {
 			$recurr->createException($exception_props, $basedate, false, $recips, $occurrenceItem);
 		}
 
@@ -2917,8 +2860,7 @@ 
 
 		if ($recurr->isException($basedate)) {
 			$recurr->modifyException($exception_props, $basedate, $recips, $occurrenceItem);
-		}
-		else {
+		} else {
 			$recurr->createException($exception_props, $basedate, false, $recips, $occurrenceItem);
 		}
 
@@ -3017,8 +2959,7 @@ 
 
 			if (!$deletedRecips) {
 				$deletedRecips = array_merge([], $recipients);
-			}
-			else {
+			} else {
 				$deletedRecips = array_merge($deletedRecips, $recipients);
 			}
 		}
@@ -3157,8 +3098,7 @@ 
 				$newmessageprops[PR_MESSAGE_CLASS] = 'IPM.Schedule.Meeting.Canceled';
 				$newmessageprops[$this->proptags['meetingstatus']] = olMeetingCanceled; // It's a cancel request
 				$newmessageprops[$this->proptags['busystatus']] = fbFree; // set the busy status as free
-			}
-			else {
+			} else {
 				$newmessageprops[PR_MESSAGE_CLASS] = 'IPM.Schedule.Meeting.Request';
 				$newmessageprops[$this->proptags['meetingstatus']] = olMeetingReceived; // The recipient is receiving the request
 			}
@@ -3327,8 +3267,7 @@ 
 					$sentprops[PR_SENDER_SEARCH_KEY] = $ownersearchkey;
 				}
 			}
-		}
-		else {
+		} else {
 			// normal user is sending mail, so both set of properties will be same
 			$userDetails = $this->getOwnerAddress($userStore);
 
@@ -3494,8 +3433,7 @@ 
 					$message = mapi_attach_openobj($attach, MAPI_MODIFY);
 				}
 			}
-		}
-		else {
+		} else {
 			// use normal message or recurring series message
 			$message = $this->message;
 		}
@@ -3538,8 +3476,7 @@ 
 			if (($recipient[PR_RECIPIENT_FLAGS] & recipOrganizer) != recipOrganizer) {
 				// Recipient is attendee, set the trackstatus to 'Not Responded'
 				$recipient[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone;
-			}
-			else {
+			} else {
 				// Recipient is organizer, this is not possible, but for safety
 				// it is best to clear the trackstatus for him as well by setting
 				// the trackstatus to 'Organized'.
@@ -3577,8 +3514,7 @@ 
 
 			$store = $delegatorStore['store'];
 			$calFolder = $delegatorStore[PR_IPM_APPOINTMENT_ENTRYID];
-		}
-		else {
+		} else {
 			$store = $this->store;
 			$calFolder = $this->openDefaultCalendar();
 		}
@@ -3640,8 +3576,7 @@ 
 			if (isset($props[PR_RCVD_REPRESENTING_ENTRYID])) {
 				$delegatorStore = $this->getDelegatorStore($props[PR_RCVD_REPRESENTING_ENTRYID]);
 				$store = $delegatorStore['store'];
-			}
-			else {
+			} else {
 				$store = $this->store;
 			}
 		}
@@ -3730,8 +3665,7 @@ 
 
 									break;
 								}
-							}
-							else {
+							} else {
 								++$noOfInstances;
 
 								break;
@@ -3743,8 +3677,7 @@ 
 				if ($noOfInstances > 0) {
 					$returnValue = $noOfInstances;
 				}
-			}
-			else {
+			} else {
 				// Get all items in the timeframe that we want to book, and get the goid and busystatus for each item
 				$items = getCalendarItems($userStore, $calFolder, $messageProps[$this->proptags['startdate']], $messageProps[$this->proptags['duedate']], [$this->proptags['goid'], $this->proptags['busystatus']]);
 
@@ -3766,8 +3699,7 @@ 
 
 								break;
 							}
-						}
-						else {
+						} else {
 							$returnValue = true;
 
 							break;
@@ -3929,8 +3861,7 @@ 
 		foreach ($localCategories as $key => $value) {
 			if ($recurrence->isException($key)) {
 				$recurrence->modifyException([$this->proptags['categories'] => $value], $key);
-			}
-			else {
+			} else {
 				$recurrence->createException([$this->proptags['categories'] => $value], $key, false);
 			}
 			mapi_savechanges($message);

mapi/class.taskrecurrence.php

Braces +3 added lines, -6 removed lines

@@ -172,8 +172,7 @@ 
 					}
 
 					$props[$this->proptags["dead_occurrence"]] = false;
-				}
-				else {
+				} else {
 					if (isset($this->action['deleteOccurrence']) && $this->action['deleteOccurrence']) {
 						return false;
 					}
@@ -330,8 +329,7 @@ 
 				// If startdate and enddate are set on task, then slide enddate according to duration
 				if (isset($this->messageprops[$this->proptags["startdate"]], $this->messageprops[$this->proptags["duedate"]])) {
 					$newItem[$this->proptags['duedate']] = $newItem[$this->proptags['startdate']] + ($this->messageprops[$this->proptags["duedate"]] - $this->messageprops[$this->proptags["startdate"]]);
-				}
-				else {
+				} else {
 					$newItem[$this->proptags['duedate']] = $newItem[$this->proptags['startdate']];
 				}
 
@@ -385,8 +383,7 @@ 
 					$props[$this->proptags['flagdueby']] = $next_reminder_time;
 					$this->action['reminder'] = $props[$this->proptags['reminder']] = true;
 				}
-			}
-			else {
+			} else {
 				// Didn't get next occurrence, probably this is the last occurrence
 				$props[$this->proptags['reminder']] = false;
 				$props[$this->proptags['reset_reminder']] = false;

mapi/class.recurrence.php

Braces +28 added lines, -56 removed lines

@@ -51,8 +51,7 @@ 
 		public function __construct($store, $message, $proptags = []) {
 			if ($proptags) {
 				$this->proptags = $proptags;
-			}
-			else {
+			} else {
 				$properties = [];
 				$properties["entryid"] = PR_ENTRYID;
 				$properties["parent_entryid"] = PR_PARENT_ENTRYID;
@@ -192,8 +191,7 @@ 
 
 				// Add the changed occurrence to the list
 				array_push($this->recur["changed_occurrences"], $changed_item);
-			}
-			else {
+			} else {
 				// Delete the occurrence by placing it in the deleted occurrences list
 				array_push($this->recur["deleted_occurrences"], $baseday);
 			}
@@ -290,12 +288,10 @@ 
 				if ($copy_attach_from) {
 					$this->deleteExceptionAttachment($base_date);
 					$this->createException($exception_props, $base_date, false, $exception_recips, $copy_attach_from);
-				}
-				else {
+				} else {
 					$this->createExceptionAttachment($exception_props, $exception_recips, $copy_attach_from);
 				}
-			}
-			else {
+			} else {
 				$message = mapi_attach_openobj($attach, MAPI_MODIFY);
 
 				// Set exception properties on embedded message and save
@@ -339,8 +335,7 @@ 
 				// the exception used to be.
 				$oldexception = $this->getChangeException($basedate);
 				$prevday = $this->dayStartOf($oldexception["start"]);
-			}
-			else {
+			} else {
 				// If its a new exception, we want to look at the original placement of this item.
 				$prevday = $basedate;
 			}
@@ -350,8 +345,7 @@ 
 			// Get all the occurrences on the days between the basedate (may be reversed)
 			if ($prevday < $startday) {
 				$items = $this->getItems($this->toGMT($this->tz, $prevday), $this->toGMT($this->tz, $startday + 24 * 60 * 60));
-			}
-			else {
+			} else {
 				$items = $this->getItems($this->toGMT($this->tz, $startday), $this->toGMT($this->tz, $prevday + 24 * 60 * 60));
 			}
 
@@ -545,12 +539,10 @@ 
 					if ($everyn == 1) {
 						$type = _('workday');
 						$occSingleDayRank = true;
-					}
-					elseif ($everyn == (24 * 60)) {
+					} elseif ($everyn == (24 * 60)) {
 						$type = _('day');
 						$occSingleDayRank = true;
-					}
-					else {
+					} else {
 						$everyn /= (24 * 60);
 						$type = _('days');
 						$occSingleDayRank = false;
@@ -562,8 +554,7 @@ 
 					if ($everyn == 1) {
 						$type = _('week');
 						$occSingleDayRank = true;
-					}
-					else {
+					} else {
 						$type = _('weeks');
 						$occSingleDayRank = false;
 					}
@@ -574,8 +565,7 @@ 
 					if ($everyn == 1) {
 						$type = _('month');
 						$occSingleDayRank = true;
-					}
-					else {
+					} else {
 						$type = _('months');
 						$occSingleDayRank = false;
 					}
@@ -587,8 +577,7 @@ 
 						$everyn = 1;
 						$type = _('year');
 						$occSingleDayRank = true;
-					}
-					else {
+					} else {
 						$everyn = $everyn / 12;
 						$type = _('years');
 						$occSingleDayRank = false;
@@ -618,21 +607,17 @@ 
 				if ($occTimeRange) {
 					if ($occSingleDayRank) {
 						$pattern = sprintf(_('Occurs every %s effective %s from %s to %s.'), $type, $start, $startocc, $endocc);
-					}
-					else {
+					} else {
 						$pattern = sprintf(_('Occurs every %s %s effective %s from %s to %s.'), $everyn, $type, $start, $startocc, $endocc);
 					}
-				}
-				else {
+				} else {
 					if ($occSingleDayRank) {
 						$pattern = sprintf(_('Occurs every %s effective %s.'), $type, $start);
-					}
-					else {
+					} else {
 						$pattern = sprintf(_('Occurs every %s %s effective %s.'), $everyn, $type, $start);
 					}
 				}
-			}
-			elseif ($term == 0x22) {
+			} elseif ($term == 0x22) {
 				// After a number of times
 				if ($occTimeRange) {
 					if ($occSingleDayRank) {
@@ -641,24 +626,21 @@ 
 							'Occurs every %s effective %s for %s occurrences from %s to %s.',
 							$numocc
 						), $type, $start, $numocc, $startocc, $endocc);
-					}
-					else {
+					} else {
 						$pattern = sprintf(ngettext(
 							'Occurs every %s %s effective %s for %s occurrence from %s to %s.',
 							'Occurs every %s %s effective %s for %s occurrences %s to %s.',
 							$numocc
 						), $everyn, $type, $start, $numocc, $startocc, $endocc);
 					}
-				}
-				else {
+				} else {
 					if ($occSingleDayRank) {
 						$pattern = sprintf(ngettext(
 							'Occurs every %s effective %s for %s occurrence.',
 							'Occurs every %s effective %s for %s occurrences.',
 							$numocc
 						), $type, $start, $numocc);
-					}
-					else {
+					} else {
 						$pattern = sprintf(ngettext(
 							'Occurs every %s %s effective %s for %s occurrence.',
 							'Occurs every %s %s effective %s for %s occurrences.',
@@ -666,22 +648,18 @@ 
 						), $everyn, $type, $start, $numocc);
 					}
 				}
-			}
-			elseif ($term == 0x21) {
+			} elseif ($term == 0x21) {
 				// After the given enddate
 				if ($occTimeRange) {
 					if ($occSingleDayRank) {
 						$pattern = sprintf(_('Occurs every %s effective %s until %s from %s to %s.'), $type, $start, $end, $startocc, $endocc);
-					}
-					else {
+					} else {
 						$pattern = sprintf(_('Occurs every %s %s effective %s until %s from %s to %s.'), $everyn, $type, $start, $end, $startocc, $endocc);
 					}
-				}
-				else {
+				} else {
 					if ($occSingleDayRank) {
 						$pattern = sprintf(_('Occurs every %s effective %s until %s.'), $type, $start, $end);
-					}
-					else {
+					} else {
 						$pattern = sprintf(_('Occurs every %s %s effective %s until %s.'), $everyn, $type, $start, $end);
 					}
 				}
@@ -713,8 +691,7 @@ 
 			foreach ($this->recur["changed_occurrences"] as $entry) {
 				if (!$this->isSameDay($entry["basedate"], $base_date)) {
 					$new[] = $entry;
-				}
-				else {
+				} else {
 					$this->deleteExceptionAttachment($this->toGMT($this->tz, $base_date + $this->recur["startocc"] * 60));
 				}
 			}
@@ -1083,8 +1060,7 @@ 
 		public function setExceptionRecipients($message, $exception_recips, $copy_orig_recips = true) {
 			if (isset($exception_recips['add']) || isset($exception_recips['remove']) || isset($exception_recips['modify'])) {
 				$this->setDeltaExceptionRecipients($message, $exception_recips, $copy_orig_recips);
-			}
-			else {
+			} else {
 				$this->setAllExceptionRecipients($message, $exception_recips);
 			}
 		}
@@ -1125,8 +1101,7 @@ 
 				foreach ($exception_recips['remove'] as &$recip) {
 					if (!isset($recip[PR_RECIPIENT_FLAGS]) || $recip[PR_RECIPIENT_FLAGS] != (recipReserved | recipExceptionalDeleted | recipSendable)) {
 						$recip[PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalDeleted;
-					}
-					else {
+					} else {
 						$recip[PR_RECIPIENT_FLAGS] = recipReserved | recipExceptionalDeleted | recipSendable;
 					}
 					$recip[PR_RECIPIENT_TRACKSTATUS] = olResponseNone;        // No Response required
@@ -1201,8 +1176,7 @@ 
 						if (!$foundInDeletedRecipients) {
 							if (!isset($recipient[PR_RECIPIENT_FLAGS]) || $recipient[PR_RECIPIENT_FLAGS] != (recipReserved | recipExceptionalDeleted | recipSendable)) {
 								$recipient[PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalDeleted;
-							}
-							else {
+							} else {
 								$recipient[PR_RECIPIENT_FLAGS] = recipReserved | recipExceptionalDeleted | recipSendable;
 							}
 							$recipient[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone;    // No Response required
@@ -1221,8 +1195,7 @@ 
 					}
 				}
 				$exception_recips = array_merge($exception_recips, $deletedRecipients);
-			}
-			else {
+			} else {
 				$exception_recips = $recipientRows;
 			}
 
@@ -1267,8 +1240,7 @@ 
 			foreach ($recipients as $key => $recipient) {
 				if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable | recipOrganizer)) {
 					$hasOrganizer = true;
-				}
-				elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
+				} elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
 					// Recipients for an occurrence
 					$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalResponse;
 				}

mapi/class.freebusypublish.php

Braces +3 added lines, -6 removed lines

@@ -240,8 +240,7 @@ 
 					$recur = new Recurrence($this->store, $row);
 
 					$occurrences = $recur->getItems($starttime, $length);
-				}
-				else {
+				} else {
 					$occurrences[] = $row;
 				}
 
@@ -269,8 +268,7 @@ 
 		// Get the FB interface
 		try {
 			$fbsupport = mapi_freebusysupport_open($this->session, $this->store);
-		}
-		catch (MAPIException $e) {
+		} catch (MAPIException $e) {
 			if ($e->getCode() == MAPI_E_NOT_FOUND) {
 				$e->setHandled();
 				SLog::Write(LOGLEVEL_WARN, "Error in opening freebusysupport object.");
@@ -290,8 +288,7 @@ 
 
 			// We're finished
 			mapi_freebusysupport_close($fbsupport);
-		}
-		else {
+		} else {
 			SLog::Write(LOGLEVEL_WARN, "FreeBusyPublish is not available");
 		}
 	}

mapi/class.baserecurrence.php

Braces +35 added lines, -70 removed lines

@@ -53,8 +53,7 @@ 
 
 			if (is_array($message)) {
 				$this->messageprops = $message;
-			}
-			else {
+			} else {
 				$this->message = $message;
 				$this->messageprops = mapi_getprops($this->message, $this->proptags);
 			}
@@ -218,8 +217,7 @@ 
 
 					if ($ret["subtype"] == 3) {
 						$ret["weekdays"] = $data["monthday"];
-					}
-					else {
+					} else {
 						$ret["monthday"] = $data["monthday"];
 					}
 
@@ -247,8 +245,7 @@ 
 
 					if ($ret["subtype"] == 3) {
 						$ret["weekdays"] = $data["monthday"];
-					}
-					else {
+					} else {
 						$ret["monthday"] = $data["monthday"];
 					}
 
@@ -592,8 +589,7 @@ 
 					if ($this->recur["subtype"] == 1) {
 						// Daily every workday
 						$rdata .= pack("VVVV", (6 * 24 * 60), 1, 0, 0x3E);
-					}
-					else {
+					} else {
 						// Daily every N days (everyN in minutes)
 
 						$everyn = ((int) $this->recur["everyn"]) / 1440;
@@ -669,8 +665,7 @@ 
 
 					if ($this->recur["regen"]) {
 						$rdata .= pack("VVV", $firstocc, (int) $this->recur["everyn"], 1);
-					}
-					else {
+					} else {
 						$rdata .= pack("VVVV", $firstocc, (int) $this->recur["everyn"], 0, (int) $this->recur["weekdays"]);
 					}
 
@@ -689,8 +684,7 @@ 
 
 					if ($term == 0x0C /* monthly */) {
 						$everyn = (int) $this->recur["everyn"];
-					}
-					else {
+					} else {
 						$everyn = $this->recur["regen"] ? ((int) $this->recur["everyn"]) * 12 : 12;
 					}
 
@@ -733,18 +727,15 @@ 
 								if ($term == 0x0D /* yearly */) {
 									if ($curmonth > $selmonth) {// go to next occurrence in 'everyn' months minus difference in first occurrence and original date
 										$count = $everyn - ($curmonth - $selmonth);
-									}
-									elseif ($curmonth < $selmonth) {// go to next occurrence upto difference in first occurrence and original date
+									} elseif ($curmonth < $selmonth) {// go to next occurrence upto difference in first occurrence and original date
 										$count = $selmonth - $curmonth;
-									}
-									else {
+									} else {
 										// Go to next occurrence while recurrence start date is greater than occurrence date but within same month
 										if (((int) $this->recur["monthday"]) < $curmonthday) {
 											$count = $everyn;
 										}
 									}
-								}
-								else {
+								} else {
 									$count = $everyn; // Monthly, go to next occurrence in 'everyn' months
 								}
 
@@ -782,8 +773,7 @@ 
 								}
 
 								$rdata .= pack("VVVV", $firstocc, $everyn, $this->recur["regen"], (int) $this->recur["monthday"]);
-							}
-							else {
+							} else {
 								// Calc first occ
 								$firstocc = 0;
 								$monthIndex = (int) gmdate("n", $this->recur["start"]);
@@ -812,8 +802,7 @@ 
 							if ($nday == 5) {
 								// Set date on the last day of the last month
 								$monthbegindow += (gmdate("t", $monthbegindow) - gmdate("j", $monthbegindow)) * 24 * 60 * 60;
-							}
-							else {
+							} else {
 								// Set on the first day of the month
 								$monthbegindow -= ((gmdate("j", $monthbegindow) - 1) * 24 * 60 * 60);
 							}
@@ -822,8 +811,7 @@ 
 								// Set on right month
 								if ($selmonth < $curmonth) {
 									$tmp = 12 - $curmonth + $selmonth;
-								}
-								else {
+								} else {
 									$tmp = ($selmonth - $curmonth);
 								}
 
@@ -836,8 +824,7 @@ 
 									}
 									++$curmonth;
 								}
-							}
-							else {
+							} else {
 								// Check or you exist in the right month
 
 								$dayofweek = gmdate("w", $monthbegindow);
@@ -900,8 +887,7 @@ 
 							}
 							if ($nday == 5) {
 								$monthbegindow -= $day * 24 * 60 * 60;
-							}
-							else {
+							} else {
 								$monthbegindow += ($day - 1) * 24 * 60 * 60;
 							}
 
@@ -916,8 +902,7 @@ 
 								}
 
 								$rdata .= pack("VVVVV", $firstocc, $everyn, 0, $weekdays, $nday);
-							}
-							else {
+							} else {
 								// Calc first occ
 								$monthIndex = (int) gmdate("n", $this->recur["start"]);
 
@@ -967,8 +952,7 @@ 
 			// Strange little thing for the recurrence type "every workday"
 			if (((int) $this->recur["type"]) == 0x0B && ((int) $this->recur["subtype"]) == 1) {
 				$rdata .= pack("V", 1);
-			}
-			else { // Other recurrences
+			} else { // Other recurrences
 				$rdata .= pack("V", 0);
 			}
 
@@ -1046,8 +1030,7 @@ 
 
 									$occenddate += 24 * 60 * 60;
 								}
-							}
-							else {
+							} else {
 								// -1 because the first day already counts (from 1-1-1980 to 1-1-1980 is 1 occurrence)
 								$occenddate += (((int) $this->recur["everyn"]) * 60 * (((int) $this->recur["numoccur"] - 1)));
 							}
@@ -1096,8 +1079,7 @@ 
 										if ($curmonth >= 12) {
 											$curmonth = 1;
 											++$curyear;
-										}
-										else {
+										} else {
 											++$curmonth;
 										}
 										--$forwardcount;
@@ -1108,8 +1090,7 @@ 
 										gmdate("j", $occenddate) < ((int) $this->recur["monthday"])) {
 										if (gmdate("j", $occenddate) < 28) {
 											$occenddate -= gmdate("j", $occenddate) * 24 * 60 * 60;
-										}
-										else {
+										} else {
 											$occenddate += (gmdate("t", $occenddate) - gmdate("j", $occenddate)) * 24 * 60 * 60;
 										}
 									}
@@ -1125,8 +1106,7 @@ 
 										if ($curmonth >= 12) {
 											$curmonth = 1;
 											++$curyear;
-										}
-										else {
+										} else {
 											++$curmonth;
 										}
 
@@ -1136,8 +1116,7 @@ 
 									if ($nday == 5) {
 										// Set date on the last day of the last month
 										$occenddate += (gmdate("t", $occenddate) - gmdate("j", $occenddate)) * 24 * 60 * 60;
-									}
-									else {
+									} else {
 										// Set date on the first day of the last month
 										$occenddate -= (gmdate("j", $occenddate) - 1) * 24 * 60 * 60;
 									}
@@ -1208,8 +1187,7 @@ 
 
 				// set named prop 'side_effects' to 369, needed for Outlook to ask for single or total recurrence when deleting
 				$propsToSet[$this->proptags["side_effects"]] = 369;
-			}
-			else {
+			} else {
 				$propsToSet[$this->proptags["side_effects"]] = 3441;
 			}
 
@@ -1239,8 +1217,7 @@ 
 
 				if ($occ) {
 					$propsToSet[$this->proptags["flagdueby"]] = $occ[$this->proptags["startdate"]] - ($reminderprops[$this->proptags["reminder_minutes"]] * 60);
-				}
-				else {
+				} else {
 					// Last reminder passed, no reminders any more.
 					$propsToSet[$this->proptags["reminder"]] = false;
 					$propsToSet[$this->proptags["flagdueby"]] = 0x7FF00000;
@@ -1459,11 +1436,9 @@ 
 		public function getMonthInSeconds($year, $month) {
 			if (in_array($month, [1, 3, 5, 7, 8, 10, 12])) {
 				$day = 31;
-			}
-			elseif (in_array($month, [4, 6, 9, 11])) {
+			} elseif (in_array($month, [4, 6, 9, 11])) {
 				$day = 30;
-			}
-			else {
+			} else {
 				$day = 28;
 				if ($this->isLeapYear($year) == 1) {
 					++$day;
@@ -1533,8 +1508,7 @@ 
 				if ($date > $dststart && $date < $dstend) {
 					$dst = true;
 				}
-			}
-			else {
+			} else {
 				// Southern hemisphere, eg DST is during Oct-Mar
 				if ($date < $dstend || $date > $dststart) {
 					$dst = true;
@@ -1720,8 +1694,7 @@ 
 				// TODO use one isset
 				if (isset($this->recur['regen'], $this->action['datecompleted']) && $this->recur['regen']) {
 					$daystart = $this->dayStartOf($this->action['datecompleted']);
-				}
-				else {
+				} else {
 					$daystart = $this->dayStartOf($this->recur["start"]); // start on first day of occurrence
 				}
 
@@ -1729,8 +1702,7 @@ 
 				// or the end of the recurrence, whichever comes first
 				if ($end > $this->toGMT($this->tz, $this->recur["end"])) {
 					$rangeend = $this->toGMT($this->tz, $this->recur["end"]);
-				}
-				else {
+				} else {
 					$rangeend = $end;
 				}
 
@@ -1750,8 +1722,7 @@ 
 						for ($now = $daystart; $now <= $dayend && ($limit == 0 || count($items) < $limit); $now += 60 * $this->recur["everyn"]) {
 							$this->processOccurrenceItem($items, $start, $end, $now, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
 						}
-					}
-					else {
+					} else {
 						// Every workday
 						for ($now = $daystart; $now <= $dayend && ($limit == 0 || count($items) < $limit); $now += 60 * 1440) {
 							$nowtime = $this->gmtime($now);
@@ -1777,8 +1748,7 @@ 
 					for ($now = $daystart; $now <= $dayend && ($limit == 0 || count($items) < $limit); $now += (60 * 60 * 24 * 7 * $this->recur["everyn"])) {
 						if ($this->recur['regen']) {
 							$this->processOccurrenceItem($items, $start, $end, $now, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
-						}
-						else {
+						} else {
 							// Loop through the whole following week to the first occurrence of the week, add each day that is specified
 							for ($wday = 0; $wday < 7; ++$wday) {
 								$daynow = $now + $wday * 60 * 60 * 24;
@@ -1813,8 +1783,7 @@ 
 							if ($daynow <= $dayend) {
 								$this->processOccurrenceItem($items, $start, $end, $daynow, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
 							}
-						}
-						elseif (isset($this->recur["nday"], $this->recur["weekdays"])) { // Nth [weekday] of every N months
+						} elseif (isset($this->recur["nday"], $this->recur["weekdays"])) { // Nth [weekday] of every N months
 							// Sanitize input
 							if ($this->recur["weekdays"] == 0) {
 								$this->recur["weekdays"] = 1;
@@ -1841,8 +1810,7 @@ 
 								}
 								// $firstday is the day of the month on which the asked pattern of nth weekday matches
 								$daynow = $now + $firstday * 60 * 60 * 24;
-							}
-							else {
+							} else {
 								// Find last day in the month ($now is the firstday of the month)
 								$NumDaysInMonth = $this->daysInMonth($now, 1);
 								$daynow = $now + (($NumDaysInMonth - 1) * 24 * 60 * 60);
@@ -1860,8 +1828,7 @@ 
 							if ($daynow <= $dayend && $daynow >= $daystart) {
 								$this->processOccurrenceItem($items, $start, $end, $daynow, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
 							}
-						}
-						elseif ($this->recur['regen']) {
+						} elseif ($this->recur['regen']) {
 							$next_month_start = $now + ($this->daysInMonth($now, 1) * 24 * 60 * 60);
 							$now = $daystart + ($this->daysInMonth($next_month_start, $this->recur['everyn']) * 24 * 60 * 60);
 
@@ -1890,8 +1857,7 @@ 
 							}    // Cap $monthday on month length (eg 28 feb instead of 29 feb)
 							$daynow = $monthstart + ($monthday - 1) * 24 * 60 * 60;
 							$this->processOccurrenceItem($items, $start, $end, $daynow, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
-						}
-						elseif (isset($this->recur["nday"], $this->recur["weekdays"])) { // Nth [weekday] in month X of every N years
+						} elseif (isset($this->recur["nday"], $this->recur["weekdays"])) { // Nth [weekday] in month X of every N years
 							// Go the correct month
 							$monthnow = $now + $this->daysInMonth($now, $this->monthOfYear($this->recur["month"])) * 24 * 60 * 60;
 
@@ -1915,8 +1881,7 @@ 
 							}
 
 							$this->processOccurrenceItem($items, $start, $end, $daynow, $this->recur["startocc"], $this->recur["endocc"], $this->tz, $remindersonly);
-						}
-						elseif ($this->recur['regen']) {
+						} elseif ($this->recur['regen']) {
 							$year_starttime = $this->gmtime($now);
 							$is_next_leapyear = $this->isLeapYear($year_starttime['tm_year'] + 1900 + 1);    // +1 next year
 							$now = $daystart + ($is_next_leapyear ? 31622400 /* Leap year in seconds */ : 31536000 /* year in seconds */);

mapi/mapi.util.php

Braces +5 added lines, -10 removed lines

@@ -56,8 +56,7 @@ 
 				}
 			}
 		}
-	}
-	else {
+	} else {
 		return "NOERROR";
 	}
 
@@ -98,8 +97,7 @@ 
 
 			if (substr($split[2], 0, 2) == "0x") {
 				$id = hexdec(substr($split[2], 2));
-			}
-			else {
+			} else {
 				$id = $split[2];
 			}
 
@@ -109,8 +107,7 @@ 
 					$guids[$split[1]] = makeguid($split[1]);
 				}
 				$guid = $guids[$split[1]];
-			}
-			else {
+			} else {
 				$guid = constant($split[1]);
 			}
 
@@ -120,8 +117,7 @@ 
 			$ids["guid"][$num] = $guid;
 			$ids["type"][$num] = $split[0];
 			++$num;
-		}
-		else {
+		} else {
 			// not a named property
 			$props[$name] = $val;
 		}
@@ -280,8 +276,7 @@ 
 				$item = $occurrence + $row;
 				array_push($items, $item);
 			}
-		}
-		else {
+		} else {
 			// Normal item, it matched the search criteria and therefore overlaps the interval <$viewstart, $viewend>
 			array_push($items, $row);
 		}

mapi/class.taskrequest.php

Braces +6 added lines, -12 removed lines

@@ -271,8 +271,7 @@ 
 				// Copy sender information from the e-mail
 				$props = mapi_getprops($this->message, $senderProps);
 				mapi_setprops($task, $props);
-			}
-			else {
+			} else {
 				// If there are multiple, just use the first
 				$entryid = $rows[0][PR_ENTRYID];
 
@@ -575,8 +574,7 @@ 
 
 			if (isset($messageprops)) {
 				++$messageprops[$this->props['updatecount']];
-			}
-			else {
+			} else {
 				$messageprops[$this->props['updatecount']] = 1;
 			}
 
@@ -754,8 +752,7 @@ 
 			$props = mapi_getprops($this->message, [$this->props['taskupdates'], $this->props['tasksoc'], $this->props['recurring'], $this->props['complete']]);
 			if (!$props[$this->props['complete']] && $props[$this->props['taskupdates']] && !(isset($props[$this->props['recurring']]) && $props[$this->props['recurring']])) {
 				$this->sendResponse(tdmtTaskUpd, _("Task Updated:") . " ");
-			}
-			elseif ($props[$this->props['complete']]) {
+			} elseif ($props[$this->props['complete']]) {
 				$this->sendResponse(tdmtTaskUpd, _("Task Completed:") . " ");
 			}
 
@@ -778,8 +775,7 @@ 
 
 			if (!$ownerentryid) {
 				$store = $this->store;
-			}
-			else {
+			} else {
 				$ab = mapi_openaddressbook($this->session);
 				if (!$ab) {
 					return false;
@@ -922,8 +918,7 @@ 
 					mapi_setprops($sub, [PR_ICON_INDEX => ICON_TASK_ASSIGNER]);
 					if ($messageprops[$this->props['complete']]) {
 						$props[PR_MESSAGE_CLASS] = "IPM.TaskRequest.Complete";
-					}
-					else {
+					} else {
 						$props[PR_MESSAGE_CLASS] = "IPM.TaskRequest.Update";
 					}
 
@@ -1011,8 +1006,7 @@ 
 				try {
 					$attach = mapi_message_openattach($message, $row[PR_ATTACH_NUM]);
 					$task = mapi_attach_openobj($attach);
-				}
-				catch (MAPIException $e) {
+				} catch (MAPIException $e) {
 					continue;
 				}
 

grommunio-sync-top.php

Braces +22 added lines, -44 removed lines

@@ -53,12 +53,10 @@ 
 			$zpt->run();
 			$zpt->scrClear();
 			system("stty sane");
-		}
-		else {
+		} else {
 			echo "grommunio-sync interprocess communication (IPC) is not available or TopCollector is disabled.\n";
 		}
-	}
-	catch (GSyncException $zpe) {
+	} catch (GSyncException $zpe) {
 		fwrite(STDERR, get_class($zpe) . ": " . $zpe->getMessage() . "\n");
 
 		exit(1);
@@ -173,8 +171,7 @@ 
 			if ($this->scrSize['width'] != $s['width']) {
 				if ($s['width'] > 180) {
 					$this->wide = true;
-				}
-				else {
+				} else {
 					$this->wide = false;
 				}
 			}
@@ -260,15 +257,12 @@ 
 						$lastUpdate = $this->currenttime - $line["update"];
 						if ($this->currenttime - $line["update"] < 2) {
 							$this->linesActive[$line["update"] . $line["pid"]] = $line;
-						}
-						elseif (($line['push'] === true && $lastUpdate > ($this->pingInterval + 2)) || ($line['push'] !== true && $lastUpdate > 4)) {
+						} elseif (($line['push'] === true && $lastUpdate > ($this->pingInterval + 2)) || ($line['push'] !== true && $lastUpdate > 4)) {
 							$this->linesUnknown[$line["update"] . $line["pid"]] = $line;
-						}
-						else {
+						} else {
 							$this->linesOpen[$line["update"] . $line["pid"]] = $line;
 						}
-					}
-					else {
+					} else {
 						// do not show terminated + expired connections
 						if ($this->currenttime > $line['ended'] + $this->showTermSec) {
 							continue;
@@ -490,51 +484,40 @@ 
 					$this->topCollector->ClearLatest(true);
 
 					$this->terminate = true;
-				}
-				elseif ($cmds[0] == "clear") {
+				} elseif ($cmds[0] == "clear") {
 					$this->topCollector->ClearLatest(true);
 					$this->topCollector->CollectData(true);
 					$this->topCollector->ReInitIPC();
-				}
-				elseif ($cmds[0] == "filter" || $cmds[0] == "f") {
+				} elseif ($cmds[0] == "filter" || $cmds[0] == "f") {
 					if (!isset($cmds[1]) || $cmds[1] == "") {
 						$this->filter = false;
 						$this->status = "No filter";
 						$this->statusexpire = $this->currenttime + 5;
-					}
-					else {
+					} else {
 						$this->filter = $cmds[1];
 						$this->status = false;
 					}
-				}
-				elseif ($cmds[0] == "option" || $cmds[0] == "o") {
+				} elseif ($cmds[0] == "option" || $cmds[0] == "o") {
 					if (!isset($cmds[1]) || $cmds[1] == "") {
 						$this->status = "Option value needs to be specified. See 'help' or 'h' for instructions";
 						$this->statusexpire = $this->currenttime + 5;
-					}
-					elseif ($cmds[1] == "p" || $cmds[1] == "push" || $cmds[1] == "ping") {
+					} elseif ($cmds[1] == "p" || $cmds[1] == "push" || $cmds[1] == "ping") {
 						$this->showPush = !$this->showPush;
-					}
-					elseif ($cmds[1] == "a" || $cmds[1] == "active") {
+					} elseif ($cmds[1] == "a" || $cmds[1] == "active") {
 						$this->showOption = self::SHOW_ACTIVE_ONLY;
-					}
-					elseif ($cmds[1] == "u" || $cmds[1] == "unknown") {
+					} elseif ($cmds[1] == "u" || $cmds[1] == "unknown") {
 						$this->showOption = self::SHOW_UNKNOWN_ONLY;
-					}
-					elseif ($cmds[1] == "d" || $cmds[1] == "default") {
+					} elseif ($cmds[1] == "d" || $cmds[1] == "default") {
 						$this->showOption = self::SHOW_DEFAULT;
 						$this->showTermSec = self::SHOW_TERM_DEFAULT_TIME;
 						$this->showPush = true;
-					}
-					elseif (is_numeric($cmds[1])) {
+					} elseif (is_numeric($cmds[1])) {
 						$this->showTermSec = $cmds[1];
-					}
-					else {
+					} else {
 						$this->status = sprintf("Option '%s' unknown", $cmds[1]);
 						$this->statusexpire = $this->currenttime + 5;
 					}
-				}
-				elseif ($cmds[0] == "reset" || $cmds[0] == "r") {
+				} elseif ($cmds[0] == "reset" || $cmds[0] == "r") {
 					$this->filter = false;
 					$this->wide = false;
 					$this->helpexpire = 0;
@@ -546,16 +529,14 @@ 
 					$this->wide = !$this->wide;
 					$this->status = ($this->wide) ? "w i d e  view" : "normal view";
 					$this->statusexpire = $this->currenttime + 2;
-				}
-				elseif ($cmds[0] == "help" || $cmds[0] == "h") {
+				} elseif ($cmds[0] == "help" || $cmds[0] == "h") {
 					$this->helpexpire = $this->currenttime + 20;
 				}
 				// grep the log file
 				elseif (($cmds[0] == "log" || $cmds[0] == "l") && isset($cmds[1])) {
 					if (!file_exists(LOGFILE)) {
 						$this->status = "Logfile can not be found: " . LOGFILE;
-					}
-					else {
+					} else {
 						system('bash -c "fgrep -a ' . escapeshellarg($cmds[1]) . ' ' . LOGFILE . ' | less +G" > `tty`');
 						$this->status = "Returning from log, updating data";
 					}
@@ -565,8 +546,7 @@ 
 				elseif (($cmds[0] == "tail" || $cmds[0] == "t")) {
 					if (!file_exists(LOGFILE)) {
 						$this->status = "Logfile can not be found: " . LOGFILE;
-					}
-					else {
+					} else {
 						$this->doingTail = true;
 						$this->scrClear();
 						$this->scrPrintAt(1, 0, $this->scrAsBold("Press CTRL+C to return to grommunio-sync-top\n\n"));
@@ -584,8 +564,7 @@ 
 				elseif (($cmds[0] == "error" || $cmds[0] == "e")) {
 					if (!file_exists(LOGERRORFILE)) {
 						$this->status = "Error logfile can not be found: " . LOGERRORFILE;
-					}
-					else {
+					} else {
 						$this->doingTail = true;
 						$this->scrClear();
 						$this->scrPrintAt(1, 0, $this->scrAsBold("Press CTRL+C to return to grommunio-sync-top\n\n"));
@@ -598,8 +577,7 @@ 
 						$this->status = "Returning from tail, updating data";
 					}
 					$this->statusexpire = time() + 5; // it might be much "later" now
-				}
-				elseif ($cmds[0] != "") {
+				} elseif ($cmds[0] != "") {
 					$this->status = sprintf("Command '%s' unknown", $cmds[0]);
 					$this->statusexpire = $this->currenttime + 8;
 				}