| Conditions | 3 |
| Paths | 4 |
| Total Lines | 121 |
| Code Lines | 68 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 31 | public function __construct() { |
||
| 32 | $mapping = [ |
||
| 33 | SYNC_POOMMAIL_ALLDAYEVENT => [ |
||
| 34 | self::STREAMER_VAR => "alldayevent", |
||
| 35 | self::STREAMER_CHECKS => [self::STREAMER_CHECK_ZEROORONE => self::STREAMER_CHECK_SETZERO], |
||
| 36 | ], |
||
| 37 | SYNC_POOMMAIL_STARTTIME => [ |
||
| 38 | self::STREAMER_VAR => "starttime", |
||
| 39 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 40 | self::STREAMER_CHECKS => [ |
||
| 41 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 42 | self::STREAMER_CHECK_CMPLOWER => SYNC_POOMMAIL_ENDTIME, |
||
| 43 | ], |
||
| 44 | ], |
||
| 45 | SYNC_POOMMAIL_DTSTAMP => [ |
||
| 46 | self::STREAMER_VAR => "dtstamp", |
||
| 47 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 48 | self::STREAMER_CHECKS => [self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO], |
||
| 49 | ], |
||
| 50 | SYNC_POOMMAIL_ENDTIME => [ |
||
| 51 | self::STREAMER_VAR => "endtime", |
||
| 52 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 53 | self::STREAMER_CHECKS => [ |
||
| 54 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETONE, |
||
| 55 | self::STREAMER_CHECK_CMPHIGHER => SYNC_POOMMAIL_STARTTIME, |
||
| 56 | ], |
||
| 57 | ], |
||
| 58 | // Instancetype values |
||
| 59 | // 0 = single appointment |
||
| 60 | // 1 = master recurring appointment |
||
| 61 | // 2 = single instance of recurring appointment |
||
| 62 | // 3 = exception of recurring appointment |
||
| 63 | SYNC_POOMMAIL_INSTANCETYPE => [ |
||
| 64 | self::STREAMER_VAR => "instancetype", |
||
| 65 | self::STREAMER_CHECKS => [ |
||
| 66 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 67 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2, 3], |
||
| 68 | ], |
||
| 69 | ], |
||
| 70 | SYNC_POOMMAIL_LOCATION => [self::STREAMER_VAR => "location"], |
||
| 71 | SYNC_POOMMAIL_ORGANIZER => [ |
||
| 72 | self::STREAMER_VAR => "organizer", |
||
| 73 | self::STREAMER_CHECKS => [self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETEMPTY], |
||
| 74 | ], |
||
| 75 | SYNC_POOMMAIL_RECURRENCEID => [ |
||
| 76 | self::STREAMER_VAR => "recurrenceid", |
||
| 77 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 78 | ], |
||
| 79 | SYNC_POOMMAIL_REMINDER => [ |
||
| 80 | self::STREAMER_VAR => "reminder", |
||
| 81 | self::STREAMER_CHECKS => [self::STREAMER_CHECK_CMPHIGHER => -1], |
||
| 82 | ], |
||
| 83 | SYNC_POOMMAIL_RESPONSEREQUESTED => [self::STREAMER_VAR => "responserequested"], |
||
| 84 | SYNC_POOMMAIL_RECURRENCES => [ |
||
| 85 | self::STREAMER_VAR => "recurrences", |
||
| 86 | self::STREAMER_TYPE => "SyncMeetingRequestRecurrence", |
||
| 87 | self::STREAMER_ARRAY => SYNC_POOMMAIL_RECURRENCE, |
||
| 88 | ], |
||
| 89 | // Sensitivity values |
||
| 90 | // 0 = Normal |
||
| 91 | // 1 = Personal |
||
| 92 | // 2 = Private |
||
| 93 | // 3 = Confident |
||
| 94 | SYNC_POOMMAIL_SENSITIVITY => [ |
||
| 95 | self::STREAMER_VAR => "sensitivity", |
||
| 96 | self::STREAMER_CHECKS => [ |
||
| 97 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 98 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2, 3], |
||
| 99 | ], |
||
| 100 | ], |
||
| 101 | // Busystatus values |
||
| 102 | // 0 = Free |
||
| 103 | // 1 = Tentative |
||
| 104 | // 2 = Busy |
||
| 105 | // 3 = Out of office |
||
| 106 | // 4 = Working Elsewhere |
||
| 107 | SYNC_POOMMAIL_BUSYSTATUS => [ |
||
| 108 | self::STREAMER_VAR => "busystatus", |
||
| 109 | self::STREAMER_CHECKS => [ |
||
| 110 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETTWO, |
||
| 111 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2, 3, 4], |
||
| 112 | ], |
||
| 113 | ], |
||
| 114 | SYNC_POOMMAIL_TIMEZONE => [ |
||
| 115 | self::STREAMER_VAR => "timezone", |
||
| 116 | self::STREAMER_CHECKS => [ |
||
| 117 | self::STREAMER_CHECK_REQUIRED => base64_encode(pack("la64vvvvvvvv" . "la64vvvvvvvv" . "l", 0, "", 0, 0, 0, 0, 0, 0, 0, 0, 0, "", 0, 0, 0, 0, 0, 0, 0, 0, 0)), |
||
| 118 | ], |
||
| 119 | ], |
||
| 120 | SYNC_POOMMAIL_GLOBALOBJID => [self::STREAMER_VAR => "globalobjid"], |
||
| 121 | ]; |
||
| 122 | |||
| 123 | if (Request::GetProtocolVersion() >= 14.0) { |
||
| 124 | $mapping[SYNC_POOMMAIL_DISALLOWNEWTIMEPROPOSAL] = [ |
||
| 125 | self::STREAMER_VAR => "disallownewtimeproposal", |
||
| 126 | self::STREAMER_CHECKS => [ |
||
| 127 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 128 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1], |
||
| 129 | ], |
||
| 130 | ]; |
||
| 131 | } |
||
| 132 | |||
| 133 | if (Request::GetProtocolVersion() >= 14.1) { |
||
| 134 | // MeetingMessageType values |
||
| 135 | // 0 = A silent update was performed, or the message type is unspecified. |
||
| 136 | // 1 = Initial meeting request. |
||
| 137 | // 2 = Full update. |
||
| 138 | // 3 = Informational update. |
||
| 139 | // 4 = Outdated. A newer meeting request or meeting update was received after this message. |
||
| 140 | // 5 = Identifies the delegator's copy of the meeting request. |
||
| 141 | // 6 = Identifies that the meeting request has been delegated and the meeting request cannot be responded to. |
||
| 142 | $mapping[SYNC_POOMMAIL2_MEETINGMESSAGETYPE] = [ |
||
| 143 | self::STREAMER_VAR => "meetingmessagetype", |
||
| 144 | self::STREAMER_CHECKS => [ |
||
| 145 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 146 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2, 3, 4, 5, 6], |
||
| 147 | ], |
||
| 148 | ]; |
||
| 149 | } |
||
| 150 | |||
| 151 | parent::__construct($mapping); |
||
| 152 | } |
||
| 154 |