Passed
Branch 45-mixed-bag-of-php-modernizat... (2062ef)
by Michael
21:48 queued 17:36
created
lib/core/statemanager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -520,8 +520,8 @@
 block discarded – undo
520 520
 			mt_rand(0, 0xFFFF),
521 521
 			mt_rand(0, 0xFFFF),
522 522
 			mt_rand(0, 0xFFFF),
523
-			mt_rand(0, 0x0FFF) | 0x4000,
524
-			mt_rand(0, 0x3FFF) | 0x8000,
523
+			mt_rand(0, 0x0FFF)|0x4000,
524
+			mt_rand(0, 0x3FFF)|0x8000,
525 525
 			mt_rand(0, 0xFFFF),
526 526
 			mt_rand(0, 0xFFFF),
527 527
 			mt_rand(0, 0xFFFF)
Please login to merge, or discard this patch.
mapi/class.recurrence.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -734,7 +734,7 @@  discard block
 block discarded – undo
734 734
 			$props[PR_EXCEPTION_ENDTIME] = $this->fromGMT($this->tz, $exception_props[$this->proptags["duedate"]]);
735 735
 			mapi_setprops($attachment, $props);
736 736
 
737
-			$imessage = mapi_attach_openobj($attachment, MAPI_CREATE | MAPI_MODIFY);
737
+			$imessage = mapi_attach_openobj($attachment, MAPI_CREATE|MAPI_MODIFY);
738 738
 
739 739
 			if ($copy_attach_from) {
740 740
 				$attachmentTable = mapi_message_getattachmenttable($copy_attach_from);
@@ -1114,13 +1114,13 @@  discard block
 block discarded – undo
1114 1114
 			// Remove all deleted recipients
1115 1115
 			if (isset($exception_recips['remove'])) {
1116 1116
 				foreach ($exception_recips['remove'] as &$recip) {
1117
-					if (!isset($recip[PR_RECIPIENT_FLAGS]) || $recip[PR_RECIPIENT_FLAGS] != (recipReserved | recipExceptionalDeleted | recipSendable)) {
1118
-						$recip[PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalDeleted;
1117
+					if (!isset($recip[PR_RECIPIENT_FLAGS]) || $recip[PR_RECIPIENT_FLAGS] != (recipReserved|recipExceptionalDeleted|recipSendable)) {
1118
+						$recip[PR_RECIPIENT_FLAGS] = recipSendable|recipExceptionalDeleted;
1119 1119
 					}
1120 1120
 					else {
1121
-						$recip[PR_RECIPIENT_FLAGS] = recipReserved | recipExceptionalDeleted | recipSendable;
1121
+						$recip[PR_RECIPIENT_FLAGS] = recipReserved|recipExceptionalDeleted|recipSendable;
1122 1122
 					}
1123
-					$recip[PR_RECIPIENT_TRACKSTATUS] = olResponseNone;        // No Response required
1123
+					$recip[PR_RECIPIENT_TRACKSTATUS] = olResponseNone; // No Response required
1124 1124
 				}
1125 1125
 				unset($recip);
1126 1126
 				mapi_message_modifyrecipients($exception, MODRECIP_MODIFY, $exception_recips['remove']);
@@ -1190,13 +1190,13 @@  discard block
 block discarded – undo
1190 1190
 
1191 1191
 						// If recipient is not in list of deleted recipient, add him
1192 1192
 						if (!$foundInDeletedRecipients) {
1193
-							if (!isset($recipient[PR_RECIPIENT_FLAGS]) || $recipient[PR_RECIPIENT_FLAGS] != (recipReserved | recipExceptionalDeleted | recipSendable)) {
1194
-								$recipient[PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalDeleted;
1193
+							if (!isset($recipient[PR_RECIPIENT_FLAGS]) || $recipient[PR_RECIPIENT_FLAGS] != (recipReserved|recipExceptionalDeleted|recipSendable)) {
1194
+								$recipient[PR_RECIPIENT_FLAGS] = recipSendable|recipExceptionalDeleted;
1195 1195
 							}
1196 1196
 							else {
1197
-								$recipient[PR_RECIPIENT_FLAGS] = recipReserved | recipExceptionalDeleted | recipSendable;
1197
+								$recipient[PR_RECIPIENT_FLAGS] = recipReserved|recipExceptionalDeleted|recipSendable;
1198 1198
 							}
1199
-							$recipient[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone;    // No Response required
1199
+							$recipient[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone; // No Response required
1200 1200
 							$deletedRecipients[] = $recipient;
1201 1201
 						}
1202 1202
 					}
@@ -1256,12 +1256,12 @@  discard block
 block discarded – undo
1256 1256
 			$hasOrganizer = false;
1257 1257
 			// Check if meeting already has an organizer.
1258 1258
 			foreach ($recipients as $key => $recipient) {
1259
-				if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable | recipOrganizer)) {
1259
+				if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable|recipOrganizer)) {
1260 1260
 					$hasOrganizer = true;
1261 1261
 				}
1262 1262
 				elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
1263 1263
 					// Recipients for an occurrence
1264
-					$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalResponse;
1264
+					$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable|recipExceptionalResponse;
1265 1265
 				}
1266 1266
 			}
1267 1267
 
@@ -1275,7 +1275,7 @@  discard block
 block discarded – undo
1275 1275
 				$organizer[PR_RECIPIENT_DISPLAY_NAME] = $messageProps[PR_SENT_REPRESENTING_NAME];
1276 1276
 				$organizer[PR_ADDRTYPE] = empty($messageProps[PR_SENT_REPRESENTING_ADDRTYPE]) ? 'SMTP' : $messageProps[PR_SENT_REPRESENTING_ADDRTYPE];
1277 1277
 				$organizer[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone;
1278
-				$organizer[PR_RECIPIENT_FLAGS] = recipSendable | recipOrganizer;
1278
+				$organizer[PR_RECIPIENT_FLAGS] = recipSendable|recipOrganizer;
1279 1279
 				$organizer[PR_SEARCH_KEY] = $messageProps[PR_SENT_REPRESENTING_SEARCH_KEY];
1280 1280
 
1281 1281
 				// Add organizer to recipients list.
Please login to merge, or discard this patch.
mapi/mapi.util.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 			RES_OR,
227 227
 			[
228 228
 				[
229
-					RES_AND,    // Normal items: itemEnd must be after viewStart, itemStart must be before viewEnd
229
+					RES_AND, // Normal items: itemEnd must be after viewStart, itemStart must be before viewEnd
230 230
 					[
231 231
 						[
232 232
 							RES_PROPERTY,
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 					],
257 257
 				],
258 258
 			], // EXISTS OR
259
-		];        // global OR
259
+		]; // global OR
260 260
 
261 261
 	// Get requested properties, plus whatever we need
262 262
 	$proplist = [PR_ENTRYID, $properties["recurring"], $properties["recurring_data"], $properties["timezone_data"]];
Please login to merge, or discard this patch.
mapi/class.meetingrequest.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -152,15 +152,15 @@  discard block
 block discarded – undo
152 152
 		$properties['reminderminutes'] = 'PT_LONG:PSETID_Common:0x8501';
153 153
 		$properties['reminderset'] = 'PT_BOOLEAN:PSETID_Common:0x8503';
154 154
 		$properties['sendasical'] = 'PT_BOOLEAN:PSETID_Appointment:0x8200';
155
-		$properties['updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8201';                    // AppointmentSequenceNumber
156
-		$properties['last_updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8203';            // AppointmentLastSequence
155
+		$properties['updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8201'; // AppointmentSequenceNumber
156
+		$properties['last_updatecounter'] = 'PT_LONG:PSETID_Appointment:0x8203'; // AppointmentLastSequence
157 157
 		$properties['unknown7'] = 'PT_LONG:PSETID_Appointment:0x8202';
158 158
 		$properties['busystatus'] = 'PT_LONG:PSETID_Appointment:0x8205';
159 159
 		$properties['intendedbusystatus'] = 'PT_LONG:PSETID_Appointment:0x8224';
160 160
 		$properties['start'] = 'PT_SYSTIME:PSETID_Appointment:0x820d';
161 161
 		$properties['responselocation'] = 'PT_STRING8:PSETID_Meeting:0x2';
162 162
 		$properties['location'] = 'PT_STRING8:PSETID_Appointment:0x8208';
163
-		$properties['requestsent'] = 'PT_BOOLEAN:PSETID_Appointment:0x8229';        // PidLidFInvited, MeetingRequestWasSent
163
+		$properties['requestsent'] = 'PT_BOOLEAN:PSETID_Appointment:0x8229'; // PidLidFInvited, MeetingRequestWasSent
164 164
 		$properties['startdate'] = 'PT_SYSTIME:PSETID_Appointment:0x820d';
165 165
 		$properties['duedate'] = 'PT_SYSTIME:PSETID_Appointment:0x820e';
166 166
 		$properties['flagdueby'] = 'PT_SYSTIME:PSETID_Common:0x8560';
@@ -169,11 +169,11 @@  discard block
 block discarded – undo
169 169
 		$properties['recurring'] = 'PT_BOOLEAN:PSETID_Appointment:0x8223';
170 170
 		$properties['clipstart'] = 'PT_SYSTIME:PSETID_Appointment:0x8235';
171 171
 		$properties['clipend'] = 'PT_SYSTIME:PSETID_Appointment:0x8236';
172
-		$properties['start_recur_date'] = 'PT_LONG:PSETID_Meeting:0xD';                // StartRecurTime
173
-		$properties['start_recur_time'] = 'PT_LONG:PSETID_Meeting:0xE';                // StartRecurTime
174
-		$properties['end_recur_date'] = 'PT_LONG:PSETID_Meeting:0xF';                // EndRecurDate
175
-		$properties['end_recur_time'] = 'PT_LONG:PSETID_Meeting:0x10';                // EndRecurTime
176
-		$properties['is_exception'] = 'PT_BOOLEAN:PSETID_Meeting:0xA';                // LID_IS_EXCEPTION
172
+		$properties['start_recur_date'] = 'PT_LONG:PSETID_Meeting:0xD'; // StartRecurTime
173
+		$properties['start_recur_time'] = 'PT_LONG:PSETID_Meeting:0xE'; // StartRecurTime
174
+		$properties['end_recur_date'] = 'PT_LONG:PSETID_Meeting:0xF'; // EndRecurDate
175
+		$properties['end_recur_time'] = 'PT_LONG:PSETID_Meeting:0x10'; // EndRecurTime
176
+		$properties['is_exception'] = 'PT_BOOLEAN:PSETID_Meeting:0xA'; // LID_IS_EXCEPTION
177 177
 		$properties['apptreplyname'] = 'PT_STRING8:PSETID_Appointment:0x8230';
178 178
 		// Propose new time properties
179 179
 		$properties['proposed_start_whole'] = 'PT_SYSTIME:PSETID_Appointment:0x8250';
@@ -545,7 +545,7 @@  discard block
 block discarded – undo
545 545
 		$listProperties['rcvd_representing_search_key'] = PR_RCVD_REPRESENTING_SEARCH_KEY;
546 546
 		$messageProps = mapi_getprops($this->message, $listProperties);
547 547
 
548
-		$goid = $messageProps[$this->proptags['goid']];    // GlobalID (0x3)
548
+		$goid = $messageProps[$this->proptags['goid']]; // GlobalID (0x3)
549 549
 		if (!isset($goid)) {
550 550
 			return;
551 551
 		}
@@ -1443,7 +1443,7 @@  discard block
 block discarded – undo
1443 1443
 		$props[$this->proptags['goid2']] = $goid;
1444 1444
 
1445 1445
 		if (!isset($props[$this->proptags['updatecounter']])) {
1446
-			$props[$this->proptags['updatecounter']] = 0;            // OL also starts sequence no with zero.
1446
+			$props[$this->proptags['updatecounter']] = 0; // OL also starts sequence no with zero.
1447 1447
 			$props[$this->proptags['last_updatecounter']] = 0;
1448 1448
 		}
1449 1449
 
@@ -2292,12 +2292,12 @@  discard block
 block discarded – undo
2292 2292
 		$hasOrganizer = false;
2293 2293
 		// Check if meeting already has an organizer.
2294 2294
 		foreach ($recipients as $key => $recipient) {
2295
-			if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable | recipOrganizer)) {
2295
+			if (isset($recipient[PR_RECIPIENT_FLAGS]) && $recipient[PR_RECIPIENT_FLAGS] == (recipSendable|recipOrganizer)) {
2296 2296
 				$hasOrganizer = true;
2297 2297
 			}
2298 2298
 			elseif ($isException && !isset($recipient[PR_RECIPIENT_FLAGS])) {
2299 2299
 				// Recipients for an occurrence
2300
-				$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable | recipExceptionalResponse;
2300
+				$recipients[$key][PR_RECIPIENT_FLAGS] = recipSendable|recipExceptionalResponse;
2301 2301
 			}
2302 2302
 		}
2303 2303
 
@@ -2311,7 +2311,7 @@  discard block
 block discarded – undo
2311 2311
 			$organizer[PR_RECIPIENT_DISPLAY_NAME] = $messageProps[PR_SENT_REPRESENTING_NAME];
2312 2312
 			$organizer[PR_ADDRTYPE] = empty($messageProps[PR_SENT_REPRESENTING_ADDRTYPE]) ? 'SMTP' : $messageProps[PR_SENT_REPRESENTING_ADDRTYPE];
2313 2313
 			$organizer[PR_RECIPIENT_TRACKSTATUS] = olRecipientTrackStatusNone;
2314
-			$organizer[PR_RECIPIENT_FLAGS] = recipSendable | recipOrganizer;
2314
+			$organizer[PR_RECIPIENT_FLAGS] = recipSendable|recipOrganizer;
2315 2315
 			$organizer[PR_SEARCH_KEY] = $messageProps[PR_SENT_REPRESENTING_SEARCH_KEY];
2316 2316
 
2317 2317
 			// Add organizer to recipients list.
@@ -2498,7 +2498,7 @@  discard block
 block discarded – undo
2498 2498
 				[
2499 2499
 					RES_PROPERTY,
2500 2500
 					[
2501
-						RELOP => RELOP_EQ,    // Equals recipient type 3: Resource
2501
+						RELOP => RELOP_EQ, // Equals recipient type 3: Resource
2502 2502
 						ULPROPTAG => PR_RECIPIENT_TYPE,
2503 2503
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
2504 2504
 					],
@@ -2780,7 +2780,7 @@  discard block
 block discarded – undo
2780 2780
 				[
2781 2781
 					RES_PROPERTY,
2782 2782
 					[
2783
-						RELOP => RELOP_EQ,    // Equals recipient type 3: Resource
2783
+						RELOP => RELOP_EQ, // Equals recipient type 3: Resource
2784 2784
 						ULPROPTAG => PR_RECIPIENT_TYPE,
2785 2785
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
2786 2786
 					],
@@ -3012,7 +3012,7 @@  discard block
 block discarded – undo
3012 3012
 				$restriction[1][] = [
3013 3013
 					RES_PROPERTY,
3014 3014
 					[
3015
-						RELOP => RELOP_NE,    // Does not equal recipient type: MAPI_BCC (Resource)
3015
+						RELOP => RELOP_NE, // Does not equal recipient type: MAPI_BCC (Resource)
3016 3016
 						ULPROPTAG => PR_RECIPIENT_TYPE,
3017 3017
 						VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
3018 3018
 					],
@@ -3109,7 +3109,7 @@  discard block
 block discarded – undo
3109 3109
 									[
3110 3110
 										RES_PROPERTY,
3111 3111
 										[
3112
-											RELOP => RELOP_NE,    // Does not equal recipient type: MAPI_BCC (Resource)
3112
+											RELOP => RELOP_NE, // Does not equal recipient type: MAPI_BCC (Resource)
3113 3113
 											ULPROPTAG => PR_RECIPIENT_TYPE,
3114 3114
 											VALUE => [PR_RECIPIENT_TYPE => MAPI_BCC],
3115 3115
 										],
@@ -3216,7 +3216,7 @@  discard block
 block discarded – undo
3216 3216
 			$newmessageprops[PR_MESSAGE_CLASS] = 'IPM.Schedule.Meeting.Canceled';
3217 3217
 			$newmessageprops[$this->proptags['meetingstatus']] = olMeetingCanceled; // It's a cancel request
3218 3218
 			$newmessageprops[$this->proptags['busystatus']] = fbFree; // set the busy status as free
3219
-			$newmessageprops[PR_IMPORTANCE] = IMPORTANCE_HIGH;    // HIGH Importance
3219
+			$newmessageprops[PR_IMPORTANCE] = IMPORTANCE_HIGH; // HIGH Importance
3220 3220
 			if (isset($newmessageprops[PR_SUBJECT])) {
3221 3221
 				$newmessageprops[PR_SUBJECT] = _('Canceled: ') . $newmessageprops[PR_SUBJECT];
3222 3222
 			}
Please login to merge, or discard this patch.