| Conditions | 2 |
| Paths | 2 |
| Total Lines | 110 |
| Code Lines | 73 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | public function __construct() { |
||
| 33 | $mapping = [ |
||
| 34 | SYNC_POOMTASKS_BODY => [ |
||
| 35 | self::STREAMER_VAR => "body", |
||
| 36 | self::STREAMER_RONOTIFY => true, |
||
| 37 | ], |
||
| 38 | SYNC_POOMTASKS_COMPLETE => [ |
||
| 39 | self::STREAMER_VAR => "complete", |
||
| 40 | self::STREAMER_CHECKS => [ |
||
| 41 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 42 | self::STREAMER_CHECK_ZEROORONE => self::STREAMER_CHECK_SETZERO, |
||
| 43 | ], |
||
| 44 | self::STREAMER_RONOTIFY => true, |
||
| 45 | ], |
||
| 46 | SYNC_POOMTASKS_DATECOMPLETED => [ |
||
| 47 | self::STREAMER_VAR => "datecompleted", |
||
| 48 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 49 | self::STREAMER_RONOTIFY => true, |
||
| 50 | ], |
||
| 51 | SYNC_POOMTASKS_DUEDATE => [ |
||
| 52 | self::STREAMER_VAR => "duedate", |
||
| 53 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 54 | self::STREAMER_RONOTIFY => true, |
||
| 55 | ], |
||
| 56 | SYNC_POOMTASKS_UTCDUEDATE => [ |
||
| 57 | self::STREAMER_VAR => "utcduedate", |
||
| 58 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 59 | self::STREAMER_RONOTIFY => true, |
||
| 60 | ], |
||
| 61 | // Importance values |
||
| 62 | // 0 = Low |
||
| 63 | // 1 = Normal |
||
| 64 | // 2 = High |
||
| 65 | // even the default value 1 is optional, the native android client 2.2 interprets a non-existing value as 0 (low) |
||
| 66 | SYNC_POOMTASKS_IMPORTANCE => [self::STREAMER_VAR => "importance", |
||
| 67 | self::STREAMER_CHECKS => [ |
||
| 68 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETONE, |
||
| 69 | self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2], |
||
| 70 | ], |
||
| 71 | self::STREAMER_RONOTIFY => true, |
||
| 72 | ], |
||
| 73 | SYNC_POOMTASKS_RECURRENCE => [ |
||
| 74 | self::STREAMER_VAR => "recurrence", |
||
| 75 | self::STREAMER_TYPE => "SyncTaskRecurrence", |
||
| 76 | self::STREAMER_RONOTIFY => true, |
||
| 77 | ], |
||
| 78 | SYNC_POOMTASKS_REGENERATE => [ |
||
| 79 | self::STREAMER_VAR => "regenerate", |
||
| 80 | self::STREAMER_RONOTIFY => true, |
||
| 81 | ], |
||
| 82 | SYNC_POOMTASKS_DEADOCCUR => [ |
||
| 83 | self::STREAMER_VAR => "deadoccur", |
||
| 84 | self::STREAMER_RONOTIFY => true, |
||
| 85 | ], |
||
| 86 | SYNC_POOMTASKS_REMINDERSET => [ |
||
| 87 | self::STREAMER_VAR => "reminderset", |
||
| 88 | self::STREAMER_CHECKS => [ |
||
| 89 | self::STREAMER_CHECK_REQUIRED => self::STREAMER_CHECK_SETZERO, |
||
| 90 | self::STREAMER_CHECK_ZEROORONE => self::STREAMER_CHECK_SETZERO, |
||
| 91 | ], |
||
| 92 | self::STREAMER_RONOTIFY => true, |
||
| 93 | ], |
||
| 94 | SYNC_POOMTASKS_REMINDERTIME => [ |
||
| 95 | self::STREAMER_VAR => "remindertime", |
||
| 96 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 97 | self::STREAMER_RONOTIFY => true, |
||
| 98 | ], |
||
| 99 | // Sensitivity values |
||
| 100 | // 0 = Normal |
||
| 101 | // 1 = Personal |
||
| 102 | // 2 = Private |
||
| 103 | // 3 = Confident |
||
| 104 | SYNC_POOMTASKS_SENSITIVITY => [ |
||
| 105 | self::STREAMER_VAR => "sensitivity", |
||
| 106 | self::STREAMER_CHECKS => [self::STREAMER_CHECK_ONEVALUEOF => [0, 1, 2, 3]], |
||
| 107 | self::STREAMER_RONOTIFY => true, |
||
| 108 | ], |
||
| 109 | SYNC_POOMTASKS_STARTDATE => [ |
||
| 110 | self::STREAMER_VAR => "startdate", |
||
| 111 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 112 | self::STREAMER_RONOTIFY => true, |
||
| 113 | ], |
||
| 114 | SYNC_POOMTASKS_UTCSTARTDATE => [ |
||
| 115 | self::STREAMER_VAR => "utcstartdate", |
||
| 116 | self::STREAMER_TYPE => self::STREAMER_TYPE_DATE_DASHES, |
||
| 117 | self::STREAMER_RONOTIFY => true, |
||
| 118 | ], |
||
| 119 | SYNC_POOMTASKS_SUBJECT => [ |
||
| 120 | self::STREAMER_VAR => "subject", |
||
| 121 | self::STREAMER_RONOTIFY => true, |
||
| 122 | ], |
||
| 123 | SYNC_POOMTASKS_CATEGORIES => [ |
||
| 124 | self::STREAMER_VAR => "categories", |
||
| 125 | self::STREAMER_ARRAY => SYNC_POOMTASKS_CATEGORY, |
||
| 126 | self::STREAMER_RONOTIFY => true, |
||
| 127 | ], |
||
| 128 | ]; |
||
| 129 | |||
| 130 | if (Request::GetProtocolVersion() >= 12.0) { |
||
| 131 | $mapping[SYNC_AIRSYNCBASE_BODY] = [ |
||
| 132 | self::STREAMER_VAR => "asbody", |
||
| 133 | self::STREAMER_TYPE => "SyncBaseBody", |
||
| 134 | self::STREAMER_RONOTIFY => true, |
||
| 135 | ]; |
||
| 136 | |||
| 137 | // unset these properties because airsyncbase body and attachments will be used instead |
||
| 138 | unset($mapping[SYNC_POOMTASKS_BODY]); |
||
| 139 | } |
||
| 140 | |||
| 141 | parent::__construct($mapping); |
||
| 142 | } |
||
| 195 |