Test Failed
Push — master ( 8afcbf...5178cf )
by
unknown
02:09
created
lib/AuthBasicBackend.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,8 +16,7 @@  discard block
 block discarded – undo
16 16
 	/**
17 17
 	 * Constructor.
18 18
 	 */
19
-	public function __construct(GrommunioDavBackend $gDavBackend)
20
-	{
19
+	public function __construct(GrommunioDavBackend $gDavBackend) {
21 20
 		$this->gDavBackend = $gDavBackend;
22 21
 	}
23 22
 
@@ -34,8 +33,7 @@  discard block
 block discarded – undo
34 33
 	 *
35 34
 	 * @return bool
36 35
 	 */
37
-	protected function validateUserPass($username, $password)
38
-	{
36
+	protected function validateUserPass($username, $password) {
39 37
 		return $this->gDavBackend->Logon($username, $password);
40 38
 	}
41 39
 }
Please login to merge, or discard this patch.
lib/GrommunioCardDavBackend.php 1 patch
Braces   +12 added lines, -24 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@  discard block
 block discarded – undo
21 21
 	/**
22 22
 	 * Constructor.
23 23
 	 */
24
-	public function __construct(GrommunioDavBackend $gDavBackend, GLogger $glogger)
25
-	{
24
+	public function __construct(GrommunioDavBackend $gDavBackend, GLogger $glogger) {
26 25
 		$this->gDavBackend = $gDavBackend;
27 26
 		$this->logger = $glogger;
28 27
 	}
@@ -45,8 +44,7 @@  discard block
 block discarded – undo
45 44
 	 *
46 45
 	 * @return array
47 46
 	 */
48
-	public function getAddressBooksForUser($principalUri)
49
-	{
47
+	public function getAddressBooksForUser($principalUri) {
50 48
 		$this->logger->trace("principalUri: %s", $principalUri);
51 49
 
52 50
 		return $this->gDavBackend->GetFolders($principalUri, static::CONTAINER_CLASSES);
@@ -66,8 +64,7 @@  discard block
 block discarded – undo
66 64
 	 *
67 65
 	 * @param string $addressBookId
68 66
 	 */
69
-	public function updateAddressBook($addressBookId, \Sabre\DAV\PropPatch $propPatch)
70
-	{
67
+	public function updateAddressBook($addressBookId, \Sabre\DAV\PropPatch $propPatch) {
71 68
 		// TODO is our logger able to log this object? It probably needs to be adapted.
72 69
 		$this->logger->trace("addressBookId: %s - proppatch: %s", $addressBookId, $propPatch);
73 70
 	}
@@ -83,8 +80,7 @@  discard block
 block discarded – undo
83 80
 	 *
84 81
 	 * @return mixed
85 82
 	 */
86
-	public function createAddressBook($principalUri, $url, array $properties)
87
-	{
83
+	public function createAddressBook($principalUri, $url, array $properties) {
88 84
 		$this->logger->trace("principalUri: %s - url: %s - properties: %s", $principalUri, $url, $properties);
89 85
 		// TODO Add displayname
90 86
 		return $this->gDavBackend->CreateFolder($principalUri, $url, static::CONTAINER_CLASS, "");
@@ -95,8 +91,7 @@  discard block
 block discarded – undo
95 91
 	 *
96 92
 	 * @param mixed $addressBookId
97 93
 	 */
98
-	public function deleteAddressBook($addressBookId)
99
-	{
94
+	public function deleteAddressBook($addressBookId) {
100 95
 		$this->logger->trace("addressBookId: %s", $addressBookId);
101 96
 		$success = $this->gDavBackend->DeleteFolder($addressBookId);
102 97
 		// TODO evaluate $success
@@ -122,8 +117,7 @@  discard block
 block discarded – undo
122 117
 	 *
123 118
 	 * @return array
124 119
 	 */
125
-	public function getCards($addressbookId)
126
-	{
120
+	public function getCards($addressbookId) {
127 121
 		$result = $this->gDavBackend->GetObjects($addressbookId, static::FILE_EXTENSION);
128 122
 		$this->logger->trace("addressbookId: %s found %d objects", $addressbookId, count($result));
129 123
 
@@ -144,8 +138,7 @@  discard block
 block discarded – undo
144 138
 	 *
145 139
 	 * @return array
146 140
 	 */
147
-	public function getCard($addressBookId, $cardUri, $mapifolder = null)
148
-	{
141
+	public function getCard($addressBookId, $cardUri, $mapifolder = null) {
149 142
 		$this->logger->trace("addressBookId: %s - cardUri: %s", $addressBookId, $cardUri);
150 143
 
151 144
 		if (!$mapifolder) {
@@ -208,8 +201,7 @@  discard block
 block discarded – undo
208 201
 	 *
209 202
 	 * @return null|string
210 203
 	 */
211
-	public function createCard($addressBookId, $cardUri, $cardData)
212
-	{
204
+	public function createCard($addressBookId, $cardUri, $cardData) {
213 205
 		$this->logger->trace("addressBookId: %s - cardUri: %s - cardData: %s", $addressBookId, $cardUri, $cardData);
214 206
 		$objectId = $this->gDavBackend->GetObjectIdFromObjectUri($cardUri, static::FILE_EXTENSION);
215 207
 		$folder = $this->gDavBackend->GetMapiFolder($addressBookId);
@@ -248,8 +240,7 @@  discard block
 block discarded – undo
248 240
 	 *
249 241
 	 * @return null|string
250 242
 	 */
251
-	public function updateCard($addressBookId, $cardUri, $cardData)
252
-	{
243
+	public function updateCard($addressBookId, $cardUri, $cardData) {
253 244
 		$this->logger->trace("addressBookId: %s - cardUri: %s - cardData: %s", $addressBookId, $cardUri, $cardData);
254 245
 
255 246
 		$mapimessage = $this->gDavBackend->GetMapiMessageForId($addressBookId, $cardUri, null, static::FILE_EXTENSION);
@@ -270,8 +261,7 @@  discard block
 block discarded – undo
270 261
 	 *
271 262
 	 * @return null|string
272 263
 	 */
273
-	private function setData($addressBookId, $mapimessage, $vcf)
274
-	{
264
+	private function setData($addressBookId, $mapimessage, $vcf) {
275 265
 		$this->logger->trace("mapimessage: %s - vcf: %s", $mapimessage, $vcf);
276 266
 		$store = $this->gDavBackend->GetStoreById($addressBookId);
277 267
 		$session = $this->gDavBackend->GetSession();
@@ -296,8 +286,7 @@  discard block
 block discarded – undo
296 286
 	 *
297 287
 	 * @return bool
298 288
 	 */
299
-	public function deleteCard($addressBookId, $cardUri)
300
-	{
289
+	public function deleteCard($addressBookId, $cardUri) {
301 290
 		$this->logger->trace("addressBookId: %s - cardUri: %s", $addressBookId, $cardUri);
302 291
 		$mapifolder = $this->gDavBackend->GetMapiFolder($addressBookId);
303 292
 		$objectId = $this->gDavBackend->GetObjectIdFromObjectUri($cardUri, static::FILE_EXTENSION);
@@ -366,8 +355,7 @@  discard block
 block discarded – undo
366 355
 	 *
367 356
 	 * @return array
368 357
 	 */
369
-	public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null)
370
-	{
358
+	public function getChangesForAddressBook($addressBookId, $syncToken, $syncLevel, $limit = null) {
371 359
 		$this->logger->trace("addressBookId: %s - syncToken: %s - syncLevel: %d - limit: %d", $addressBookId, $syncToken, $syncLevel, $limit);
372 360
 
373 361
 		return $this->gDavBackend->Sync($addressBookId, $syncToken, static::FILE_EXTENSION, $limit);
Please login to merge, or discard this patch.
tests/grommunio-dav/GrommunioCardDavBackendTest.php 1 patch
Braces   +3 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,8 +25,7 @@  discard block
 block discarded – undo
25 25
 	 *
26 26
 	 * @see PHPUnit_Framework_TestCase::setUp()
27 27
 	 */
28
-	protected function setUp()
29
-	{
28
+	protected function setUp() {
30 29
 		$gloggerMock = $this->getMockBuilder(GLogger::class)->disableOriginalConstructor()->getMock();
31 30
 		$this->gDavBackendMock = $this->getMockBuilder(GrommunioDavBackend::class)->disableOriginalConstructor()->getMock();
32 31
 		$this->kCardDavBackend = new GrommunioCardDavBackend($this->gDavBackendMock, $gloggerMock);
@@ -37,8 +36,7 @@  discard block
 block discarded – undo
37 36
 	 *
38 37
 	 * @see PHPUnit_Framework_TestCase::tearDown()
39 38
 	 */
40
-	protected function tearDown()
41
-	{
39
+	protected function tearDown() {
42 40
 		$this->kCardDavBackend = null;
43 41
 		$this->gDavBackendMock = null;
44 42
 	}
@@ -46,8 +44,7 @@  discard block
 block discarded – undo
46 44
 	/**
47 45
 	 * Tests if the constructor is created without errors.
48 46
 	 */
49
-	public function testConstruct()
50
-	{
47
+	public function testConstruct() {
51 48
 		$this->assertTrue(is_object($this->kCardDavBackend));
52 49
 	}
53 50
 }
Please login to merge, or discard this patch.
tests/grommunio-dav/GrommunioDavBackendTest.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -69,10 +69,10 @@
 block discarded – undo
69 69
 	public function ObjectUriProvider()
70 70
 	{
71 71
 		return [
72
-			['1234.ics', '.ics', '1234'],               // ok, cut .ics
73
-			['5678AF.vcf', '.vcf', '5678AF'],           // ok, cut .vcf
74
-			['123400.vcf', '.ics', '123400.vcf'],       // different extension, return as is
75
-			['1234.ics', '.vcf', '1234.ics'],            // different extension, return as is
72
+			['1234.ics', '.ics', '1234'], // ok, cut .ics
73
+			['5678AF.vcf', '.vcf', '5678AF'], // ok, cut .vcf
74
+			['123400.vcf', '.ics', '123400.vcf'], // different extension, return as is
75
+			['1234.ics', '.vcf', '1234.ics'], // different extension, return as is
76 76
 		];
77 77
 	}
78 78
 }
Please login to merge, or discard this patch.
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@  discard block
 block discarded – undo
23 23
 	 *
24 24
 	 * @see PHPUnit_Framework_TestCase::setUp()
25 25
 	 */
26
-	protected function setUp()
27
-	{
26
+	protected function setUp() {
28 27
 		$gloggerMock = $this->getMockBuilder(GLogger::class)->disableOriginalConstructor()->getMock();
29 28
 		$this->gDavBackend = new GrommunioDavBackend($gloggerMock);
30 29
 	}
@@ -34,16 +33,14 @@  discard block
 block discarded – undo
34 33
 	 *
35 34
 	 * @see PHPUnit_Framework_TestCase::tearDown()
36 35
 	 */
37
-	protected function tearDown()
38
-	{
36
+	protected function tearDown() {
39 37
 		$this->gDavBackend = null;
40 38
 	}
41 39
 
42 40
 	/**
43 41
 	 * Tests if the constructor is created without errors.
44 42
 	 */
45
-	public function testConstruct()
46
-	{
43
+	public function testConstruct() {
47 44
 		$this->assertTrue(is_object($this->gDavBackend));
48 45
 	}
49 46
 
@@ -56,8 +53,7 @@  discard block
 block discarded – undo
56 53
 	 *
57 54
 	 * @dataProvider ObjectUriProvider
58 55
 	 */
59
-	public function testGetObjectIdFromObjectUri($objectUri, $extension, $expected)
60
-	{
56
+	public function testGetObjectIdFromObjectUri($objectUri, $extension, $expected) {
61 57
 		$this->assertEquals($expected, $this->gDavBackend->GetObjectIdFromObjectUri($objectUri, $extension));
62 58
 	}
63 59
 
@@ -66,8 +62,7 @@  discard block
 block discarded – undo
66 62
 	 *
67 63
 	 * @return array
68 64
 	 */
69
-	public function ObjectUriProvider()
70
-	{
65
+	public function ObjectUriProvider() {
71 66
 		return [
72 67
 			['1234.ics', '.ics', '1234'],               // ok, cut .ics
73 68
 			['5678AF.vcf', '.vcf', '5678AF'],           // ok, cut .vcf
Please login to merge, or discard this patch.