TradingCardController - Code Metrics - Inspection of "Merge pull request #430 from gregorybesson/develop" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 7edcbc...28e817 )

by greg
created 2019-05-19 19:53 UTC
TradingCardController A

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	274
Duplicated Lines	66.06 %
Coupling/Cohesion

Components	1
Dependencies	10
Importance

Changes
Metric	Value
wmc	25
lcom	1
cbo	10
dl	181
loc	274
rs	10
c	0
b	0
f	0
9 Methods

Rating	Name	Duplication	Size	Complexity
A	createTradingcardAction()	44	44	4
A	editTradingcardAction()	0	9	1
A	listModelAction()	21	21	1
B	cooAction()	0	51	7
A	removeModelAction()	21	21	3
A	getAdminGameService()	0	8	2
A	setAdminGameService()	0	6	1
A	addModelAction()	50	50	3
A	editModelAction()	45	45	3
How to fix Duplicated Code

<?php

namespace PlaygroundGame\Controller\Admin;

use DoctrineORMModule\Paginator\Adapter\DoctrinePaginator as DoctrineAdapter;
use PlaygroundCore\ORM\Pagination\LargeTablePaginator;
use PlaygroundGame\Controller\Admin\GameController;
use PlaygroundGame\Entity\TradingCard;
use PlaygroundGame\Entity\TradingCardModel;
use PlaygroundGame\Service\Game as AdminGameService;
use Zend\Paginator\Paginator;
use Zend\View\Model\ViewModel;

class TradingCardController extends GameController
{
    /**
     * @var \PlaygroundGame\Service\Game
     */
    protected $adminGameService;

    public function createTradingcardAction()

    {
        $service   = $this->getAdminGameService();
        $viewModel = new ViewModel();
        $viewModel->setTemplate('playground-game/trading-card/tradingcard');

        $gameForm = new ViewModel();
        $gameForm->setTemplate('playground-game/game/game-form');

        $tradingcard = new TradingCard();

        $form = $this->getServiceLocator()->get('playgroundgame_tradingcard_form');
        $form->bind($tradingcard);
        $form->get('submit')->setAttribute('label', 'Add');
        $form->setAttribute(
            'action',
            $this->adminUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                'playgroundgame/create-tradingcard',
                array('gameId' => 0)
            )
        );
        $form->setAttribute('method', 'post');

        $request = $this->getRequest();
        if ($request->isPost()) {
            $data = array_replace_recursive(
                $this->getRequest()->getPost()->toArray(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $this->getRequest()->getFiles()->toArray()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );
            if (empty($data['prizes'])) {
                $data['prizes'] = array();
            }
            $game = $service->createOrUpdate($data, $tradingcard, 'playgroundgame_tradingcard_form');
            if ($game) {
                $this->flashMessenger()->setNamespace('playgroundgame')->addMessage('The game has been created');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

                return $this->redirect()->toUrl($this->adminUrl()->fromRoute('playgroundgame/list'));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            }
        }
        $gameForm->setVariables(array('form' => $form, 'game' => $tradingcard));
        $viewModel->addChild($gameForm, 'game_form');

        return $viewModel->setVariables(array('form' => $form, 'title' => 'Create trading card'));
    }

    public function editTradingcardAction()
    {
        $this->checkGame();

        return $this->editGame(
            'playground-game/trading-card/tradingcard',
            'playgroundgame_tradingcard_form'
        );
    }

    public function listModelAction()

    {
        $this->checkGame();

        $adapter = new DoctrineAdapter(
            new LargeTablePaginator(
                $this->getAdminGameService()->getTradingCardModelMapper()->queryByGame($this->game)
            )
        );
        $paginator = new Paginator($adapter);
        $paginator->setItemCountPerPage(25);
        $paginator->setCurrentPageNumber($this->getEvent()->getRouteMatch()->getParam('p'));

        return new ViewModel(
            array(
                'models' => $paginator,
                'gameId' => $this->game->getId(),
                'game'   => $this->game,
            )
        );
    }

    public function addModelAction()

    {
        $this->checkGame();

        $viewModel = new ViewModel();
        $viewModel->setTemplate('playground-game/trading-card/model');

        $form = $this->getServiceLocator()->get('playgroundgame_tradingcardmodel_form');
        $form->get('submit')->setAttribute('label', 'Add');

        // $form->get('availability')->setOptions(array(
        //     'format' => 'Y-m-d H:i:s'
        // ));

        $form->setAttribute(
            'action',
            $this->adminUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                'playgroundgame/tradingcard-model-add',
                array('gameId' => $this->game->getId())
            )
        );
        $form->setAttribute('method', 'post');
        $form->get('trading_card_id')->setAttribute('value', $this->game->getId());
        $model = new TradingCardModel();
        $form->bind($model);

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $data = array_merge(
                $this->getRequest()->getPost()->toArray(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $this->getRequest()->getFiles()->toArray()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );

            $model = $this->getAdminGameService()->updateModel($data, $model);
            if ($model) {
                // Redirect to list of games
                $this->flashMessenger()->setNamespace('playgroundgame')->addMessage('The model has been created');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->redirect()->toUrl(
                    $this->adminUrl()->fromRoute('playgroundgame/tradingcard-model-list', array('gameId' => $this->game->getId()))
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                );
            }
        }
        return $viewModel->setVariables(
            array(
                'form'     => $form,
                'game'     => $this->game,
                'model_id' => 0,
                'title'    => 'Add model',
            )
        );
    }

    public function editModelAction()

    {
        $this->checkGame();

        $viewModel = new ViewModel();
        $viewModel->setTemplate('playground-game/trading-card/model');
        $service = $this->getAdminGameService();

        $modelId = $this->getEvent()->getRouteMatch()->getParam('modelId');
        $model   = $service->getTradingCardModelMapper()->findById($modelId);

        $form = $this->getServiceLocator()->get('playgroundgame_tradingcardmodel_form');
        $form->remove('models_file');

        $form->get('submit')->setAttribute('label', 'Edit');
        $form->setAttribute('action', '');

        $form->get('trading_card_id')->setAttribute('value', $this->game->getId());

        $form->bind($model);

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $data = array_merge(
                $this->getRequest()->getPost()->toArray(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $this->getRequest()->getFiles()->toArray()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );
            $model = $service->updateModel($data, $model);

            if ($model) {
                // Redirect to list of games
                $this->flashMessenger()->setNamespace('playgroundgame')->addMessage('The model has been edited');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                return $this->redirect()->toUrl(
                    $this->adminUrl()->fromRoute('playgroundgame/tradingcard-model-list', array('gameId' => $this->game->getId()))
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                );
            }
        }
        return $viewModel->setVariables(
            array(
                'form'     => $form,
                'game'     => $this->game,
                'model_id' => $modelId,
                'title'    => 'Edit model',
            )
        );
    }

    /**
     * This function helps the admin to position UGC image on a card model
     */
    public function cooAction()
    {
        // get models
        $sg = $this->getAdminGameService();
        $this->checkGame();

        $models = $sg->getTradingCardModelMapper()->findBy(array('game' => $this->game));

        if ($this->getRequest()->isXmlHttpRequest() && $this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $position = json_decode($this->getRequest()->getPost()->get('position'));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $i        = 0;
            foreach ($models as $model) {
                $jsonData = json_decode($model->getJsonData());
                if (isset($jsonData->coo)) {
                    $jsonData->coo = $position[$i];
                } else {
                    $jsonData = array('coo' => $position[$i]);
                }

                $model->setJsonData(json_encode($jsonData));
                $models = $sg->getTradingCardModelMapper()->update($model);
                ++$i;
            }

            // update coo of Model
            $jsonModel = new \Zend\View\Model\JsonModel();
            $jsonModel->setVariables(
                array(
                    'success' => true,
                )
            );

            return $jsonModel;
        }

        // ajout des images au tableau
        $bgs = [];
        $coo = [];
        foreach ($models as $model) {
            $json     = json_decode($model->getJsonData());
            $modelCoo = (isset($json->coo))?$json->coo:'';
            $bgs[]    = '/'.$model->getImage();
            $coo[]    = $modelCoo;
        }

        return array(
            'backgrounds' => $bgs,
            'face'        => 'img-test/photo.png',
            'coo'         => $coo,
        );
    }

    public function removeModelAction()

    {
        $service = $this->getAdminGameService();
        $modelId = $this->getEvent()->getRouteMatch()->getParam('modelId');
        if (!$modelId) {
            return $this->redirect()->toUrl($this->adminUrl()->fromRoute('playgroundgame/list'));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        $model         = $service->getTradingCardModelMapper()->findById($modelId);
        $tradingcardId = $model->getTradingCard()->getId();

        if ($model->getActive()) {
            $service->getTradingCardModelMapper()->remove($model);
            $this->flashMessenger()->setNamespace('playgroundgame')->addMessage('The model has been deleted');
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        } else {
            $this->flashMessenger()->setNamespace('playgroundgame')->addMessage(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                'cards have already been created with this model'
            );
        }

        return $this->redirect()->toUrl($this->adminUrl()->fromRoute('playgroundgame/tradingcard-model-list', array('gameId' => $tradingcardId)));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    public function getAdminGameService()
    {
        if (!$this->adminGameService) {
            $this->adminGameService = $this->getServiceLocator()->get('playgroundgame_tradingcard_service');
        }

        return $this->adminGameService;
    }

    public function setAdminGameService(AdminGameService $adminGameService)
    {
        $this->adminGameService = $adminGameService;

        return $this;
    }
}

Push — master ( 7edcbc...28e817 )

TradingCardController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

gregorybesson / PlaygroundGame

Push — master ( 7edcbc...28e817 )

TradingCardController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
