WebhookController - Code Metrics - Inspection of "Merge pull request #378 from gregorybesson/develop" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 167f27...515cc1 )

by greg

created 2018-09-30 08:11 UTC

WebhookController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	43.3 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

Metric	Value
wmc	10
lcom	2
cbo	2
dl	42
loc	97
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getServiceLocator()	0	4	1
A	indexAction()	14	14	1
A	facebookAction()	14	14	1
A	instagramAction()	14	14	1
A	getGameService()	0	8	2
A	getPrizeCategoryService()	0	8	2
A	setPrizeCategoryService()	0	6	1

How to fix Duplicated Code

<?php

namespace PlaygroundGame\Controller\Frontend;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\ServiceManager\ServiceLocatorInterface;

class WebhookController extends AbstractActionController
{
    protected $gameService;

    protected $prizeCategoryService;

    /**
     *
     * @var ServiceManager
     */
    protected $serviceLocator;

    public function __construct(ServiceLocatorInterface $locator)
    {
        $this->serviceLocator = $locator;

    }

    public function getServiceLocator()
    {
        return $this->serviceLocator;
    }

    public function indexAction()

    {

        $mode = $this->params()->fromQuery('hub_mode');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $challenge = $this->params()->fromQuery('hub_challenge');
        $token = $this->params()->fromQuery('hub_verify_token');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $response = $this->getResponse();
        $response->setContent($challenge);

        file_get_contents('php://input');

        return $response;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * FB hooks : hub.mode=subscribe&
     * hub.challenge=1158201444&
     * hub.verify_token=meatyhamhock
     */
    public function facebookAction()

    {

        $mode = $this->params()->fromQuery('hub_mode');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $challenge = $this->params()->fromQuery('hub_challenge');
        $token = $this->params()->fromQuery('hub_verify_token');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $response = $this->getResponse();
        $response->setContent($challenge);

        file_get_contents('php://input');

        return $response;
    }

    public function instagramAction()

    {

        $mode = $this->params()->fromQuery('hub_mode');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $challenge = $this->params()->fromQuery('hub_challenge');
        $token = $this->params()->fromQuery('hub_verify_token');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $response = $this->getResponse();
        $response->setContent($challenge);

        file_get_contents('php://input');

        return $response;
    }

    public function getGameService()
    {
        if (!$this->gameService) {
            $this->gameService = $this->getServiceLocator()->get('playgroundgame_game_service');
        }

        return $this->gameService;
    }

    public function getPrizeCategoryService()
    {
        if (!$this->prizeCategoryService) {
            $this->prizeCategoryService = $this->getServiceLocator()->get('playgroundgame_prizecategory_service');
        }

        return $this->prizeCategoryService;
    }

    public function setPrizeCategoryService(\PlaygroundGame\Service\PrizeCategory $prizeCategoryService)
    {
        $this->prizeCategoryService = $prizeCategoryService;

        return $this;
    }
}


1		<?php
2
3		namespace PlaygroundGame\Controller\Frontend;
4
5		use Zend\Mvc\Controller\AbstractActionController;
6		use Zend\View\Model\ViewModel;
7		use Zend\ServiceManager\ServiceLocatorInterface;
8
9		class WebhookController extends AbstractActionController
10		{
11		protected $gameService;
12
13		protected $prizeCategoryService;
14
15		/**
16		*
17		* @var ServiceManager
18		*/
19		protected $serviceLocator;
20
21		public function __construct(ServiceLocatorInterface $locator)
22		{
23		$this->serviceLocator = $locator;
		0 ignored issues – show Documentation Bug introduced 2018-09-29 23:35 UTC by Report Bug Copy Issue Report It seems like `$locator` of type `object<Zend\ServiceManag...erviceLocatorInterface>` is incompatible with the declared type `object<PlaygroundGame\Co...rontend\ServiceManager>` of property `$serviceLocator`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24		}
25
26		public function getServiceLocator()
27		{
28		return $this->serviceLocator;
29		}
30
31	View Code Duplication	public function indexAction()
		0 ignored issues – show Duplication introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33
34		$mode = $this->params()->fromQuery('hub_mode');
		0 ignored issues – show Unused Code introduced 2018-09-29 23:35 UTC by Report Bug Copy Issue Report `$mode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35		$challenge = $this->params()->fromQuery('hub_challenge');
36		$token = $this->params()->fromQuery('hub_verify_token');
		0 ignored issues – show Unused Code introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report `$token` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37
38		$response = $this->getResponse();
39		$response->setContent($challenge);
40
41		file_get_contents('php://input');
42
43		return $response;
		0 ignored issues – show Bug Best Practice introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report The return type of `return $response;` (`Zend\Stdlib\ResponseInterface`) is incompatible with the return type of the parent method `Zend\Mvc\Controller\Abst...Controller::indexAction` of type `Zend\View\Model\ViewModel`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
44		}
45
46		/**
47		* FB hooks : hub.mode=subscribe&
48		* hub.challenge=1158201444&
49		* hub.verify_token=meatyhamhock
50		*/
51	View Code Duplication	public function facebookAction()
		0 ignored issues – show Duplication introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		{
53
54		$mode = $this->params()->fromQuery('hub_mode');
		0 ignored issues – show Unused Code introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report `$mode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
55		$challenge = $this->params()->fromQuery('hub_challenge');
56		$token = $this->params()->fromQuery('hub_verify_token');
		0 ignored issues – show Unused Code introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report `$token` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
57
58		$response = $this->getResponse();
59		$response->setContent($challenge);
60
61		file_get_contents('php://input');
62
63		return $response;
64		}
65
66	View Code Duplication	public function instagramAction()
		0 ignored issues – show Duplication introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		{
68
69		$mode = $this->params()->fromQuery('hub_mode');
		0 ignored issues – show Unused Code introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report `$mode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70		$challenge = $this->params()->fromQuery('hub_challenge');
71		$token = $this->params()->fromQuery('hub_verify_token');
		0 ignored issues – show Unused Code introduced 2018-09-30 08:13 UTC by Report Bug Copy Issue Report `$token` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
72
73		$response = $this->getResponse();
74		$response->setContent($challenge);
75
76		file_get_contents('php://input');
77
78		return $response;
79		}
80
81		public function getGameService()
82		{
83		if (!$this->gameService) {
84		$this->gameService = $this->getServiceLocator()->get('playgroundgame_game_service');
85		}
86
87		return $this->gameService;
88		}
89
90		public function getPrizeCategoryService()
91		{
92		if (!$this->prizeCategoryService) {
93		$this->prizeCategoryService = $this->getServiceLocator()->get('playgroundgame_prizecategory_service');
94		}
95
96		return $this->prizeCategoryService;
97		}
98
99		public function setPrizeCategoryService(\PlaygroundGame\Service\PrizeCategory $prizeCategoryService)
100		{
101		$this->prizeCategoryService = $prizeCategoryService;
102
103		return $this;
104		}
105		}
106

gregorybesson / PlaygroundGame

Push — master ( 167f27...515cc1 )

WebhookController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like