PostVoteController - Code Metrics - Inspection of "Frontend controllers refactoring" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#264)

by greg
created 2015-12-06 17:47 UTC
PostVoteController D

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	735
Duplicated Lines	7.48 %
Coupling/Cohesion

Components	1
Dependencies	11
Importance

Changes	19
Bugs	3	Features	1
Metric	Value
wmc	74
c	19
b	3
f	1
lcom	1
cbo	11
dl	55
loc	735
rs	4.9231
11 Methods

Rating	Name	Duplication	Size	Complexity
B	ajaxuploadAction()	0	49	5
B	ajaxdeleteAction()	0	34	4
D	listAction()	9	114	9
B	ajaxVoteAction()	0	38	5
B	captchaAction()	0	24	4
A	getGameService()	0	8	2
D	playAction()	0	138	15
B	previewAction()	9	48	6
C	postAction()	8	110	12
B	resultAction()	10	52	6
B	shareAction()	19	74	6
How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class
Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.
Complex classes like PostVoteController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PostVoteController, and based on these observations, apply Extract Interface, too.
<?php

namespace PlaygroundGame\Controller\Frontend;

use Zend\Form\Form;

class PostVoteController extends GameController
{
    /**
     * @var gameService
     */
    protected $gameService;

    /**
     * --DONE-- 1. try to change the Game Id (on le redirige vers la home du jeu)
     * --DONE-- 2. try to modify questions (the form is recreated and verified in the controller)
     * --DONE-- 3. don't answer to questions (form is checked controller side)
     * 4. try to game the chrono
     * 5. try to play again
     * 6. try to change answers
     *  --DONE-- 7. essaie de répondre sans être inscrit (on le redirige vers la home du jeu)
     */
    public function playAction()
    {
        $redirectFb = $this->checkFbRegistration($this->zfcUserAuthentication()->getIdentity(), $this->game);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($redirectFb) {
            return $redirectFb;
        }

        $entry = $this->getGameService()->play($this->game, $user);


        if (!$entry) {
            $lastEntry = $this->getGameService()->findLastInactiveEntry($this->game, $user);
            if ($lastEntry === null) {
                return $this->redirect()->toUrl(
                    $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        'postvote',
                        array(
                            'id' => $this->game->getIdentifier(),
                            
                        )
                    )
                );
            }

            $lastEntryId = $lastEntry->getId();
            $lastPost = $this->getGameService()->getPostVotePostMapper()->findOneBy(array('entry' => $lastEntryId));
            $postId = $lastPost->getId();
            if ($lastPost->getStatus() == 2) {
                // the user has already taken part of this game and the participation limit has been reached
                $this->flashMessenger()->addMessage(
                    $this->getServiceLocator()->get('translator')->translate('You have already a Post')
                );

                return $this->redirect()->toUrl(
                    $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        'postvote/post',
                        array(
                            'id' => $this->game->getIdentifier(),
                            'post' => $postId,
                            
                        )
                    )
                );
            } else {
                $this->flashMessenger()->addMessage(
                    $this->getServiceLocator()->get('translator')->translate('Your Post is waiting for validation')
                );

                return $this->redirect()->toUrl(
                    $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        'postvote/post',
                        array(
                            'id' => $this->game->getIdentifier(),
                            'post' => $postId,
                            
                        )
                    )
                );
            }
        }

        if (! $this->game->getForm()) {
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array(
                        'id' => $this->game->getIdentifier(),
                        
                    )
                )
            );
        }

        $form = $this->getGameService()->createFormFromJson($this->game->getForm()->getForm(), 'postvoteForm');

        // Je recherche le post associé à entry + status == 0. Si non trouvé, je redirige vers home du jeu.
        $post = $this->getGameService()->getPostVotePostMapper()->findOneBy(array('entry' => $entry, 'status' => 0));
        if ($post) {
            foreach ($post->getPostElements() as $element) {
                try {
                    $form->get($element->getName())->setValue($element->getValue());

                    $elementType = $form->get($element->getName())->getAttribute('type');
                    if ($elementType == 'file' && $element->getValue() != '') {
                        $filter = $form->getInputFilter();
                        $elementInput = $filter->get($element->getName());
                        $elementInput->setRequired(false);
                        $form->get($element->getName())->setAttribute('required', false);
                    }
                } catch (\Zend\Form\Exception\InvalidElementException $e) {

                }
            }
        }

        $viewModel = $this->buildView($this->game);

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            // POST Request: Process form
            $data = array_merge_recursive(
                $this->getRequest()->getPost()->toArray(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $this->getRequest()->getFiles()->toArray()
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            );

            $form->setData($data);

            if ($form->isValid()) {
                $data = $form->getData();
                $post = $this->getGameService()->createPost($data, $this->game, $user, $form);

                if ($post && !empty($this->game->nextStep('play'))) {
                    // determine the route where the user should go
                    $redirectUrl = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        'postvote/'.$this->game->nextStep('play'),
                        array(
                            'id' => $this->game->getIdentifier(),
                            
                        )
                    );

                    return $this->redirect()->toUrl($redirectUrl);
                }
            } else {
                $messages = $form->getMessages();
                $viewModel = $this->buildView($this->game);
                $viewModel->setVariables(array(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                    'success' => false,
                    'message' => implode(',', $messages['title']),
                ));
            }
        }

        $viewModel->setVariables(array(
                'playerData' => $entry->getPlayerData(),
                'form' => $form,
                'post' => $post,
            ));

        return $viewModel;
    }

    public function previewAction()
    {
        $user = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $entry = $this->getGameService()->findLastActiveEntry($this->game, $user);
         
        if (!$entry) {

            // the user has already taken part of this game and the participation limit has been reached
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote/'.$this->game->nextStep('preview'),
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        // Je recherche le post associé à entry + status == 0. Si non trouvé, je redirige vers home du jeu.
        $post = $this->getGameService()->getPostVotePostMapper()->findOneBy(array('entry' => $entry, 'status' => 0));

        if (! $post) {
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $post = $this->getGameService()->confirmPost($this->game, $user);

            if ($post) {
                if (!($step = $this->game->nextStep('play'))) {
                    $step = 'result';
                }
                $redirectUrl = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote/'.$step,
                    array('id' => $this->game->getIdentifier())
                );

                return $this->redirect()->toUrl($redirectUrl);
            }
        }

        $viewModel = $this->buildView($this->game);
        $viewModel->setVariables(array('post' => $post));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $viewModel;
    }

    /**
     * View the Post page
     * @return multitype:|\Zend\Http\Response|\Zend\View\Model\ViewModel

     */
    public function postAction()
    {
        $postId = $this->getEvent()->getRouteMatch()->getParam('post');
        $user = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $voted = false;
        $statusMail = false;
        $mailService = $this->getServiceLocator()->get('playgroundgame_message');
        $to = '';
        $skinUrl = $this->getGameService()->getServiceManager()->get('ViewRenderer')->url(
            'frontend',
            array(),
            array('force_canonical' => true)
        );
        $config = $this->getGameService()->getServiceManager()->get('config');
        if (isset($config['moderation']['email'])) {
            $to = $config['moderation']['email'];
        }

        if (! $postId) {
            return $this->notFoundAction();
        }

        // Je recherche le post associé à entry + status == 0. Si non trouvé, je redirige vers home du jeu.
        $post = $this->getGameService()->getPostVotePostMapper()->findById($postId);

        if (! $post || $post->getStatus() === 9) {

            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        $formModeration = new Form();
        $formModeration->setAttribute('method', 'post');

        $formModeration->add(array(
            'name' => 'moderation',
            'attributes' => array(
                'type' => 'hidden',
                'value' => '1'
            ),
        ));

        $form = new \PlaygroundGame\Form\Frontend\PostVoteVote(
            $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                'postvote/post/captcha',
                array(
                    'id' => $this->game->getIdentifier(),
                    'post' => $postId,
                )
            )
        );

        if ($user) {
            $form->remove('captcha');
        }

        $alreadyVoted = '';
        $reportId = '';

        $request = $this->getRequest();
        if ($request->isPost()) {
            $data = $request->getPost()->toArray();
            if (isset($data['moderation'])) {
                $formModeration->setData($data);
                if ($formModeration->isValid()) {
                    $from = $to;
                    $subject= 'Moderation Post and Vote';
                    $result = $mailService->createHtmlMessage(
                        $from,
                        $to,
                        $subject,
                        'playground-game/email/moderation',
                        array('data' => $data, 'skinUrl' => $skinUrl)
                    );
                    $mailService->send($result);
                    if ($result) {
                        $statusMail = true;
                        $reportId = $data['reportid'];
                    }
                }
            } else {
                $form->setData($request->getPost());
                if ($form->isValid()) {
                    if ($this->getGameService()->addVote($user, $this->getRequest()->getServer('REMOTE_ADDR'), $post)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                        $voted = true;
                    } else {
                        $alreadyVoted = 'Vous avez déjà voté!';
                    }
                }
            }
        }

        $viewModel = $this->buildView($this->game);
        $viewModel->setVariables(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            array(
                'post'  => $post,
                'voted' => $voted,
                'form'  => $form,
                'formModeration' => $formModeration,
                'statusMail' => $statusMail,
                'alreadyVoted' => $alreadyVoted,
                'reportId' => $reportId,
            )
        );

        return $viewModel;
    }

    /**
     *
     */
    public function resultAction()
    {
        $statusMail = null;

        // Has the user finished the game ?
        $lastEntry = $this->getGameService()->findLastInactiveEntry($this->game, $user);


        if ($lastEntry === null) {
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        $form = $this->getServiceLocator()->get('playgroundgame_sharemail_form');
        $form->setAttribute('method', 'post');

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $data = $this->getRequest()->getPost()->toArray();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $form->setData($data);
            if ($form->isValid()) {
                $result = $this->getGameService()->sendShareMail($data, $this->game, $user, $lastEntry);
                if ($result) {
                    $statusMail = true;
                }
            }
        }

        // Je recherche le post associé à entry + status == 0. Si non trouvé, je redirige vers home du jeu.
        $post = $this->getGameService()->getPostVotePostMapper()->findOneBy(array('entry' => $lastEntry));

        if (! $post) {
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        $viewModel = $this->buildView($this->game);

        $viewModel->setVariables(array(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'statusMail' => $statusMail,
                'post' => $post,
                'form' => $form,
            ));

        return $viewModel;
    }

    /**
     * Example of AJAX File Upload with Session Progress and partial validation.
     * It's now possible to send a base64 image in this case the call is the form :
     * this._ajax(
     * {
     *   url: url.dataset.url,
     *    method: 'post',
     *    body: 'photo=' + image
     * },
     *
     * @return \Zend\Stdlib\ResponseInterface
     */
    public function ajaxuploadAction()
    {
        // Call this for the session lock to be released (other ajax calls can then be made)
        session_write_close();

        if (! $this->game) {
            $this->getResponse()->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));

            return $this->getResponse();
        }

        $entry = $this->getGameService()->findLastActiveEntry(
            $this->game,
            $this->zfcUserAuthentication()->getIdentity()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );
        if (!$entry) {
            // the user has already taken part of this game and the participation limit has been reached
            $this->getResponse()->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));

            return $this->getResponse();
        }

        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $data = $this->getRequest()->getFiles()->toArray();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            if (empty($data)) {
                $data = $this->getRequest()->getPost()->toArray();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $key = key($data);
                $uploadImage = array('name' => $key.'.png', 'error' => 0, 'base64' => $data[$key]);
                $data = array($key => $uploadImage);
            }
            $uploadFile = $this->getGameService()->uploadFileToPost(
                $data,
                $this->game,
                $this->zfcUserAuthentication()->getIdentity()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            );
        }

        $this->getResponse()->setContent(\Zend\Json\Json::encode(array(
            'success' => true,
            'fileUrl' => $uploadFile
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        )));

        return $this->getResponse();
    }

    public function ajaxdeleteAction()
    {
        $user = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $response = $this->getResponse();

        if (! $this->game) {
            $response->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));

            return $response;
        }

        $entry = $this->getGameService()->findLastActiveEntry($this->game, $user);
        if (!$entry) {
            // the user has already taken part of this game and the participation limit has been reached
            $response->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));

            return $response;
        }

        if ($request->isPost()) {
            $data = $request->getPost()->toArray();

            $this->getGameService()->deleteFilePosted($data, $this->game, $user);
        }

        $response->setContent(\Zend\Json\Json::encode(array(
            'success' => true,
        )));

        return $response;
    }

    public function listAction()
    {
        $filter = $this->getEvent()->getRouteMatch()->getParam('filter');
        $search = $this->params()->fromQuery('name');
        $postId = $this->params()->fromQuery('id');
        $statusMail = false;
        $mailService = $this->getServiceLocator()->get('playgroundgame_message');
        $to = '';
        $skinUrl = $this->getGameService()->getServiceManager()->get('ViewRenderer')->url(
            'frontend',
            array(),
            array('force_canonical' => true)
        );
        $config = $this->getGameService()->getServiceManager()->get('config');
        if (isset($config['moderation']['email'])) {
            $to = $config['moderation']['email'];
        }

        $request = $this->getRequest();

        // Je recherche les posts validés associés à ce jeu
        $posts = $this->getGameService()->findArrayOfValidatedPosts($this->game, $filter, $search);

        if (is_array($posts)) {
            $paginator = new \Zend\Paginator\Paginator(new \Zend\Paginator\Adapter\ArrayAdapter($posts));
            $paginator->setItemCountPerPage($game->getPostDisplayNumber());

            $paginator->setCurrentPageNumber($this->getEvent()->getRouteMatch()->getParam('p'));
        } else {
            $paginator = $posts;
        }

        $form = new Form();
        $form->setAttribute('method', 'post');

        $form->add(array(
            'name' => 'moderation',
            'attributes' => array(
                'type' => 'hidden',
                'value' => '1'
            ),
        ));

        $reportId ='';

        if ($request->isPost()) {
            $data = $request->getPost()->toArray();

            if (isset($data['moderation'])) {
                $from = $to;
                $subject= 'Moderation Post and Vote';
                $result = $mailService->createHtmlMessage(
                    $from,
                    $to,
                    $subject,
                    'playground-game/email/moderation',
                    array('data' => $data, 'skinUrl' => $skinUrl)
                );
                $mailService->send($result);
                if ($result) {
                    $statusMail = true;
                    $reportId = $data['reportid'];
                }
            }
        }

        $viewModel = $this->buildView($this->game);
        
        if ($postId) {
            $postTarget = $this->getGameService()->getPostVotePostMapper()->findById($postId);
            if ($postTarget) {
                foreach ($postTarget->getPostElements() as $element) {

                    $fbShareImage = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        '',
                        array(),
                        array('force_canonical' => true),
                        false
                    ) . $element->getValue();
                    break;
                }
                
                $secretKey = strtoupper(substr(sha1(uniqid('pg_', true).'####'.time()), 0, 15));
                
                // Without bit.ly shortener
                $socialLinkUrl = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote/list',
                    array(
                        'id' => $this->game->getIdentifier(),
                        'filter' => 'date'),
                    array('force_canonical' => true)
                ).'?id='.$postTarget->getId().'&key='.$secretKey;
                // With core shortener helper
                $socialLinkUrl = $this->shortenUrl()->shortenUrl($socialLinkUrl);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                
                $this->getViewHelper('HeadMeta')->setProperty('og:image', $fbShareImage);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $this->getViewHelper('HeadMeta')->setProperty('twitter:card', "photo");
                $this->getViewHelper('HeadMeta')->setProperty('twitter:site', "@alfie_selfie");
                $this->getViewHelper('HeadMeta')->setProperty('twitter:title', $this->game->getTwShareMessage());
                $this->getViewHelper('HeadMeta')->setProperty('twitter:description', "");
                $this->getViewHelper('HeadMeta')->setProperty('twitter:image', $fbShareImage);
                $this->getViewHelper('HeadMeta')->setProperty('twitter:url', $socialLinkUrl);
            }
        }
        
        $viewModel->setVariables(array(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                'posts' => $paginator,
                'form' => $form,
                'statusMail' => $statusMail,
                'reportId' => $reportId,
                'filter' => $filter,
                'search' => $search,
            ));

        return $viewModel;
    }

    public function ajaxVoteAction()
    {
        // Call this for the session lock to be released (other ajax calls can then be made)
        session_write_close();
        $postId     = $this->getEvent()->getRouteMatch()->getParam('post');
        $user        = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $request = $this->getRequest();
        $response = $this->getResponse();

        if (! $this->game) {
            $response->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));

            return $response;
        }

        if (!$this->zfcUserAuthentication()->hasIdentity()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $response->setContent(\Zend\Json\Json::encode(array(
                'success' => 0
            )));
        } else {
            if ($request->isPost()) {
                $post = $this->getGameService()->getPostvotePostMapper()->findById($postId);
                if ($this->getGameService()->addVote($user, $this->getRequest()->getServer('REMOTE_ADDR'), $post)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $response->setContent(\Zend\Json\Json::encode(array(
                        'success' => 1
                    )));
                } else {
                    $response->setContent(\Zend\Json\Json::encode(array(
                        'success' => 0
                    )));
                }
            }
        }

        return $response;
    }

    public function captchaAction()
    {
        $response = $this->getResponse();
        $response->getHeaders()->addHeaderLine('Content-Type', "image/png");

        $id = $this->params('id', false);

        if ($id) {
            $image = './data/captcha/' . $id;

            if (file_exists($image) !== false) {
                $imagegetcontent = file_get_contents($image);

                $response->setStatusCode(200);
                $response->setContent($imagegetcontent);

                if (file_exists($image) === true) {
                    unlink($image);
                }
            }
        }

        return $response;
    }
    
    public function shareAction()
    {
        $statusMail = null;
        $user = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    
        // Has the user finished the game ?
        $lastEntry = $this->getGameService()->findLastInactiveEntry($this->game, $user);
    
        if ($lastEntry === null) {
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'postvote',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }
    
        $post = $this->getGameService()->getPostVotePostMapper()->findOneBy(array('entry' => $lastEntry));
    
        $secretKey = strtoupper(substr(sha1(uniqid('pg_', true).'####'.time()), 0, 15));
        $socialLinkUrl = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'postvote/post',
            array(
                'id' => $this->game->getIdentifier(),
                'post' => $post->getId(),
            ),
            array('force_canonical' => true)
        ).'?key='.$secretKey;
        // With core shortener helper
        $socialLinkUrl = $this->shortenUrl()->shortenUrl($socialLinkUrl);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    
        $form = $this->getServiceLocator()->get('playgroundgame_sharemail_form');
        $form->setAttribute('method', 'post');
    
        if ($this->getRequest()->isPost()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $data = $this->getRequest()->getPost()->toArray();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $form->setData($data);
            if ($form->isValid()) {
                $result = $this->getGameService()->sendShareMail($data, $this->game, $user, $lastEntry);
                if ($result) {
                    $statusMail = true;
                }
            }
        }

        $viewModel = $this->buildView($this->game);
    
        foreach ($post->getPostElements() as $element) {

            $fbShareImage = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                '',
                array(),
                array('force_canonical' => true),
                false
            ) . $element->getValue();
            break;
        }

        $this->getViewHelper('HeadMeta')->setProperty('og:image', $fbShareImage);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        $this->getViewHelper('HeadMeta')->setProperty('twitter:card', "photo");
        $this->getViewHelper('HeadMeta')->setProperty('twitter:site', "@playground");
        $this->getViewHelper('HeadMeta')->setProperty('twitter:title', $this->game->getTwShareMessage());
        $this->getViewHelper('HeadMeta')->setProperty('twitter:description', "");
        $this->getViewHelper('HeadMeta')->setProperty('twitter:image', $fbShareImage);
        $this->getViewHelper('HeadMeta')->setProperty('twitter:url', $socialLinkUrl);
            
        $viewModel->setVariables(array(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'statusMail'       => $statusMail,
            'form'             => $form,
            'socialLinkUrl'    => $socialLinkUrl,
            'post'             => $post
        ));
    
        return $viewModel;
    }

    public function getGameService()
    {
        if (!$this->gameService) {
            $this->gameService = $this->getServiceLocator()->get('playgroundgame_postvote_service');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        return $this->gameService;
    }
}

Pull Request — master (#264)

PostVoteController D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

gregorybesson / PlaygroundGame

Pull Request — master (#264)

PostVoteController D

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
