Entry::getTermsOptin() - Code Metrics - Inspection of "Merge pull request #418 from gregorybesson/develop" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 64789b...259751 )

by greg

created 2019-04-23 14:59 UTC

Entry::getTermsOptin() A

↳ Parent: Entry

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
namespace PlaygroundGame\Entity;

use Doctrine\ORM\Mapping as ORM;
use Doctrine\ORM\Mapping\HasLifecycleCallbacks;
use Doctrine\ORM\Mapping\PrePersist;
use Doctrine\ORM\Mapping\PreUpdate;

/**
 * An entry represent a game session.
 * @ORM\Entity @HasLifecycleCallbacks
 * @ORM\Table(name="game_entry")
 */
class Entry implements \JsonSerializable
{
    /**
     * @ORM\Id
     * @ORM\Column(type="integer");
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    protected $id;

    /**
     * @ORM\ManyToOne(targetEntity="Game", cascade={"persist","remove"})
     * @ORM\JoinColumn(name="game_id", referencedColumnName="id", onDelete="CASCADE")
     **/
    protected $game;

    /**
     * @ORM\ManyToOne(targetEntity="PlaygroundUser\Entity\User")
     * @ORM\JoinColumn(name="user_id", referencedColumnName="user_id", onDelete="CASCADE")
     **/
    protected $user;

    /**
     * @ORM\Column(type="boolean", nullable=true)
     */
    protected $active = 1;

    /**
     * Has this entry been paid
     * @ORM\Column(type="boolean", nullable=true)
     */
    protected $paid = false;

    /**
     * The amount paid for this entry
     * @ORM\Column(name="paid_amount", type="integer", nullable=true)
     */
    protected $paidAmount = 0;

    /**
     * An entry marked as bonus means that it's not taken into account
     * in the limit calculation. It's offered, for example, when you share the game to a friend.
     *
     * @ORM\Column(type="boolean", nullable=true)
     */
    protected $bonus = 0;

    /**
     * @ORM\Column(type="integer", nullable=true)
     */
    protected $points;
    
    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    protected $ip;

    /**
     * @ORM\Column(type="string", length=255, nullable=true)
     */
    protected $geoloc;
    
    /**
     * @ORM\Column(name="anonymous_id", type="string", length=255, nullable=true)
     */
    protected $anonymousId;
    
    /**
     * This column hosts an id chosen by the admin in case of a game with "anonymous" participation :
     * This is a value chosen from the playerData (generally "email").
     *
     * @ORM\Column(name="anonymous_identifier", type="string", length=255, nullable=true)
     */
    protected $anonymousIdentifier;
    
    /**
     * @ORM\Column(name="player_data", type="text", nullable=true)
     */
    protected $playerData;

    /**
     * @ORM\Column(name="social_shares", type="text", nullable=true)
     */
    protected $socialShares;
    
    /**
     * Is this entry a winning one ?
     * @ORM\Column(type="boolean", nullable=true)
     */
    protected $winner = 0;
    
    /**
     * Is there a termsOptin on this entry ?
     * @ORM\Column(name="terms_optin", type="boolean", nullable=true)
     */
    protected $termsOptin;
    
    /**
     * Is this entry eligible to draw ?
     * @ORM\Column(type="boolean", nullable=true)
     */
    protected $drawable = 0;

    /**
     * @ORM\Column(type="datetime")
     */
    protected $created_at;
    
    /**
     * The step in the play (in a quiz for example : the nth question)
     * @ORM\Column(type="integer", nullable=true)
     */
    protected $step = 0;

    /**
     * @ORM\Column(type="datetime")
     */
    protected $updated_at;

    public function __construct()
    {
    }

    /** @PrePersist */
    public function createChrono()
    {
        $this->created_at = new \DateTime("now");
        $this->updated_at = new \DateTime("now");
    }

    /** @PreUpdate */
    public function updateChrono()
    {
        $this->updated_at = new \DateTime("now");
    }

    /**
     *
     * @return the $id
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     *
     * @param field_type $id
     */
    public function setId($id)
    {
        $this->id = $id;
        
        return $this;
    }

    /**
     * @return the $game
     */
    public function getGame()
    {
        return $this->game;
    }

    /**
     * @param field_type $game
     */
    public function setGame($game)
    {
        $this->game = $game;
        
        return $this;
    }

    /**
     * @return the $user
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * @param field_type $user
     */
    public function setUser($user)
    {
        $this->user = $user;
        
        return $this;
    }

    /**
     * @return integer $points
     */
    public function getPoints()
    {
        return $this->points;
    }

    /**
     * @param integer $points
     */
    public function setPoints($points)
    {
        $this->points = $points;
        
        return $this;
    }

    /**
     * @return the $ip
     */
    public function getIp()
    {
        return $this->ip;
    }

    /**
     * @param field_type $ip
     */
    public function setIp($ip)
    {
        $this->ip = $ip;
        
        return $this;
    }

    /**
     * @return the $geoloc
     */
    public function getGeoloc()
    {
        return $this->geoloc;
    }

    /**
     * @param field_type $geoloc
     */
    public function setGeoloc($geoloc)
    {
        $this->geoloc = $geoloc;
        
        return $this;
    }

    /**
     * @return the $anonymousId
     */
    public function getAnonymousId()
    {
        return $this->anonymousId;
    }

    /**
     * @param field_type $anonymousId
     */
    public function setAnonymousId($anonymousId)
    {
        $this->anonymousId = $anonymousId;
        
        return $this;
    }

    /**
     * @return the $anonymousIdentifier
     */
    public function getAnonymousIdentifier()
    {
        return $this->anonymousIdentifier;
    }

    /**
     * @param field_type $anonymousIdentifier
     */
    public function setAnonymousIdentifier($anonymousIdentifier)
    {
        $this->anonymousIdentifier = $anonymousIdentifier;
    }

    /**
     * @return the $playerData
     */
    public function getPlayerData()
    {
        return $this->playerData;
    }

    /**
     * @param field_type $playerData
     */
    public function setPlayerData($playerData)
    {
        $this->playerData = $playerData;
        
        return $this;
    }

    /**
     * @return the $socialShares
     */
    public function getSocialShares()
    {
        return $this->socialShares;
    }

    /**
     * @param field_type $socialShares
     */
    public function setSocialShares($socialShares)
    {
        $this->socialShares = $socialShares;
    }

    /**
     * @return boolean active
     */
    public function getActive()
    {
        return $this->active;
    }

    /**
     * @param boolean $active
     */
    public function setActive($active)
    {
        $this->active = $active;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        
        return $this;
    }

    /**
     * @return boolean paid
     */
    public function getPaid()
    {
        return $this->paid;
    }

    /**
     * @param boolean $paid
     */
    public function setPaid($paid)
    {
        $this->paid = $paid;
        
        return $this;
    }

    /**
     * @return integer paidAmount
     */
    public function getPaidAmount()
    {
        return $this->paidAmount;
    }

    /**
     * @param integer $paidAmount
     */
    public function setPaidAmount($paidAmount)
    {
        $this->paidAmount = $paidAmount;
        
        return $this;
    }

    /**
     * @return integer $step
     */
    public function getStep()
    {
        return $this->step;
    }

    /**
     * @param number $step
     */
    public function setStep($step)
    {
        $this->step = $step;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @return integer bonus
     */
    public function getBonus()
    {
        return $this->bonus;
    }

    /**
     * @param integer $bonus
     */
    public function setBonus($bonus)
    {
        $this->bonus = $bonus;
        
        return $this;
    }

    /**
     * @return integer status
     */
    public function getWinner()
    {
        return $this->winner;
    }

    /**
     * @param integer $winner
     */
    public function setWinner($winner)
    {
        $this->winner = $winner;
        
        return $this;
    }
    
    /**
     * @return integer $drawable
     */
    public function getDrawable()
    {
        return $this->drawable;
    }

    /**
     * @param number $drawable
     */
    public function setDrawable($drawable)
    {
        $this->drawable = $drawable;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        
        return $this;
    }

    /**
     * @return the termsOptin
     */
    public function getTermsOptin()
    {
        return $this->termsOptin;
    }
    
    /**
     * @param field_type $termsOptin
     */
    public function setTermsOptin($termsOptin)
    {
        $this->termsOptin = $termsOptin;
        
        return $this;
    }

    /**
     * @return \DateTime $created_at
     */
    public function getCreatedAt()
    {
        return $this->created_at;
    }

    /**
     * @param \DateTime $created_at
     */
    public function setCreatedAt($created_at)
    {
        $this->created_at = $created_at;
        
        return $this;
    }

    /**
     * @return \DateTime $updated_at
     */
    public function getUpdatedAt()
    {
        return $this->updated_at;
    }

    /**
     * @param \DateTime $updated_at
     */
    public function setUpdatedAt($updated_at)
    {
        $this->updated_at = $updated_at;
        
        return $this;
    }

    /**
     * Convert the object to an array.
     *
     * @return array
     */
    public function getArrayCopy()
    {
        return get_object_vars($this);
    }

    /**
    * Convert the object to json.
    *
    * @return array
    */
    public function jsonSerialize()
    {
        return $this->getArrayCopy();
    }

    /**
     * Populate from an array.
     *
     * @param array $data
     */
    public function populate($data = array())

    {
    }
}


1			<?php
2			namespace PlaygroundGame\Entity;
3
4			use Doctrine\ORM\Mapping as ORM;
5			use Doctrine\ORM\Mapping\HasLifecycleCallbacks;
6			use Doctrine\ORM\Mapping\PrePersist;
7			use Doctrine\ORM\Mapping\PreUpdate;
8
9			/**
10			* An entry represent a game session.
11			* @ORM\Entity @HasLifecycleCallbacks
12			* @ORM\Table(name="game_entry")
13			*/
14			class Entry implements \JsonSerializable
15			{
16			/**
17			* @ORM\Id
18			* @ORM\Column(type="integer");
19			* @ORM\GeneratedValue(strategy="AUTO")
20			*/
21			protected $id;
22
23			/**
24			* @ORM\ManyToOne(targetEntity="Game", cascade={"persist","remove"})
25			* @ORM\JoinColumn(name="game_id", referencedColumnName="id", onDelete="CASCADE")
26			**/
27			protected $game;
28
29			/**
30			* @ORM\ManyToOne(targetEntity="PlaygroundUser\Entity\User")
31			* @ORM\JoinColumn(name="user_id", referencedColumnName="user_id", onDelete="CASCADE")
32			**/
33			protected $user;
34
35			/**
36			* @ORM\Column(type="boolean", nullable=true)
37			*/
38			protected $active = 1;
39
40			/**
41			* Has this entry been paid
42			* @ORM\Column(type="boolean", nullable=true)
43			*/
44			protected $paid = false;
45
46			/**
47			* The amount paid for this entry
48			* @ORM\Column(name="paid_amount", type="integer", nullable=true)
49			*/
50			protected $paidAmount = 0;
51
52			/**
53			* An entry marked as bonus means that it's not taken into account
54			* in the limit calculation. It's offered, for example, when you share the game to a friend.
55			*
56			* @ORM\Column(type="boolean", nullable=true)
57			*/
58			protected $bonus = 0;
59
60			/**
61			* @ORM\Column(type="integer", nullable=true)
62			*/
63			protected $points;
64
65			/**
66			* @ORM\Column(type="string", length=255, nullable=true)
67			*/
68			protected $ip;
69
70			/**
71			* @ORM\Column(type="string", length=255, nullable=true)
72			*/
73			protected $geoloc;
74
75			/**
76			* @ORM\Column(name="anonymous_id", type="string", length=255, nullable=true)
77			*/
78			protected $anonymousId;
79
80			/**
81			* This column hosts an id chosen by the admin in case of a game with "anonymous" participation :
82			* This is a value chosen from the playerData (generally "email").
83			*
84			* @ORM\Column(name="anonymous_identifier", type="string", length=255, nullable=true)
85			*/
86			protected $anonymousIdentifier;
87
88			/**
89			* @ORM\Column(name="player_data", type="text", nullable=true)
90			*/
91			protected $playerData;
92
93			/**
94			* @ORM\Column(name="social_shares", type="text", nullable=true)
95			*/
96			protected $socialShares;
97
98			/**
99			* Is this entry a winning one ?
100			* @ORM\Column(type="boolean", nullable=true)
101			*/
102			protected $winner = 0;
103
104			/**
105			* Is there a termsOptin on this entry ?
106			* @ORM\Column(name="terms_optin", type="boolean", nullable=true)
107			*/
108			protected $termsOptin;
109
110			/**
111			* Is this entry eligible to draw ?
112			* @ORM\Column(type="boolean", nullable=true)
113			*/
114			protected $drawable = 0;
115
116			/**
117			* @ORM\Column(type="datetime")
118			*/
119			protected $created_at;
120
121			/**
122			* The step in the play (in a quiz for example : the nth question)
123			* @ORM\Column(type="integer", nullable=true)
124			*/
125			protected $step = 0;
126
127			/**
128			* @ORM\Column(type="datetime")
129			*/
130			protected $updated_at;
131
132			public function __construct()
133			{
134			}
135
136			/** @PrePersist */
137			public function createChrono()
138			{
139			$this->created_at = new \DateTime("now");
140			$this->updated_at = new \DateTime("now");
141			}
142
143			/** @PreUpdate */
144			public function updateChrono()
145			{
146			$this->updated_at = new \DateTime("now");
147			}
148
149			/**
150			*
151			* @return the $id
152			*/
153			public function getId()
154			{
155			return $this->id;
156			}
157
158			/**
159			*
160			* @param field_type $id
161			*/
162			public function setId($id)
163			{
164			$this->id = $id;
165
166			return $this;
167			}
168
169			/**
170			* @return the $game
171			*/
172			public function getGame()
173			{
174			return $this->game;
175			}
176
177			/**
178			* @param field_type $game
179			*/
180			public function setGame($game)
181			{
182			$this->game = $game;
183
184			return $this;
185			}
186
187			/**
188			* @return the $user
189			*/
190			public function getUser()
191			{
192			return $this->user;
193			}
194
195			/**
196			* @param field_type $user
197			*/
198			public function setUser($user)
199			{
200			$this->user = $user;
201
202			return $this;
203			}
204
205			/**
206			* @return integer $points
207			*/
208			public function getPoints()
209			{
210			return $this->points;
211			}
212
213			/**
214			* @param integer $points
215			*/
216			public function setPoints($points)
217			{
218			$this->points = $points;
219
220			return $this;
221			}
222
223			/**
224			* @return the $ip
225			*/
226			public function getIp()
227			{
228			return $this->ip;
229			}
230
231			/**
232			* @param field_type $ip
233			*/
234			public function setIp($ip)
235			{
236			$this->ip = $ip;
237
238			return $this;
239			}
240
241			/**
242			* @return the $geoloc
243			*/
244			public function getGeoloc()
245			{
246			return $this->geoloc;
247			}
248
249			/**
250			* @param field_type $geoloc
251			*/
252			public function setGeoloc($geoloc)
253			{
254			$this->geoloc = $geoloc;
255
256			return $this;
257			}
258
259			/**
260			* @return the $anonymousId
261			*/
262			public function getAnonymousId()
263			{
264			return $this->anonymousId;
265			}
266
267			/**
268			* @param field_type $anonymousId
269			*/
270			public function setAnonymousId($anonymousId)
271			{
272			$this->anonymousId = $anonymousId;
273
274			return $this;
275			}
276
277			/**
278			* @return the $anonymousIdentifier
279			*/
280			public function getAnonymousIdentifier()
281			{
282			return $this->anonymousIdentifier;
283			}
284
285			/**
286			* @param field_type $anonymousIdentifier
287			*/
288			public function setAnonymousIdentifier($anonymousIdentifier)
289			{
290			$this->anonymousIdentifier = $anonymousIdentifier;
291			}
292
293			/**
294			* @return the $playerData
295			*/
296			public function getPlayerData()
297			{
298			return $this->playerData;
299			}
300
301			/**
302			* @param field_type $playerData
303			*/
304			public function setPlayerData($playerData)
305			{
306			$this->playerData = $playerData;
307
308			return $this;
309			}
310
311			/**
312			* @return the $socialShares
313			*/
314			public function getSocialShares()
315			{
316			return $this->socialShares;
317			}
318
319			/**
320			* @param field_type $socialShares
321			*/
322			public function setSocialShares($socialShares)
323			{
324			$this->socialShares = $socialShares;
325			}
326
327			/**
328			* @return boolean active
329			*/
330			public function getActive()
331			{
332			return $this->active;
333			}
334
335			/**
336			* @param boolean $active
337			*/
338			public function setActive($active)
339			{
340			$this->active = $active;
			0 ignored issues – show Documentation Bug introduced 2019-04-23 14:54 UTC by Report Bug Copy Issue Report The property `$active` was declared of type `integer`, but `$active` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
341
342			return $this;
343			}
344
345			/**
346			* @return boolean paid
347			*/
348			public function getPaid()
349			{
350			return $this->paid;
351			}
352
353			/**
354			* @param boolean $paid
355			*/
356			public function setPaid($paid)
357			{
358			$this->paid = $paid;
359
360			return $this;
361			}
362
363			/**
364			* @return integer paidAmount
365			*/
366			public function getPaidAmount()
367			{
368			return $this->paidAmount;
369			}
370
371			/**
372			* @param integer $paidAmount
373			*/
374			public function setPaidAmount($paidAmount)
375			{
376			$this->paidAmount = $paidAmount;
377
378			return $this;
379			}
380
381			/**
382			* @return integer $step
383			*/
384			public function getStep()
385			{
386			return $this->step;
387			}
388
389			/**
390			* @param number $step
391			*/
392			public function setStep($step)
393			{
394			$this->step = $step;
			0 ignored issues – show Documentation Bug introduced 2015-11-21 00:28 UTC by Report Bug Copy Issue Report It seems like `$step` can also be of type `double`. However, the property `$step` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
395			}
396
397			/**
398			* @return integer bonus
399			*/
400			public function getBonus()
401			{
402			return $this->bonus;
403			}
404
405			/**
406			* @param integer $bonus
407			*/
408			public function setBonus($bonus)
409			{
410			$this->bonus = $bonus;
411
412			return $this;
413			}
414
415			/**
416			* @return integer status
417			*/
418			public function getWinner()
419			{
420			return $this->winner;
421			}
422
423			/**
424			* @param integer $winner
425			*/
426			public function setWinner($winner)
427			{
428			$this->winner = $winner;
429
430			return $this;
431			}
432
433			/**
434			* @return integer $drawable
435			*/
436			public function getDrawable()
437			{
438			return $this->drawable;
439			}
440
441			/**
442			* @param number $drawable
443			*/
444			public function setDrawable($drawable)
445			{
446			$this->drawable = $drawable;
			0 ignored issues – show Documentation Bug introduced 2015-11-21 00:28 UTC by Report Bug Copy Issue Report It seems like `$drawable` can also be of type `double`. However, the property `$drawable` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
447
448			return $this;
449			}
450
451			/**
452			* @return the termsOptin
453			*/
454			public function getTermsOptin()
455			{
456			return $this->termsOptin;
457			}
458
459			/**
460			* @param field_type $termsOptin
461			*/
462			public function setTermsOptin($termsOptin)
463			{
464			$this->termsOptin = $termsOptin;
465
466			return $this;
467			}
468
469			/**
470			* @return \DateTime $created_at
471			*/
472			public function getCreatedAt()
473			{
474			return $this->created_at;
475			}
476
477			/**
478			* @param \DateTime $created_at
479			*/
480			public function setCreatedAt($created_at)
481			{
482			$this->created_at = $created_at;
483
484			return $this;
485			}
486
487			/**
488			* @return \DateTime $updated_at
489			*/
490			public function getUpdatedAt()
491			{
492			return $this->updated_at;
493			}
494
495			/**
496			* @param \DateTime $updated_at
497			*/
498			public function setUpdatedAt($updated_at)
499			{
500			$this->updated_at = $updated_at;
501
502			return $this;
503			}
504
505			/**
506			* Convert the object to an array.
507			*
508			* @return array
509			*/
510			public function getArrayCopy()
511			{
512			return get_object_vars($this);
513			}
514
515			/**
516			* Convert the object to json.
517			*
518			* @return array
519			*/
520			public function jsonSerialize()
521			{
522			return $this->getArrayCopy();
523			}
524
525			/**
526			* Populate from an array.
527			*
528			* @param array $data
529			*/
530			public function populate($data = array())
			0 ignored issues – show Unused Code introduced 2018-03-03 12:58 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
531			{
532			}
533			}
534

gregorybesson / PlaygroundGame

Push — master ( 64789b...259751 )

Entry::getTermsOptin() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like