MissionController::playAction() - Code Metrics - Inspection of "zf3 refactoring" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#341)

by greg
created 2018-06-07 21:23 UTC
MissionController::playAction() D

↳ Parent: MissionController
Complexity

Conditions	14
Paths	65
Size

Total Lines	145
Code Lines	83
Duplication

Lines	48
Ratio	33.1 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
c	1
b	0
f	0
dl	48
loc	145
rs	4.9516
cc	14
eloc	83
nc	65
nop	0
How to fix Long Method Complexity

<?php

namespace PlaygroundGame\Controller\Frontend;

use PlaygroundGame\Controller\Frontend\GameController;
use PlaygroundGame\Service\GameService;
use Zend\Session\Container;
use Zend\ServiceManager\ServiceLocatorInterface;

class MissionController extends GameController
{

    /**
     * @var gameService
     */
    protected $gameService;
    protected $mission;

    public function __construct(ServiceLocatorInterface $locator)
    {
        parent::__construct($locator);
    }

    /**
     * Homepage of the game
     */
    public function indexAction()
    {
        $entry = $this->getGameService()->checkExistingEntry($this->game, $this->user);
        $games = $this->getGameService()->getMissionGames($this->game, $this->user);

        $viewModel = $this->buildView($this->game);
        $viewModel->setVariables(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            array(
            'user'          => $this->user,
            'games'         => $games,
            'entry'         => $entry,
            'flashMessages' => $this->flashMessenger()->getMessages(),
            )
        );

        return $viewModel;
    }

    public function playAction()
    {
        $subGameIdentifier = $this->getEvent()->getRouteMatch()->getParam('gameId');
        $entry             = $this->getGameService()->play($this->game, $this->user);
        if (!$entry) {

          // the user has already taken part of this game and the participation limit has been reached
            $this->flashMessenger()->addMessage('You have already played');

            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'mission/result',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        if (!$subGameIdentifier) {
            $subGame = $this->game->getNextPlayableGame($entry);
        } else {
            $subGame = $this->getGameService()->checkGame($subGameIdentifier);
        }

        if (!$this->game->isPlayable($subGame, $entry)) {
          // this subgame is not playable
            $this->flashMessenger()->addMessage('No game found');

            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'mission',
                    array('id' => $this->game->getIdentifier())
                )
            );
        }

        $session = new Container('facebook');
      // Redirect to fan gate if the game require to 'like' the page before playing
        if ($session->offsetExists('signed_request')) {
            if ($this->game->getFbFan()) {
                if ($this->getGameService()->checkIsFan($this->game) === false) {
                    return $this->redirect()->toRoute(
                        $this->game->getClassType().'/fangate',
                        array('id' => $this->game->getIdentifier())
                    );
                }
            }
        }

        if (!$this->user) {
          // The game is deployed on Facebook, and played from Facebook : retrieve/register user
            if ($session->offsetExists('signed_request')) {
              // Get Playground user from Facebook info
                $beforeLayout = $this->layout()->getTemplate();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

                $view = $this->forward()->dispatch(
                    'playgrounduser_user',
                    array(
                    'controller' => 'playgrounduser_user',
                    'action'     => 'registerFacebookUser',
                    'provider'   => 'facebook',
                    )
                );

                $this->layout()->setTemplate($beforeLayout);
                $this->user = $view->user;

              // If the user cannot be created/retrieved from Facebook info, redirect to login/register form
                if (!$this->user) {

                    $redirect = urlencode(
                        $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                            'mission/play',
                            array('id'              => $this->game->getIdentifier()),
                            array('force_canonical' => true)
                        )
                    );
                    if (array_search('login', $this->game->getStepsArray())) {
                        return $this->redirect()->toUrl(
                            $this->frontendUrl()->fromRoute('mission/login').'?redirect='.$redirect
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        );
                    } else {
                        return $this->redirect()->toUrl(
                            $this->frontendUrl()->fromRoute('zfcuser/register').'?redirect='.$redirect
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        );
                    }
                }

              // The game is not played from Facebook : redirect to login/register form
            } elseif (!$this->game->getAnonymousAllowed()) {

                $redirect = urlencode(
                    $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        'mission/play',
                        array('id'              => $this->game->getIdentifier()),
                        array('force_canonical' => true)
                    )
                );

                if (array_search('login', $this->game->getStepsArray())) {
                    return $this->redirect()->toUrl(
                        $this->frontendUrl()->fromRoute('mission/login').'?redirect='.$redirect
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    );
                } else {
                    return $this->redirect()->toUrl(
                        $this->frontendUrl()->fromRoute('zfcuser/register').'?redirect='.$redirect
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    );
                }
            }
        }

        $beforeLayout = $this->layout()->getTemplate();
        $classGame = __NAMESPACE__ . '\\' . ucfirst($subGame->getClassType());

        $subViewModel = $this->forward()->dispatch(
            $classGame,
            array(
            'controller' => $classGame,
            'action'     => 'play',
            'id'         => $subGame->getIdentifier()
            )
        );

        if ($this->getResponse()->getStatusCode() == 302) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'mission/result',
                    array(
                    'id'     => $this->game->getIdentifier(),
                    'gameId' => $subGame->getIdentifier()
                    ),
                    array('force_canonical' => true)
                )
            );
        }

      // suite au forward, le template de layout a changé, je dois le rétablir...
        $this->layout()->setTemplate($beforeLayout);

      // give the ability to the mission to have its customized look and feel.
        $templatePathResolver = $this->getServiceLocator()->get('Zend\View\Resolver\TemplatePathStack');
        $l                    = $templatePathResolver->getPaths();
      // I've already added the path for the game so the base path is $l[1]
        $templatePathResolver->addPath($l[1].'custom/'.$this->game->getIdentifier());

        $subViewModel->mission = $this->game;

        return $subViewModel;
    }

    public function resultAction()
    {
        $subGameIdentifier = $this->getEvent()->getRouteMatch()->getParam('gameId');
        $subGame           = $this->getGameService()->checkGame($subGameIdentifier);

        $secretKey     = strtoupper(substr(sha1(uniqid('pg_', true).'####'.time()), 0, 15));
        $socialLinkUrl = $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            'mission',
            array('id'              => $this->game->getIdentifier()),
            array('force_canonical' => true)
        ).'?key='.$secretKey;

        // With core shortener helper
        $socialLinkUrl = $this->shortenUrl()->shortenUrl($socialLinkUrl);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if (!$this->user && !$this->game->getAnonymousAllowed()) {

            $redirect = urlencode(
                $this->frontendUrl()->fromRoute(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    'mission/result',
                    array('id' => $this->game->getIdentifier())
                )
            );

            return $this->redirect()->toUrl(
                $this->frontendUrl()->fromRoute('zfcuser/register').'?redirect='.$redirect
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            );
        }

        $form = $this->getServiceLocator()->get('playgroundgame_sharemail_form');
        $form->setAttribute('method', 'post');

        $beforeLayout = $this->layout()->getTemplate();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $classGame = __NAMESPACE__ . '\\' . ucfirst($subGame->getClassType());
        $subViewModel = $this->forward()->dispatch(
            $classGame,
            array(
                'controller' => $classGame,
                'action'     => 'result',
                'id'         => $subGameIdentifier
            )
        );

        if ($this->getResponse()->getStatusCode() == 302) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->getResponse()->setStatusCode('200');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            $classGame = __NAMESPACE__ . '\\' . ucfirst($subGame->getClassType());
            $subViewModel = $this->forward()->dispatch(
                $classGame,
                array(
                    'controller' => $classGame,
                    'action'     => 'result',
                    'id'         => $subGameIdentifier
                )
            );
        }
        // suite au forward, le template de layout a changé, je dois le rétablir...
        $this->layout()->setTemplate($beforeLayout);

        // give the ability to the mission to have its customized look and feel.
        $templatePathResolver = $this->getServiceLocator()->get('Zend\View\Resolver\TemplatePathStack');
        $l                    = $templatePathResolver->getPaths();
        // I've already added the path for the game so the base path is $l[1]
        $templatePathResolver->addPath($l[1].'custom/'.$this->game->getIdentifier());

        $subViewModel->mission = $this->game;
        return $subViewModel;
    }

    public function fbshareAction()

    {
        $sg         = $this->getGameService();
        $result     = parent::fbshareAction();
        $bonusEntry = false;

        if ($result) {
            $identifier = $this->getEvent()->getRouteMatch()->getParam('id');
            $user       = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $game       = $sg->checkGame($identifier);
            $bonusEntry = $sg->addAnotherChance($game, $user, 1);
        }

        $response = $this->getResponse();
        $response->setContent(\Zend\Json\Json::encode(array(
                    'success'   => $result,
                    'playBonus' => $bonusEntry,
                )));

        return $response;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function fbrequestAction()

    {
        $sg         = $this->getGameService();
        $result     = parent::fbrequestAction();
        $bonusEntry = false;

        if ($result) {
            $identifier = $this->getEvent()->getRouteMatch()->getParam('id');
            $user       = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $game       = $sg->checkGame($identifier);
            $bonusEntry = $sg->addAnotherChance($game, $user, 1);
        }

        $response = $this->getResponse();
        $response->setContent(\Zend\Json\Json::encode(array(
                    'success'   => $result,
                    'playBonus' => $bonusEntry,
                )));

        return $response;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function tweetAction()

    {
        $sg         = $this->getGameService();
        $result     = parent::tweetAction();
        $bonusEntry = false;

        if ($result) {
            $identifier = $this->getEvent()->getRouteMatch()->getParam('id');
            $user       = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $game       = $sg->checkGame($identifier);
            $bonusEntry = $sg->addAnotherChance($game, $user, 1);
        }

        $response = $this->getResponse();
        $response->setContent(\Zend\Json\Json::encode(array(
                    'success'   => $result,
                    'playBonus' => $bonusEntry,
                )));

        return $response;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function googleAction()

    {
        $sg         = $this->getGameService();
        $result     = parent::googleAction();
        $bonusEntry = false;

        if ($result) {
            $identifier = $this->getEvent()->getRouteMatch()->getParam('id');
            $user       = $this->zfcUserAuthentication()->getIdentity();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $game       = $sg->checkGame($identifier);
            $bonusEntry = $sg->addAnotherChance($game, $user, 1);
        }

        $response = $this->getResponse();
        $response->setContent(\Zend\Json\Json::encode(array(
                    'success'   => $result,
                    'playBonus' => $bonusEntry,
                )));

        return $response;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getGameService()
    {
        if (!$this->gameService) {
            $this->gameService = $this->getServiceLocator()->get('playgroundgame_mission_service');
        }

        return $this->gameService;
    }

    public function setGameService(GameService $gameService)
    {
        $this->gameService = $gameService;


        return $this;
    }
}

Pull Request — master (#341)

MissionController::playAction() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

gregorybesson / PlaygroundGame

Pull Request — master (#341)

MissionController::playAction() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
