TradingCardController::playAction() - Code Metrics - Inspection of "New game on the block : Trading Card" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#314)

by greg

created 2016-02-10 00:13 UTC

TradingCardController::playAction() A

↳ Parent: TradingCardController

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	2
eloc	9
nc	2
nop	0

<?php
namespace PlaygroundGame\Controller\Frontend;

class TradingCardController extends GameController
{
    /**
     * @var gameService
     */
    protected $gameService;

    public function playAction()
    {
        $entry = $this->getGameService()->play($this->game, $this->user);
        $viewModel = $this->buildView($this->game);
        $booster = null;
        if ($entry) {
            $booster = $this->getGameService()->getBooster($this->game, $this->user, $entry);
        }
        
        $album = $this->getGameService()->getAlbum($this->game, $this->user);
        $viewModel->setVariables(array('booster' => $booster, 'album' => $album));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $viewModel;
    }

    public function resultAction()
    {
        $album = $this->getGameService()->getAlbum($this->game, $this->user);
        $viewModel = $this->buildView($this->game);
        $viewModel->setVariables(array('album' => $album));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $viewModel;
    }

    public function getGameService()
    {
        if (!$this->gameService) {
            $this->gameService = $this->getServiceLocator()->get('playgroundgame_tradingcard_service');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        return $this->gameService;
    }
}


Pull Request — master (#314)

TradingCardController::playAction() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2			namespace PlaygroundGame\Controller\Frontend;
3
4			class TradingCardController extends GameController
5			{
6			/**
7			* @var gameService
8			*/
9			protected $gameService;
10
11			public function playAction()
12			{
13			$entry = $this->getGameService()->play($this->game, $this->user);
14			$viewModel = $this->buildView($this->game);
15			$booster = null;
16			if ($entry) {
17			$booster = $this->getGameService()->getBooster($this->game, $this->user, $entry);
18			}
19
20			$album = $this->getGameService()->getAlbum($this->game, $this->user);
21			$viewModel->setVariables(array('booster' => $booster, 'album' => $album));
			0 ignored issues – show Bug introduced 2016-02-09 23:46 UTC by Report Bug Copy Issue Report The method `setVariables` does only exist in `Zend\View\Model\ViewModel`, but not in `Zend\Http\PhpEnvironment\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
22
23			return $viewModel;
24			}
25
26			public function resultAction()
27			{
28			$album = $this->getGameService()->getAlbum($this->game, $this->user);
29			$viewModel = $this->buildView($this->game);
30			$viewModel->setVariables(array('album' => $album));
			0 ignored issues – show Bug introduced 2016-02-09 23:46 UTC by Report Bug Copy Issue Report The method `setVariables` does only exist in `Zend\View\Model\ViewModel`, but not in `Zend\Http\PhpEnvironment\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31
32			return $viewModel;
33			}
34
35			public function getGameService()
36			{
37			if (!$this->gameService) {
38			$this->gameService = $this->getServiceLocator()->get('playgroundgame_tradingcard_service');
			0 ignored issues – show Documentation Bug introduced 2016-02-09 23:46 UTC by Report Bug Copy Issue Report It seems like `$this->getServiceLocator...e_tradingcard_service')` can also be of type `array`. However, the property `$gameService` is declared as type `object<PlaygroundGame\Co...r\Frontend\gameService>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
39			}
40
41			return $this->gameService;
42			}
43			}
44

gregorybesson / PlaygroundGame

Pull Request — master (#314)

TradingCardController::playAction() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like