MissionGameFieldset::__construct() - Code Metrics - Inspection of "Merge pull request #268 from gregorybesson/develop" - gregorybesson/PlaygroundGame - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b08b67...b98ff3 )

by greg

created 2015-12-13 16:09 UTC

MissionGameFieldset::__construct() A

↳ Parent: MissionGameFieldset

Complexity

Conditions	1
Paths	1

Size

Total Lines	64
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	64
rs	9.3957
cc	1
eloc	43
nc	1
nop	3

How to fix Long Method

<?php

namespace PlaygroundGame\Form\Admin;

use PlaygroundGame\Entity\MissionGame;
use Zend\Form\Fieldset;
use Zend\Mvc\I18n\Translator;
use PlaygroundCore\Stdlib\Hydrator\DoctrineObject as DoctrineHydrator;
use Zend\ServiceManager\ServiceManager;
use Zend\InputFilter\InputFilterProviderInterface;

class MissionGameFieldset extends Fieldset implements InputFilterProviderInterface
{
    public function __construct($name, ServiceManager $serviceManager, Translator $translator)
    {
        parent::__construct($name);
        $entityManager = $serviceManager->get('doctrine.entitymanager.orm_default');

        $this->setHydrator(new DoctrineHydrator($entityManager, 'PlaygroundGame\Entity\MissionGame'))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ->setObject(new MissionGame());

        $this->add(array(
            'type' => 'Zend\Form\Element\Hidden',
            'name' => 'id'
        ));

        $this->add(array(
            'name' => 'game',
            'type' => 'DoctrineModule\Form\Element\ObjectSelect',
            'options' => array(
                'empty_option' => $translator->translate('Select a game', 'playgroundgame'),
                'label' => $translator->translate('Game', 'playgroundgame'),
                'object_manager' => $entityManager,
                'target_class' => 'PlaygroundGame\Entity\Game',
                'property' => 'title'
            ),
            'attributes' => array(
                'required' => false,
                //'multiple' => 'multiple',
            )
        ));
        
        $this->add(array(
            'type' => 'Zend\Form\Element\Hidden',
            'name' => 'position',
            'attributes' =>  array(
                'id' => 'position__index__',
            ),
        ));
        
        $gameMissionConditionFieldset = new MissionGameConditionFieldset(null, $serviceManager, $translator);
        $this->add(array(
            'type'    => 'Zend\Form\Element\Collection',
            'name'    => 'conditions',
            'options' => array(
                'id'    => 'conditions',
                'label' => $translator->translate('List of conditions', 'playgroundgame'),
                'count' => 0,
                'should_create_template' => true,
                'allow_add' => true,
                'allow_remove' => true,
                'target_element' => $gameMissionConditionFieldset
            )
        ));
        
        $this->add(array(
            'type' => 'Zend\Form\Element\Button',
            'name' => 'add_condition',
            'options' => array(
                'label' => $translator->translate('Add Condition', 'playgroundgame'),
            ),
            'attributes' => array(
                'class' => 'addCondition',
            )
        ));

    }
    
    public function getInputFilterSpecification()
    {
        return array('game' => array('required' => true));
    }
}


1			<?php
2
3			namespace PlaygroundGame\Form\Admin;
4
5			use PlaygroundGame\Entity\MissionGame;
6			use Zend\Form\Fieldset;
7			use Zend\Mvc\I18n\Translator;
8			use PlaygroundCore\Stdlib\Hydrator\DoctrineObject as DoctrineHydrator;
9			use Zend\ServiceManager\ServiceManager;
10			use Zend\InputFilter\InputFilterProviderInterface;
11
12			class MissionGameFieldset extends Fieldset implements InputFilterProviderInterface
13			{
14			public function __construct($name, ServiceManager $serviceManager, Translator $translator)
15			{
16			parent::__construct($name);
17			$entityManager = $serviceManager->get('doctrine.entitymanager.orm_default');
18
19			$this->setHydrator(new DoctrineHydrator($entityManager, 'PlaygroundGame\Entity\MissionGame'))
			0 ignored issues – show Documentation introduced 2015-12-13 15:52 UTC by Report Bug Copy Issue Report `$entityManager` is of type `object\|array`, but the function expects a `object<Doctrine\Common\Persistence\ObjectManager>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20			->setObject(new MissionGame());
21
22			$this->add(array(
23			'type' => 'Zend\Form\Element\Hidden',
24			'name' => 'id'
25			));
26
27			$this->add(array(
28			'name' => 'game',
29			'type' => 'DoctrineModule\Form\Element\ObjectSelect',
30			'options' => array(
31			'empty_option' => $translator->translate('Select a game', 'playgroundgame'),
32			'label' => $translator->translate('Game', 'playgroundgame'),
33			'object_manager' => $entityManager,
34			'target_class' => 'PlaygroundGame\Entity\Game',
35			'property' => 'title'
36			),
37			'attributes' => array(
38			'required' => false,
39			//'multiple' => 'multiple',
40			)
41			));
42
43			$this->add(array(
44			'type' => 'Zend\Form\Element\Hidden',
45			'name' => 'position',
46			'attributes' => array(
47			'id' => 'position__index__',
48			),
49			));
50
51			$gameMissionConditionFieldset = new MissionGameConditionFieldset(null, $serviceManager, $translator);
52			$this->add(array(
53			'type' => 'Zend\Form\Element\Collection',
54			'name' => 'conditions',
55			'options' => array(
56			'id' => 'conditions',
57			'label' => $translator->translate('List of conditions', 'playgroundgame'),
58			'count' => 0,
59			'should_create_template' => true,
60			'allow_add' => true,
61			'allow_remove' => true,
62			'target_element' => $gameMissionConditionFieldset
63			)
64			));
65
66			$this->add(array(
67			'type' => 'Zend\Form\Element\Button',
68			'name' => 'add_condition',
69			'options' => array(
70			'label' => $translator->translate('Add Condition', 'playgroundgame'),
71			),
72			'attributes' => array(
73			'class' => 'addCondition',
74			)
75			));
76
77			}
78
79			public function getInputFilterSpecification()
80			{
81			return array('game' => array('required' => true));
82			}
83			}
84

gregorybesson / PlaygroundGame

Push — master ( b08b67...b98ff3 )

MissionGameFieldset::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like