Module - Code Metrics - Inspection of "fix country helper" - gregorybesson/PlaygroundCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 085115...b1372b )

by greg

created 2016-01-29 10:44 UTC

Module F

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	376
Duplicated Lines	2.13 %

Coupling/Cohesion

Components	0
Dependencies	26

Importance

Changes	25
Bugs	5	Features	2

Metric	Value
wmc	45
c	25
b	5
f	2
lcom	0
cbo	26
dl	8
loc	376
rs	3.7614

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getAutoloaderConfig()	0	13	1
A	getConfig()	0	4	1
F	onBootstrap()	8	177	28
A	getViewHelperConfig()	0	53	1
D	getServiceConfig()	0	116	14

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Module often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Module, and based on these observations, apply Extract Interface, too.

<?php


namespace PlaygroundCore;

use Zend\Session\SessionManager;
use Zend\Session\Config\SessionConfig;
use Zend\Session\Container;
use Zend\Validator\AbstractValidator;
use Zend\EventManager\EventInterface;
use Zend\ModuleManager\Feature\AutoloaderProviderInterface;
use Zend\ModuleManager\Feature\BootstrapListenerInterface;
use Zend\ModuleManager\Feature\ConfigProviderInterface;
use Zend\ModuleManager\Feature\ServiceProviderInterface;
use Zend\ModuleManager\Feature\ViewHelperProviderInterface;

class Module implements

    AutoloaderProviderInterface,
    BootstrapListenerInterface,
    ConfigProviderInterface,
    ServiceProviderInterface,
    ViewHelperProviderInterface
{

    public function onBootstrap(EventInterface $e)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $serviceManager = $e->getApplication()->getServiceManager();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $config = $e->getApplication()->getServiceManager()->get('config');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        // Locale management
        $translator = $serviceManager->get('translator');
        $defaultLocale = 'fr';

        // Gestion de la locale
        if (PHP_SAPI !== 'cli') {
            $config = $e->getApplication()->getServiceManager()->get('config');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if (isset($config['playgroundLocale'])) {
                $pgLocale = $config['playgroundLocale'];
                $defaultLocale = $pgLocale['default'];

                if (isset($pgLocale['strategies'])) {
                    $pgstrat = $pgLocale['strategies'];

                    // Is there a locale in the URL ?
                    if (in_array('uri', $pgstrat)) {
                        $path = $e->getRequest()->getUri()->getPath();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                        $parts = explode('/', trim($path, '/'));
                        $localeCandidate = array_shift($parts);
                        // I switch from locale to... language
                        $localeCandidate = substr($localeCandidate, 0, 2);
                        
                        if (in_array($localeCandidate, $pgLocale['supported'])) {
                            $locale = $localeCandidate;
                        }
                    }

                    // Is there a cookie for the locale ?
                    if (empty($locale) && in_array('cookie', $pgstrat)) {
                        $serviceManager->get('router')->setTranslator($translator);
                        if ($serviceManager->get('router')->match($serviceManager->get('request')) &&
                            strpos($serviceManager->get('router')->match($serviceManager->get('request'))->getMatchedRouteName(), 'admin') !==false
                        ) {
                            if ($e->getRequest()->getCookie() &&
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                                $e->getRequest()->getCookie()->offsetExists('pg_locale_back')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                            ) {
                                $locale = $e->getRequest()->getCookie()->offsetGet('pg_locale_back');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                            }
                        } else {

                            if ($e->getRequest()->getCookie() &&
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                                $e->getRequest()->getCookie()->offsetExists('pg_locale_frontend')
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                            ) {
                                $locale = $e->getRequest()->getCookie()->offsetGet('pg_locale_frontend');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                            }
                        }
                    }

                    // Is there a locale in the request Header ?
                    if (empty($locale) && in_array('header', $pgstrat)) {
                        if (isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
                            $localeCandidate = \Locale::acceptFromHttp($_SERVER['HTTP_ACCEPT_LANGUAGE']);
                            // I switch from locale to... language
                            $localeCandidate = substr($localeCandidate, 0, 2);
                            if (in_array($localeCandidate, $pgLocale['supported'])) {
                                $locale = $localeCandidate;
                            }
                        }
                    }
                }
                // I take the default locale
                if (empty($locale)) {
                    $locale = $defaultLocale;
                }
            }
            
            // I take the default locale
            if (empty($locale)) {
                $locale = $defaultLocale;
            }

            $translator->setLocale($locale);

            // Attach the translator to the router
            $e->getRouter()->setTranslator($translator);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $e->getRouter()->setTranslatorTextDomain('routes');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

            // Attach the translator to the plugins
            $translate = $serviceManager->get('viewhelpermanager')->get('translate');
            $translate->getTranslator()->setLocale($locale);

            $options = $serviceManager->get('playgroundcore_module_options');
            $options->setLocale($locale);
        }

        // positionnement de la langue pour les traductions de date avec strftime
        setlocale(LC_TIME, "fr_FR", 'fr_FR.utf8', 'fra');

        AbstractValidator::setDefaultTranslator($translator, 'playgroundcore');

        /*
         * Entity translation based on Doctrine Gedmo library
         */
        $doctrine = $serviceManager->get('doctrine.entitymanager.orm_default');
        $evm = $doctrine->getEventManager();

        $translatableListener = new \Gedmo\Translatable\TranslatableListener();
        $translatableListener->setDefaultLocale($defaultLocale);
        
        // If no translation is found, fallback to entity data
        $translatableListener->setTranslationFallback(true);
        
        // set Locale
        if (!empty($locale)) {
            $translatableListener->setTranslatableLocale($locale);
        }

        $evm->addEventSubscriber($translatableListener);

        /**
         * Adding a Filter to slugify a string (make it URL compliiant)
         */
        $filterChain = new \Zend\Filter\FilterChain();
        $filterChain->getPluginManager()->setInvokableClass(
            'slugify',
            'PlaygroundCore\Filter\Slugify'
        );
        $filterChain->attach(new Filter\Slugify());

        // Start the session container
        $sessionConfig = new SessionConfig();
        $sessionConfig->setOptions($config['session']);
        $sessionManager = new SessionManager($sessionConfig);
        $sessionManager->start();

        /**
         * Optional: If you later want to use namespaces, you can already store the
         * Manager in the shared (static) Container (=namespace) field
         */
        \Zend\Session\Container::setDefaultManager($sessionManager);

        // Google Analytics : When the render event is triggered, we invoke the view helper to
        // render the javascript code.
        $e->getApplication()->getEventManager()->attach(\Zend\Mvc\MvcEvent::EVENT_RENDER, function (\Zend\Mvc\MvcEvent $e) use ($serviceManager) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $view   = $serviceManager->get('ViewHelperManager');
            $plugin = $view->get('googleAnalytics');
            $plugin();

            $pluginOG = $view->get('facebookOpengraph');
            $pluginOG();
            
            $pluginTC = $view->get('twitterCard');
            $pluginTC();
        });


        if (PHP_SAPI !== 'cli') {
            $session = new Container('facebook');
            $fb = $e->getRequest()->getPost()->get('signed_request');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if ($fb) {
                $signedReq = explode('.', $fb, 2);
                $payload = $signedReq[1];
                $data = json_decode(base64_decode(strtr($payload, '-_', '+/')), true);
                $session->offsetSet('signed_request', $data);

                // This fix exists only for safari on Windows : we need to redirect the user to the page outside of iframe
                // for the cookie to be accepted. Core just adds a 'redir_fb_page_id' var to alert controllers
                // that they need to send the user back to FB...

                if (!count($_COOKIE) > 0 && strpos($_SERVER['HTTP_USER_AGENT'], 'Safari')) {
                    echo '<script type="text/javascript">' .
                    'window.top.location.href = window.location.href+"?redir_fb_page_id='. $data["page"]["id"]. '";' .
                    '</script>';
                }

                // This fix exists only for IE6+, when this app is embedded into an iFrame : The P3P policy has to be set.
                $response = $e->getResponse();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                if ($response instanceof \Zend\Http\Response && (strpos($_SERVER['HTTP_USER_AGENT'], 'MSIE') || strpos($_SERVER['HTTP_USER_AGENT'], 'rv:11.'))) {
                    $response->getHeaders()->addHeaderLine('P3P:CP="IDC DSP COR ADM DEVi TAIi PSA PSD IVAi IVDi CONi HIS OUR IND CNT"');
                }
            }
        }
    }

    public function getAutoloaderConfig()
    {
        return array(
            'Zend\Loader\ClassMapAutoloader' => array(
                __DIR__ . '/../../autoload_classmap.php',
            ),
            'Zend\Loader\StandardAutoloader' => array(
                'namespaces' => array(
                    __NAMESPACE__ => __DIR__ . '/../../src/' . __NAMESPACE__,
                ),
            ),
        );
    }

    public function getConfig()
    {
        return include __DIR__ . '/../../config/module.config.php';
    }

    public function getViewHelperConfig()
    {
        return array(
            'factories' => array(
                'QgCKEditor' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $config = $sm->getServiceLocator()->get('config');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $QuCk = new View\Helper\AdCKEditor($config['playgroundcore']['ckeditor']);

                    return $QuCk;
                },

                'googleAnalytics' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $tracker = $sm->getServiceLocator()->get('google-analytics');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    
                    $helper  = new View\Helper\GoogleAnalytics($tracker, $sm->getServiceLocator()->get('Request'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    
                    return $helper;
                },

                'facebookOpengraph' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $tracker = $sm->getServiceLocator()->get('facebook-opengraph');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

                    $helper  = new View\Helper\FacebookOpengraph($tracker, $sm->getServiceLocator()->get('Request'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

                    return $helper;
                },
                
                'twitterCard' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $viewHelper = new View\Helper\TwitterCard();
                    $viewHelper->setConfig($sm->getServiceLocator()->get('twitter-card'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $viewHelper->setRequest($sm->getServiceLocator()->get('Request'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

                    return $viewHelper;
                },

                'switchLocaleWidget' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $viewHelper = new View\Helper\SwitchLocaleWidget();
                    $viewHelper->setLocaleService($sm->getServiceLocator()->get('playgroundcore_locale_service'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $viewHelper->setWebsiteService($sm->getServiceLocator()->get('playgroundcore_website_service'));
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $viewHelper->setRouteMatch($sm->getServiceLocator()->get('application')->getMvcEvent()->getRouteMatch());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    
                    return $viewHelper;
                },

                'countryName' => function (\Zend\ServiceManager\ServiceManager $sm) {
                    $service = $sm->getServiceLocator()->get('playgroundcore_country_service');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $viewHelper = new View\Helper\CountryName($service);

                    return $viewHelper;
                },
            ),
        );
    }

    public function getServiceConfig()
    {
        return array(

                'aliases' => array(
                    'playgroundcore_doctrine_em' => 'doctrine.entitymanager.orm_default',
                    'google-analytics'           => 'PlaygroundCore\Analytics\Tracker',
                    'facebook-opengraph'         => 'PlaygroundCore\Opengraph\Tracker',
                    'twitter-card'               => 'PlaygroundCore\TwitterCard\Config',
                    'twilio'                     => 'playgroundcore_twilio',
                    'ffmpeg'                     => 'playgroundcore_phpvideotoolkit'
                ),

                'shared' => array(
                    'playgroundcore_message' => false,
                    // don't want this service to be a singleton. I have to reset the ffmpeg parameters for each call.
                    'playgroundcore_ffmpeg_service' => false
                ),

                'invokables' => array(
                    'Zend\Session\SessionManager'        => 'Zend\Session\SessionManager',
                    'playgroundcore_message'             => 'PlaygroundCore\Mail\Service\Message',
                    'playgroundcore_cron_service'        => 'PlaygroundCore\Service\Cron',
                    'playgroundcore_shortenurl_service'  => 'PlaygroundCore\Service\ShortenUrl',
                    'playgroundcore_website_service'     => 'PlaygroundCore\Service\Website',
                    'playgroundcore_locale_service'      => 'PlaygroundCore\Service\Locale',
                    'playgroundcore_formgen_service'     => 'PlaygroundCore\Service\Formgen',
                    'playgroundcore_image_service'       => 'PlaygroundCore\Service\Image',
                    'playgroundcore_ffmpeg_service'      => 'PlaygroundCore\Service\Ffmpeg',
                    'playgroundcore_country_service'     => 'PlaygroundCore\Service\Country',
                ),
                'factories' => array(
                    'playgroundcore_module_options' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        $config = $sm->get('Configuration');

                        return new Options\ModuleOptions(isset($config['playgroundcore']) ? $config['playgroundcore'] : array());
                    },

                    'playgroundcore_formgen_mapper' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        return new Mapper\Formgen($sm->get('playgroundcore_doctrine_em'), $sm->get('playgroundcore_module_options'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    },

                    'playgroundcore_website_mapper' => function (\Zend\ServiceManager\ServiceManager $sm) {

                        return new Mapper\Website($sm->get('playgroundcore_doctrine_em'), $sm->get('playgroundcore_module_options'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    },

                    'playgroundcore_locale_mapper' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        return new Mapper\Locale($sm->get('playgroundcore_doctrine_em'), $sm->get('playgroundcore_module_options'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    },

                    'playgroundcore_twilio' => 'PlaygroundCore\Service\Factory\TwilioServiceFactory',
                    'playgroundcore_phpvideotoolkit' => 'PlaygroundCore\Service\Factory\PhpvideotoolkitServiceFactory',
                    'playgroundcore_transport' => 'PlaygroundCore\Mail\Transport\Service\TransportFactory',
                    'PlaygroundCore\Analytics\Tracker' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        $config = $sm->get('config');
                        $config = isset($config['playgroundcore']) ? $config['playgroundcore']['googleAnalytics'] : array('id' => 'UA-XXXXXXXX-X');

                        $tracker = new Analytics\Tracker($config['id']);

                        if (isset($config['enable_tracking'])) {
                            $tracker->setEnableTracking($config['enable_tracking']);
                        }

                        if (isset($config['custom_vars'])) {
                            foreach ($config['custom_vars'] as $customVar) {
                                $customVarId        = $customVar['id'];
                                $customVarName        = $customVar['name'];
                                $customVarValue    = $customVar['value'];
                                $customVarOptScope  = $customVar['optScope'];
                                $customVar = new Analytics\CustomVar($customVarId, $customVarName, $customVarValue, $customVarOptScope);
                                $tracker->addCustomVar($customVar);
                            }
                        }

                        if (isset($config['domain_name'])) {
                            $tracker->setDomainName($config['domain_name']);
                        }

                        if (isset($config['allow_linker'])) {
                            $tracker->setAllowLinker($config['allow_linker']);
                        }

                        if (isset($config['allow_hash'])) {
                            $tracker->setAllowHash($config['allow_hash']);
                        }

                        return $tracker;
                    },
                    'PlaygroundCore\Opengraph\Tracker' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        $config = $sm->get('config');
                        $config = isset($config['playgroundcore']['facebookOpengraph']) ? $config['playgroundcore']['facebookOpengraph'] : array('appId' => '');

                        $tracker = new Opengraph\Tracker($config['appId']);

                        if (isset($config['enable'])) {
                            $tracker->setEnableOpengraph($config['enable']);
                        }

                        if (isset($config['tags'])) {
                            foreach ($config['tags'] as $type => $value) {
                                $tag = new Opengraph\Tag($type, $value);
                                $tracker->addTag($tag);
                            }
                        }

                        return $tracker;
                    },
                    'PlaygroundCore\TwitterCard\Config' => function (\Zend\ServiceManager\ServiceManager $sm) {
                        $config = $sm->get('config');
                        $config = isset($config['playgroundcore']['twitterCard']) ? $config['playgroundcore']['twitterCard'] : array();
                        return new TwitterCard\Config($config);
                    },
                ),
        );
    }
}


Push — develop ( 085115...b1372b )

Module F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

gregorybesson / PlaygroundCore

Push — develop ( 085115...b1372b )

Module F

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like