ElfinderController - Code Metrics - Inspection of "prepare ZF3" - gregorybesson/PlaygroundCore - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e37f14...da7aa8 )

by greg

created 2016-03-06 20:28 UTC

ElfinderController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	107
Duplicated Lines	17.76 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	14
c	1
b	0
f	0
lcom	1
cbo	4
dl	19
loc	107
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getServiceLocator()	0	5	1
A	indexAction()	9	9	1
A	ckeditorAction()	10	10	1
A	connectorAction()	0	22	2
A	access()	0	6	3
B	getConfig()	0	13	5

How to fix Duplicated Code

<?php
namespace PlaygroundCore\Controller\Admin;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\ServiceManager\ServiceLocatorInterface;

class ElfinderController extends AbstractActionController
{

    protected $Config;

    /**
     *
     * @var ServiceManager
     */
    protected $serviceLocator;

    public function __construct(ServiceLocatorInterface $locator)
    {
        $this->serviceLocator = $locator;

    }

    public function getServiceLocator()
    {
        
        return $this->serviceLocator;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return array|\Zend\View\Model\ViewModel
     */
    public function indexAction()

    {
        $view = new ViewModel();
        $this->getConfig();
        $view->BasePath = $this->Config['BasePath'];
        $view->ConnectorPath = '/admin/elfinder/connector';

        return $view;
    }

    /**
     * @return \Zend\View\Model\ViewModel
     */
    public function ckeditorAction()

    {
        $view = new ViewModel();
        $this->getConfig();
        $view->BasePath    = $this->Config['BasePath'];
        $view->ConnectorPath = '/admin/elfinder/connector';
        $view->setTerminal(true);

        return $view;
    }

    /**
     * @return \Zend\View\Model\ViewModel
     */
    public function connectorAction()
    {
        $view = new ViewModel();
        $this->getConfig();

        $root = array();
        if (isset($this->Config['QuRoots'])) {
            $root = $this->Config['QuRoots'];
        }

        $opts = array(
            'debug' => false,
            'roots' => array($root)
        );

        $connector = new \elFinderConnector(new \elFinder($opts));
        $connector->run();

        $view->setTerminal(true);

        return $view;
    }

    /**
     * @param $attr
     * @param $path
     * @param $data
     * @param $volume
     *
     * @return bool|null
     */
    public function access($attr, $path, $data, $volume)

    {
        return strpos(basename($path), '.') === 0
            ? !($attr == 'read' || $attr == 'write')
            :  null;
    }

    /**
     * @return mixed
     */
    public function getConfig()
    {
        if (!$this->Config) {
            $config       = $this->getServiceLocator()->get('config');
            if (isset($config['playgroundcore']) && isset($config['playgroundcore']['QuConfig']) && isset($config['playgroundcore']['QuConfig']['QuElFinder'])) {
                $this->Config = $config['playgroundcore']['QuConfig']['QuElFinder'];
            } else {
                $this->Config = array();
            }
        }

        return $this->Config;
    }
}


1		<?php
2		namespace PlaygroundCore\Controller\Admin;
3
4		use Zend\Mvc\Controller\AbstractActionController;
5		use Zend\View\Model\ViewModel;
6		use Zend\ServiceManager\ServiceLocatorInterface;
7
8		class ElfinderController extends AbstractActionController
9		{
10
11		protected $Config;
12
13		/**
14		*
15		* @var ServiceManager
16		*/
17		protected $serviceLocator;
18
19		public function __construct(ServiceLocatorInterface $locator)
20		{
21		$this->serviceLocator = $locator;
		0 ignored issues – show Documentation Bug introduced 2016-03-06 20:31 UTC by Report Bug Copy Issue Report It seems like `$locator` of type `object<Zend\ServiceManag...erviceLocatorInterface>` is incompatible with the declared type `object<PlaygroundCore\Co...r\Admin\ServiceManager>` of property `$serviceLocator`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
22		}
23
24		public function getServiceLocator()
25		{
26
27		return $this->serviceLocator;
		0 ignored issues – show Bug Best Practice introduced 2016-03-06 20:31 UTC by Report Bug Copy Issue Report The return type of `return $this->serviceLocator;` (`PlaygroundCore\Controller\Admin\ServiceManager`) is incompatible with the return type of the parent method `Zend\Mvc\Controller\Abst...ller::getServiceLocator` of type `Zend\ServiceManager\ServiceLocatorInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
28		}
29
30		/**
31		* @return array\|\Zend\View\Model\ViewModel
32		*/
33	View Code Duplication	public function indexAction()
		0 ignored issues – show Duplication introduced 2016-03-06 20:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		{
35		$view = new ViewModel();
36		$this->getConfig();
37		$view->BasePath = $this->Config['BasePath'];
38		$view->ConnectorPath = '/admin/elfinder/connector';
39
40		return $view;
41		}
42
43		/**
44		* @return \Zend\View\Model\ViewModel
45		*/
46	View Code Duplication	public function ckeditorAction()
		0 ignored issues – show Duplication introduced 2016-03-06 20:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$view = new ViewModel();
49		$this->getConfig();
50		$view->BasePath = $this->Config['BasePath'];
51		$view->ConnectorPath = '/admin/elfinder/connector';
52		$view->setTerminal(true);
53
54		return $view;
55		}
56
57		/**
58		* @return \Zend\View\Model\ViewModel
59		*/
60		public function connectorAction()
61		{
62		$view = new ViewModel();
63		$this->getConfig();
64
65		$root = array();
66		if (isset($this->Config['QuRoots'])) {
67		$root = $this->Config['QuRoots'];
68		}
69
70		$opts = array(
71		'debug' => false,
72		'roots' => array($root)
73		);
74
75		$connector = new \elFinderConnector(new \elFinder($opts));
76		$connector->run();
77
78		$view->setTerminal(true);
79
80		return $view;
81		}
82
83		/**
84		* @param $attr
85		* @param $path
86		* @param $data
87		* @param $volume
88		*
89		* @return bool\|null
90		*/
91		public function access($attr, $path, $data, $volume)
		0 ignored issues – show Unused Code introduced 2015-12-19 15:36 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-19 15:36 UTC by Report Bug Copy Issue Report The parameter `$volume` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
92		{
93		return strpos(basename($path), '.') === 0
94		? !($attr == 'read' \|\| $attr == 'write')
95		: null;
96		}
97
98		/**
99		* @return mixed
100		*/
101		public function getConfig()
102		{
103		if (!$this->Config) {
104		$config = $this->getServiceLocator()->get('config');
105		if (isset($config['playgroundcore']) && isset($config['playgroundcore']['QuConfig']) && isset($config['playgroundcore']['QuConfig']['QuElFinder'])) {
106		$this->Config = $config['playgroundcore']['QuConfig']['QuElFinder'];
107		} else {
108		$this->Config = array();
109		}
110		}
111
112		return $this->Config;
113		}
114		}
115

gregorybesson / PlaygroundCore

Push — develop ( e37f14...da7aa8 )

ElfinderController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like