Issues in Message.php (master) - Issues in master - gregoriohc/rosetta - Measure and Improve Code Quality continuously with Scrutinizer

Issues (33)

Security Analysis no request data

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Messages/Message.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace Ghc\Rosetta\Messages;

use Ghc\Rosetta\Configurable;
use Ghc\Rosetta\Pipes\Pipeable;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Support\Arr;
use JsonSerializable;
use Serializable;

abstract class Message implements Arrayable, Serializable, JsonSerializable, Pipeable
{
    use Configurable;

    /**
     * Message data.
     *
     * @var mixed
     */
    protected $data;

    /**
     * Message constructor.
     *
     * @param null|mixed $data
     * @param array      $config
     */
    public function __construct($data = null, $config = [])
    {
        $this->setData($data ?: $this->newData());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        $this->setConfig($config);

        $this->boot();
    }

    /**
     * Boot Transformer.
     */
    protected function boot()
    {
    }

    /**
     * @return null
     */
    public function newData()
    {
    }

    /**
     * @return mixed
     */
    public function getData()
    {
        return $this->data;
    }

    /**
     * @param mixed $data
     *
     * @return self
     */
    public function setData($data)
    {
        $this->data = $data;

        return $this;
    }

    /**
     * @return string
     */
    public function serialize()
    {
        return serialize([
            'data'   => $this->toArray(),
            'config' => $this->getConfig(),
        ]);
    }

    /**
     * @param string $serialized
     */
    public function unserialize($serialized)
    {
        $unserialized = unserialize($serialized);
        $this->fromArray($unserialized['data']);
        $this->setConfig($unserialized['config']);
    }

    /**
     * @return array
     */
    public function jsonSerialize()
    {
        return $this->toArray();
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return (string) $this->getData();
    }

    /**
     * @param array $options
     *
     * @return \Closure
     */
    public function pipe($options = [])
    {
        return function ($inputData) use ($options) {
            $fromArray = Arr::get($options, 'fromArray', true);
            if ($fromArray) {
                $this->fromArray($inputData);
            } else {
                $this->setData($inputData);
            }

            return $this->toArray();
        };
    }

    /**
     * @param array $data
     *
     * @return self
     */
    abstract public function fromArray($data);
}


1			<?php
2
3			namespace Ghc\Rosetta\Messages;
4
5			use Ghc\Rosetta\Configurable;
6			use Ghc\Rosetta\Pipes\Pipeable;
7			use Illuminate\Contracts\Support\Arrayable;
8			use Illuminate\Support\Arr;
9			use JsonSerializable;
10			use Serializable;
11
12			abstract class Message implements Arrayable, Serializable, JsonSerializable, Pipeable
13			{
14			use Configurable;
15
16			/**
17			* Message data.
18			*
19			* @var mixed
20			*/
21			protected $data;
22
23			/**
24			* Message constructor.
25			*
26			* @param null\|mixed $data
27			* @param array $config
28			*/
29			public function __construct($data = null, $config = [])
30			{
31			$this->setData($data ?: $this->newData());
			0 ignored issues – show Bug introduced 2017-10-18 13:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->newData()` targeting `Ghc\Rosetta\Messages\Message::newData()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
32			$this->setConfig($config);
33
34			$this->boot();
35			}
36
37			/**
38			* Boot Transformer.
39			*/
40			protected function boot()
41			{
42			}
43
44			/**
45			* @return null
46			*/
47			public function newData()
48			{
49			}
50
51			/**
52			* @return mixed
53			*/
54			public function getData()
55			{
56			return $this->data;
57			}
58
59			/**
60			* @param mixed $data
61			*
62			* @return self
63			*/
64			public function setData($data)
65			{
66			$this->data = $data;
67
68			return $this;
69			}
70
71			/**
72			* @return string
73			*/
74			public function serialize()
75			{
76			return serialize([
77			'data' => $this->toArray(),
78			'config' => $this->getConfig(),
79			]);
80			}
81
82			/**
83			* @param string $serialized
84			*/
85			public function unserialize($serialized)
86			{
87			$unserialized = unserialize($serialized);
88			$this->fromArray($unserialized['data']);
89			$this->setConfig($unserialized['config']);
90			}
91
92			/**
93			* @return array
94			*/
95			public function jsonSerialize()
96			{
97			return $this->toArray();
98			}
99
100			/**
101			* @return string
102			*/
103			public function __toString()
104			{
105			return (string) $this->getData();
106			}
107
108			/**
109			* @param array $options
110			*
111			* @return \Closure
112			*/
113			public function pipe($options = [])
114			{
115			return function ($inputData) use ($options) {
116			$fromArray = Arr::get($options, 'fromArray', true);
117			if ($fromArray) {
118			$this->fromArray($inputData);
119			} else {
120			$this->setData($inputData);
121			}
122
123			return $this->toArray();
124			};
125			}
126
127			/**
128			* @param array $data
129			*
130			* @return self
131			*/
132			abstract public function fromArray($data);
133			}
134

gregoriohc / rosetta

Issues (33)

Security Analysis no request data

src/Messages/Message.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like