RetainPaymentMethodRequest - Code Metrics - Inspection of "Drop PHP 5.3 support and prepare for first product..." - gregoriohc/omnipay-spreedly - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (eebe0d)

by Gregorio

created 2018-03-06 15:43 UTC

RetainPaymentMethodRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	1
dl	29
loc	29
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	6	6	1
A	getEndpoint()	4	4	1
A	getHttpMethod()	4	4	1

How to fix Duplicated Code

<?php

namespace Omnipay\Spreedly\Message;

/**
 * @method Response send()
 */
class RetainPaymentMethodRequest extends AbstractPaymentMethodRequest

{
    /**
     * @return null
     * @throws \Omnipay\Common\Exception\InvalidRequestException
     */
    public function getData()
    {
        $this->validate('payment_method_token');

        return null;
    }

    /**
     * @return string
     */
    public function getEndpoint()
    {
        return $this->endpoint . 'payment_methods/' . $this->getPaymentMethodToken() . '/retain';
    }

    /**
     * @return string
     */
    public function getHttpMethod()
    {
        return 'PUT';
    }
}


1			<?php
2
3			namespace Omnipay\Spreedly\Message;
4
5			/**
6			* @method Response send()
7			*/
8		View Code Duplication	class RetainPaymentMethodRequest extends AbstractPaymentMethodRequest
			0 ignored issues – show Duplication introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9			{
10			/**
11			* @return null
12			* @throws \Omnipay\Common\Exception\InvalidRequestException
13			*/
14	6		public function getData()
15			{
16	6		$this->validate('payment_method_token');
17
18	6		return null;
19			}
20
21			/**
22			* @return string
23			*/
24	6		public function getEndpoint()
25			{
26	6		return $this->endpoint . 'payment_methods/' . $this->getPaymentMethodToken() . '/retain';
27			}
28
29			/**
30			* @return string
31			*/
32	3		public function getHttpMethod()
33			{
34	3		return 'PUT';
35			}
36			}
37

gregoriohc / omnipay-spreedly

Branch — master (eebe0d)

RetainPaymentMethodRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like