ListGatewaysRequest - Code Metrics - Inspection of "Drop PHP 5.3 support and prepare for first product..." - gregoriohc/omnipay-spreedly - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (eebe0d)

by Gregorio

created 2018-03-06 15:43 UTC

ListGatewaysRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	30
loc	30
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getData()	6	6	2
A	getEndpoint()	4	4	1
A	getHttpMethod()	4	4	1

How to fix Duplicated Code

<?php

namespace Omnipay\Spreedly\Message;

use Omnipay\Spreedly\Message\Concerns\HasPagination;

/**
 * @method Response send()
 */
class ListGatewaysRequest extends AbstractRequest

{
    use HasPagination;

    /**
     * @return array
     */
    public function getData()
    {
        $data = $this->fillPaginationParameters (array());

        return count($data) ? $data : null;
    }

    /**
     * @return string
     */
    public function getEndpoint()
    {
        return $this->endpoint . 'gateways';
    }

    /**
     * @return string
     */
    public function getHttpMethod()
    {
        return 'GET';
    }
}


1			<?php
2
3			namespace Omnipay\Spreedly\Message;
4
5			use Omnipay\Spreedly\Message\Concerns\HasPagination;
6
7			/**
8			* @method Response send()
9			*/
10		View Code Duplication	class ListGatewaysRequest extends AbstractRequest
			0 ignored issues – show Duplication introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11			{
12			use HasPagination;
13
14			/**
15			* @return array
16			*/
17	12		public function getData()
18			{
19	12		$data = $this->fillPaginationParameters (array());
20
21	12		return count($data) ? $data : null;
22			}
23
24			/**
25			* @return string
26			*/
27	12		public function getEndpoint()
28			{
29	12		return $this->endpoint . 'gateways';
30			}
31
32			/**
33			* @return string
34			*/
35	9		public function getHttpMethod()
36			{
37	9		return 'GET';
38			}
39			}
40

gregoriohc / omnipay-spreedly

Branch — master (eebe0d)

ListGatewaysRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like