HasOwnerData - Code Metrics - Inspection of "Drop PHP 5.3 support and prepare for first product..." - gregoriohc/omnipay-spreedly - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (eebe0d)

by Gregorio

created 2018-03-06 15:43 UTC

HasOwnerData A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	6
lcom	0
cbo	0
dl	0
loc	32
ccs	12
cts	12
cp	1
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	getFirstName()	4	1
A	setFirstName()	4	1
A	getLastName()	4	1
A	setLastName()	4	1
A	getEmail()	4	1
A	setEmail()	4	1

<?php

namespace Omnipay\Spreedly\Concerns;

trait HasOwnerData
{
    public function getFirstName()
    {
        return $this->getParameter('first_name');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function setFirstName($value)
    {
        return $this->setParameter('first_name', $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getLastName()
    {
        return $this->getParameter('last_name');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function setLastName($value)
    {
        return $this->setParameter('last_name', $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getEmail()
    {
        return $this->getParameter('email');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function setEmail($value)
    {
        return $this->setParameter('email', $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Omnipay\Spreedly\Concerns;
4
5		trait HasOwnerData
6		{
7	12	public function getFirstName()
8		{
9	12	return $this->getParameter('first_name');
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
10		}
11
12	9	public function setFirstName($value)
13		{
14	9	return $this->setParameter('first_name', $value);
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15		}
16
17	12	public function getLastName()
18		{
19	12	return $this->getParameter('last_name');
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20		}
21
22	9	public function setLastName($value)
23		{
24	9	return $this->setParameter('last_name', $value);
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25		}
26
27	12	public function getEmail()
28		{
29	12	return $this->getParameter('email');
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30		}
31
32	6	public function setEmail($value)
33		{
34	6	return $this->setParameter('email', $value);
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35		}
36		}
37

gregoriohc / omnipay-spreedly

Branch — master (eebe0d)

HasOwnerData A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like