HasPagination - Code Metrics - gregoriohc/omnipay-spreedly - Measure and Improve Code Quality continuously with Scrutinizer

HasPagination A
last analyzed 2018-03-15 22:45 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

61.53%

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	0
dl	0
loc	41
ccs	16
cts	26
cp	0.6153
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	getOrder()	4	1
A	setOrder()	4	1
A	getSinceToken()	4	1
A	setSinceToken()	4	1
A	fillPaginationParameters()	12	3

<?php

namespace Omnipay\Spreedly\Message\Concerns;

use Omnipay\Common\CreditCard;
use Omnipay\Common\Exception\InvalidRequestException;
use Omnipay\Spreedly\BankAccount;

trait HasPagination
{
    public function getOrder()
    {
        return $this->getParameter('order');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function setOrder($value)
    {
        return $this->setParameter('order', $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getSinceToken()
    {
        return $this->getParameter('since_token');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function setSinceToken($value)
    {
        return $this->setParameter('since_token', $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Map data with existing parameters
     *
     * @param array $data
     * @return array
     */
    protected function fillPaginationParameters($data)
    {
        if ($order = $this->getOrder()) {
            $data['order'] = $order;
        }

        if ($sinceToken = $this->getSinceToken()) {
            $data['since_token'] = $sinceToken;
        }

        return $data;
    }
}


1		<?php
2
3		namespace Omnipay\Spreedly\Message\Concerns;
4
5		use Omnipay\Common\CreditCard;
6		use Omnipay\Common\Exception\InvalidRequestException;
7		use Omnipay\Spreedly\BankAccount;
8
9		trait HasPagination
10		{
11	12	public function getOrder()
12		{
13	12	return $this->getParameter('order');
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
14		}
15
16	4	public function setOrder($value)
17		{
18	4	return $this->setParameter('order', $value);
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19		}
20
21	12	public function getSinceToken()
22		{
23	12	return $this->getParameter('since_token');
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `getParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24		}
25
26	4	public function setSinceToken($value)
27		{
28	4	return $this->setParameter('since_token', $value);
		0 ignored issues – show Bug introduced 2018-03-06 12:58 UTC by Report Bug Copy Issue Report It seems like `setParameter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29		}
30
31		/**
32		* Map data with existing parameters
33		*
34		* @param array $data
35		* @return array
36		*/
37	12	protected function fillPaginationParameters($data)
38		{
39	12	if ($order = $this->getOrder()) {
40	4	$data['order'] = $order;
41	4	}
42
43	12	if ($sinceToken = $this->getSinceToken()) {
44	4	$data['since_token'] = $sinceToken;
45	4	}
46
47	12	return $data;
48		}
49		}
50

gregoriohc / omnipay-spreedly

HasPagination A last analyzed 2018-03-15 22:45 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

HasPagination A
last analyzed 2018-03-15 22:45 UTC