Conditions | 13 |
Total Lines | 93 |
Code Lines | 47 |
Lines | 93 |
Ratio | 100 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like gvm.protocols.gmpv214.gmpv214.GmpV214Mixin.modify_user() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
1 | # -*- coding: utf-8 -*- |
||
61 | View Code Duplication | def modify_user( |
|
62 | self, |
||
63 | user_id: str = None, |
||
64 | *, |
||
65 | name: Optional[str] = None, |
||
66 | comment: Optional[str] = None, |
||
67 | password: Optional[str] = None, |
||
68 | auth_source: Optional[UserAuthType] = None, |
||
69 | role_ids: Optional[List[str]] = None, |
||
70 | hosts: Optional[List[str]] = None, |
||
71 | hosts_allow: Optional[bool] = False, |
||
72 | ifaces: Optional[List[str]] = None, |
||
73 | ifaces_allow: Optional[bool] = False, |
||
74 | group_ids: Optional[List[str]] = None, |
||
75 | ) -> Any: |
||
76 | |||
77 | """Modifies an existing user. Most of the fields need to be supplied |
||
78 | for changing a single field even if no change is wanted for those. |
||
79 | Else empty values are inserted for the missing fields instead. |
||
80 | |||
81 | Arguments: |
||
82 | user_id: UUID of the user to be modified. |
||
83 | name: The new name for the user. |
||
84 | comment: Comment on the user. |
||
85 | password: The password for the user. |
||
86 | auth_source: Source allowed for authentication for this user. |
||
87 | roles_id: List of roles UUIDs for the user. |
||
88 | hosts: User access rules: List of hosts. |
||
89 | hosts_allow: Defines how the hosts list is to be interpreted. |
||
90 | If False (default) the list is treated as a deny list. |
||
91 | All hosts are allowed by default except those provided by |
||
92 | the hosts parameter. If True the list is treated as a |
||
93 | allow list. All hosts are denied by default except those |
||
94 | provided by the hosts parameter. |
||
95 | ifaces: User access rules: List of ifaces. |
||
96 | ifaces_allow: Defines how the ifaces list is to be interpreted. |
||
97 | If False (default) the list is treated as a deny list. |
||
98 | All ifaces are allowed by default except those provided by |
||
99 | the ifaces parameter. If True the list is treated as a |
||
100 | allow list. All ifaces are denied by default except those |
||
101 | provided by the ifaces parameter. |
||
102 | group_ids: List of group UUIDs for the user. |
||
103 | |||
104 | Returns: |
||
105 | The response. See :py:meth:`send_command` for details. |
||
106 | """ |
||
107 | if not user_id: |
||
108 | raise RequiredArgument( |
||
109 | function=self.modify_user.__name__, argument='user_id' |
||
110 | ) |
||
111 | |||
112 | cmd = XmlCommand("modify_user") |
||
113 | |||
114 | if user_id: |
||
115 | cmd.set_attribute("user_id", user_id) |
||
116 | |||
117 | if name: |
||
118 | cmd.add_element("new_name", name) |
||
119 | |||
120 | if role_ids: |
||
121 | for role in role_ids: |
||
122 | cmd.add_element("role", attrs={"id": role}) |
||
123 | |||
124 | if hosts: |
||
125 | cmd.add_element( |
||
126 | "hosts", |
||
127 | to_comma_list(hosts), |
||
128 | attrs={"allow": to_bool(hosts_allow)}, |
||
129 | ) |
||
130 | |||
131 | if ifaces: |
||
132 | cmd.add_element( |
||
133 | "ifaces", |
||
134 | to_comma_list(ifaces), |
||
135 | attrs={"allow": to_bool(ifaces_allow)}, |
||
136 | ) |
||
137 | |||
138 | if comment: |
||
139 | cmd.add_element("comment", comment) |
||
140 | |||
141 | if password: |
||
142 | cmd.add_element("password", password) |
||
143 | |||
144 | if auth_source: |
||
145 | _xmlauthsrc = cmd.add_element("sources") |
||
146 | _xmlauthsrc.add_element("source", auth_source.value) |
||
147 | |||
148 | if group_ids: |
||
149 | _xmlgroups = cmd.add_element("groups") |
||
150 | for group_id in group_ids: |
||
151 | _xmlgroups.add_element("group", attrs={"id": group_id}) |
||
152 | |||
153 | return self._send_xml_command(cmd) |
||
154 |