tests.testSSHDaemon.TestSSH.testRunCommandNoCredential() - Code Metrics - Inspection of "Add support for credentials in multi-target mode." - greenbone/ospd - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#41)

unknown

created 2018-09-03 06:58 UTC

TestSSH.testRunCommandNoCredential() A

↳ Parent: tests.testSSHDaemon

Complexity

Conditions

Size

Total Lines	7
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nop	1
dl	0
loc	7
rs	10
c	0
b	0
f	0

import unittest
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from ospd import ospd_ssh
from ospd.ospd_ssh import OSPDaemonSimpleSSH

class FakeFile(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self, content):
        self.content = content
    def readlines(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return self.content.split('\n')

commands = None

class FakeSSHClient(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def __init__(self):
        global commands

        commands = []
    def set_missing_host_key_policy(self, policy):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass
    def connect(self, **kwargs):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass
    def exec_command(self, cmd):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        commands.append(cmd)
        return None, FakeFile(''), None
    def close(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass

class FakeExceptions(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    AuthenticationException = None

class fakeparamiko(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    @staticmethod
    def SSHClient(*args):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return FakeSSHClient(*args)

    @staticmethod
    def AutoAddPolicy():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass

    ssh_exception = FakeExceptions


class TestSSH(unittest.TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    def testNoParamiko(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        ospd_ssh.paramiko = None
        self.assertRaises(ImportError, OSPDaemonSimpleSSH, 'cert', 'key', 'ca')

    def testRunCommand(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        ospd_ssh.paramiko = fakeparamiko
        daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
        scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
                                    dict(port=5, ssh_timeout=15,
                                         username_password='dummy:pw'), '')
        res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
        self.assertTrue(isinstance(res, list))
        self.assertEqual(commands, ['cat /etc/passwd'])

    def testRunCommandLegacyCredential(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        ospd_ssh.paramiko = fakeparamiko
        daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
        scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
                                    dict(port=5, ssh_timeout=15,
                                         username='dummy', password='pw'), '')
        res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
        self.assertTrue(isinstance(res, list))
        self.assertEqual(commands, ['cat /etc/passwd'])

    def testRunCommandNewCredential(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        ospd_ssh.paramiko = fakeparamiko
        daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')

        cred_dict = {'ssh': {'type': 'up',
                             'password': 'mypass',
                             'port': '22',
                             'username': 'scanuser'},
                     'smb': {'type': 'up',
                             'password': 'mypass',
                             'username': 'smbuser'}}

        scanid = daemon.create_scan(None,
                                    [['host.example.com', '80, 443', cred_dict],],
                                    dict(port=5, ssh_timeout=15), '')
        res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
        self.assertTrue(isinstance(res, list))
        self.assertEqual(commands, ['cat /etc/passwd'])

    def testRunCommandNoCredential(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        ospd_ssh.paramiko = fakeparamiko
        daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
        scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
                                    dict(port=5, ssh_timeout=15), '')
        self.assertRaises(ValueError, daemon.run_command,
                          scanid, 'host.example.com', 'cat /etc/passwd'  )



1			import unittest
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `testSSHDaemon` does not conform to the module naming conventions (`(([a-z_][a-z0-9_]*)\|([A-Z][a-zA-Z0-9]+))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2
3			from ospd import ospd_ssh
4			from ospd.ospd_ssh import OSPDaemonSimpleSSH
5
6			class FakeFile(object):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
7			def __init__(self, content):
8			self.content = content
9			def readlines(self):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
10			return self.content.split('\n')
11
12			commands = None
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `commands` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
13			class FakeSSHClient(object):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
14			def __init__(self):
15			global commands
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `commands` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report Usage of the `global` statement should be avoided. Usage of `global` can make code hard to read and test, its usage is generally not recommended unless you are dealing with legacy code. Loading history...
16			commands = []
17			def set_missing_host_key_policy(self, policy):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
18			pass
19			def connect(self, **kwargs):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
20			pass
21			def exec_command(self, cmd):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method could be written as a function/class method. If a method does not access any attributes of the class, it could also be implemented as a function or static method. This can help improve readability. For example class Foo: def some_method(self, x, y): return x + y; could be written as class Foo: @classmethod def some_method(cls, x, y): return x + y; Loading history...
22			commands.append(cmd)
23			return None, FakeFile(''), None
24			def close(self):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			pass
26
27			class FakeExceptions(object):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
28			AuthenticationException = None
29
30			class fakeparamiko(object):
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `fakeparamiko` does not conform to the class naming conventions (`[A-Z_][a-zA-Z0-9]+$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
31			@staticmethod
32			def SSHClient(*args):
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `SSHClient` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
33			return FakeSSHClient(*args)
34
35			@staticmethod
36			def AutoAddPolicy():
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `AutoAddPolicy` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
37			pass
38
39			ssh_exception = FakeExceptions
40
41
42			class TestSSH(unittest.TestCase):
			0 ignored issues – show Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
43
44			def testNoParamiko(self):
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `testNoParamiko` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
45			ospd_ssh.paramiko = None
46			self.assertRaises(ImportError, OSPDaemonSimpleSSH, 'cert', 'key', 'ca')
47
48			def testRunCommand(self):
			0 ignored issues – show Coding Style Naming introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report The name `testRunCommand` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-06-12 10:47 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
49			ospd_ssh.paramiko = fakeparamiko
50			daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
51			scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
52			dict(port=5, ssh_timeout=15,
53			username_password='dummy:pw'), '')
54			res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
55			self.assertTrue(isinstance(res, list))
56			self.assertEqual(commands, ['cat /etc/passwd'])
57
58			def testRunCommandLegacyCredential(self):
			0 ignored issues – show Coding Style Naming introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report The name `testRunCommandLegacyCredential` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
59			ospd_ssh.paramiko = fakeparamiko
60			daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
61			scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
62			dict(port=5, ssh_timeout=15,
63			username='dummy', password='pw'), '')
64			res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
65			self.assertTrue(isinstance(res, list))
66			self.assertEqual(commands, ['cat /etc/passwd'])
67
68			def testRunCommandNewCredential(self):
			0 ignored issues – show Coding Style Naming introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report The name `testRunCommandNewCredential` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
69			ospd_ssh.paramiko = fakeparamiko
70			daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
71
72			cred_dict = {'ssh': {'type': 'up',
73			'password': 'mypass',
74			'port': '22',
75			'username': 'scanuser'},
76			'smb': {'type': 'up',
77			'password': 'mypass',
78			'username': 'smbuser'}}
79
80			scanid = daemon.create_scan(None,
81			[['host.example.com', '80, 443', cred_dict],],
82			dict(port=5, ssh_timeout=15), '')
83			res = daemon.run_command(scanid, 'host.example.com', 'cat /etc/passwd')
84			self.assertTrue(isinstance(res, list))
85			self.assertEqual(commands, ['cat /etc/passwd'])
86
87			def testRunCommandNoCredential(self):
			0 ignored issues – show Coding Style Naming introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report The name `testRunCommandNoCredential` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
88			ospd_ssh.paramiko = fakeparamiko
89			daemon = OSPDaemonSimpleSSH('cert', 'key', 'ca')
90			scanid = daemon.create_scan(None, [['host.example.com', '80, 443', ''],],
91			dict(port=5, ssh_timeout=15), '')
92			self.assertRaises(ValueError, daemon.run_command,
93			scanid, 'host.example.com', 'cat /etc/passwd' )
			0 ignored issues – show Coding Style introduced 2018-08-31 13:02 UTC by Report Bug Copy Issue Report No space allowed before bracket Loading history...
94

greenbone / ospd

Pull Request — master (#41)

TestSSH.testRunCommandNoCredential() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like