| Conditions | 9 |
| Total Lines | 73 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | # Copyright (C) 2014-2020 Greenbone Networks GmbH |
||
| 89 | def main( |
||
| 90 | name: str, |
||
| 91 | daemon_class: Type[OSPDaemon], |
||
| 92 | parser: Optional[ParserType] = None, |
||
| 93 | ): |
||
| 94 | """ OSPD Main function. """ |
||
| 95 | |||
| 96 | if not parser: |
||
| 97 | parser = create_parser(name) |
||
| 98 | args = parser.parse_arguments() |
||
| 99 | |||
| 100 | if args.version: |
||
| 101 | args.foreground = True |
||
| 102 | |||
| 103 | init_logging( |
||
| 104 | name, |
||
| 105 | args.log_level, |
||
| 106 | log_file=args.log_file, |
||
| 107 | log_config=args.log_config, |
||
| 108 | foreground=args.foreground, |
||
| 109 | ) |
||
| 110 | |||
| 111 | if args.port == 0: |
||
| 112 | server = UnixSocketServer( |
||
| 113 | args.unix_socket, args.socket_mode, args.stream_timeout, |
||
| 114 | ) |
||
| 115 | else: |
||
| 116 | server = TlsServer( |
||
| 117 | args.address, |
||
| 118 | args.port, |
||
| 119 | args.cert_file, |
||
| 120 | args.key_file, |
||
| 121 | args.ca_file, |
||
| 122 | args.stream_timeout, |
||
| 123 | ) |
||
| 124 | |||
| 125 | daemon = daemon_class(**vars(args)) |
||
| 126 | |||
| 127 | if args.version: |
||
| 128 | print_version(daemon) |
||
| 129 | sys.exit() |
||
| 130 | |||
| 131 | if args.list_commands: |
||
| 132 | print(daemon.get_help_text()) |
||
| 133 | sys.exit() |
||
| 134 | |||
| 135 | if not args.foreground: |
||
| 136 | go_to_background() |
||
| 137 | |||
| 138 | if not create_pid(args.pid_file): |
||
| 139 | sys.exit() |
||
| 140 | |||
| 141 | # Set signal handler and cleanup |
||
| 142 | atexit.register( |
||
| 143 | exit_cleanup, pidfile=args.pid_file, server=server, daemon=daemon |
||
| 144 | ) |
||
| 145 | signal.signal( |
||
| 146 | signal.SIGTERM, partial(exit_cleanup, args.pid_file, server, daemon) |
||
| 147 | ) |
||
| 148 | |||
| 149 | if not daemon.check(): |
||
| 150 | return 1 |
||
| 151 | |||
| 152 | LOGGER.info( |
||
| 153 | "Starting %s version %s.", |
||
| 154 | daemon.daemon_info['name'], |
||
| 155 | daemon.daemon_info['version'], |
||
| 156 | ) |
||
| 157 | |||
| 158 | daemon.init(server) |
||
| 159 | daemon.run() |
||
| 160 | |||
| 161 | return 0 |
||
| 162 |