Conditions | 9 |
Total Lines | 72 |
Code Lines | 48 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # Copyright (C) 2014-2020 Greenbone Networks GmbH |
||
89 | def main( |
||
90 | name: str, |
||
91 | daemon_class: Type[OSPDaemon], |
||
92 | parser: Optional[ParserType] = None, |
||
93 | ): |
||
94 | """ OSPD Main function. """ |
||
95 | |||
96 | if not parser: |
||
97 | parser = create_parser(name) |
||
98 | args = parser.parse_arguments() |
||
99 | |||
100 | if args.version: |
||
101 | args.foreground = True |
||
102 | |||
103 | init_logging( |
||
104 | args.log_level, |
||
105 | log_file=args.log_file, |
||
106 | log_config=args.log_config, |
||
107 | foreground=args.foreground, |
||
108 | ) |
||
109 | |||
110 | if args.port == 0: |
||
111 | server = UnixSocketServer( |
||
112 | args.unix_socket, args.socket_mode, args.stream_timeout, |
||
113 | ) |
||
114 | else: |
||
115 | server = TlsServer( |
||
116 | args.address, |
||
117 | args.port, |
||
118 | args.cert_file, |
||
119 | args.key_file, |
||
120 | args.ca_file, |
||
121 | args.stream_timeout, |
||
122 | ) |
||
123 | |||
124 | daemon = daemon_class(**vars(args)) |
||
125 | |||
126 | if args.version: |
||
127 | print_version(daemon) |
||
128 | sys.exit() |
||
129 | |||
130 | if args.list_commands: |
||
131 | print(daemon.get_help_text()) |
||
132 | sys.exit() |
||
133 | |||
134 | if not args.foreground: |
||
135 | go_to_background() |
||
136 | |||
137 | if not create_pid(args.pid_file): |
||
138 | sys.exit() |
||
139 | |||
140 | # Set signal handler and cleanup |
||
141 | atexit.register( |
||
142 | exit_cleanup, pidfile=args.pid_file, server=server, daemon=daemon |
||
143 | ) |
||
144 | signal.signal( |
||
145 | signal.SIGTERM, partial(exit_cleanup, args.pid_file, server, daemon) |
||
146 | ) |
||
147 | |||
148 | if not daemon.check(): |
||
149 | return 1 |
||
150 | |||
151 | LOGGER.info( |
||
152 | "Starting %s version %s.", |
||
153 | daemon.daemon_info['name'], |
||
154 | daemon.daemon_info['version'], |
||
155 | ) |
||
156 | |||
157 | daemon.init(server) |
||
158 | daemon.run() |
||
159 | |||
160 | return 0 |
||
161 |