Code Duplication    Length = 35-35 lines in 2 locations

gmp/xml.py 2 locations

@@ 1127-1161 (lines=35) @@
1124
1125
        return etree.tostring(xmlRoot).decode('utf-8')
1126
1127
    def modify_filter_command(self, filter_id, kwargs):
1128
        if not filter_id:
1129
            raise ValueError('modify_filter requires a filter_id attribute')
1130
1131
        xmlRoot = etree.Element('modify_filter', filter_id=filter_id)
1132
1133
        comment = kwargs.get('comment', '')
1134
        if comment:
1135
            _xmlComment = etree.SubElement(xmlRoot, 'comment')
1136
            _xmlComment.text = comment
1137
1138
        name = kwargs.get('name', '')
1139
        if name:
1140
            _xmlName = etree.SubElement(xmlRoot, 'name')
1141
            _xmlName.text = name
1142
1143
        copy = kwargs.get('copy', '')
1144
        if copy:
1145
            _xmlCopy = etree.SubElement(xmlRoot, 'copy')
1146
            _xmlCopy.text = copy
1147
1148
        term = kwargs.get('term', '')
1149
        if term:
1150
            _xmlTerm = etree.SubElement(xmlRoot, 'term')
1151
            _xmlTerm.text = term
1152
1153
        filter_type = kwargs.get('type', '')
1154
        if filter_type:
1155
            if filter_type not in ('cc', 'snmp', 'up', 'usk'):
1156
                raise ValueError('modify_filter requires type '
1157
                                 'to be either cc, snmp, up or usk')
1158
            _xmlFiltertype = etree.SubElement(xmlRoot, 'type')
1159
            _xmlFiltertype.text = filter_type
1160
1161
        return etree.tostring(xmlRoot).decode('utf-8')
1162
1163
    def modify_group_command(self, group_id, kwargs):
1164
        if not group_id:
@@ 268-302 (lines=35) @@
265
266
        return etree.tostring(xmlRoot).decode('utf-8')
267
268
    def create_filter_command(self, name, make_unique, kwargs):
269
270
        xmlRoot = etree.Element('create_filter')
271
        _xmlName = etree.SubElement(xmlRoot, 'name')
272
        _xmlName.text = name
273
        _xmlUnique = etree.SubElement(_xmlName, 'make_unique')
274
        if make_unique:
275
            _xmlUnique.text = '1'
276
        else:
277
            _xmlUnique.text = '0'
278
279
        comment = kwargs.get('comment', '')
280
        if comment:
281
            _xmlComment = etree.SubElement(xmlRoot, 'comment')
282
            _xmlComment.text = comment
283
284
        copy = kwargs.get('copy', '')
285
        if copy:
286
            _xmlCopy = etree.SubElement(xmlRoot, 'copy')
287
            _xmlCopy.text = copy
288
289
        term = kwargs.get('term', '')
290
        if term:
291
            _xmlTerm = etree.SubElement(xmlRoot, 'term')
292
            _xmlTerm.text = term
293
294
        filter_type = kwargs.get('type', '')
295
        if filter_type:
296
            if filter_type not in FILTER_NAMES:
297
                raise ValueError('create_filter requires type '
298
                                 'to be either cc, snmp, up or usk')
299
            _xmlFiltertype = etree.SubElement(xmlRoot, 'type')
300
            _xmlFiltertype.text = filter_type
301
302
        return etree.tostring(xmlRoot).decode('utf-8')
303
304
    def create_group_command(self, name, kwargs):
305