Code Duplication    Length = 35-35 lines in 2 locations

gmp/xml.py 2 locations

@@ 1132-1166 (lines=35) @@
1129
1130
        return etree.tostring(xmlRoot).decode('utf-8')
1131
1132
    def modify_filter_command(self, filter_id, kwargs):
1133
        if not filter_id:
1134
            raise ValueError('modify_filter requires a filter_id attribute')
1135
1136
        xmlRoot = etree.Element('modify_filter', filter_id=filter_id)
1137
1138
        comment = kwargs.get('comment', '')
1139
        if comment:
1140
            _xmlComment = etree.SubElement(xmlRoot, 'comment')
1141
            _xmlComment.text = comment
1142
1143
        name = kwargs.get('name', '')
1144
        if name:
1145
            _xmlName = etree.SubElement(xmlRoot, 'name')
1146
            _xmlName.text = name
1147
1148
        copy = kwargs.get('copy', '')
1149
        if copy:
1150
            _xmlCopy = etree.SubElement(xmlRoot, 'copy')
1151
            _xmlCopy.text = copy
1152
1153
        term = kwargs.get('term', '')
1154
        if term:
1155
            _xmlTerm = etree.SubElement(xmlRoot, 'term')
1156
            _xmlTerm.text = term
1157
1158
        filter_type = kwargs.get('type', '')
1159
        if filter_type:
1160
            if filter_type not in ('cc', 'snmp', 'up', 'usk'):
1161
                raise ValueError('modify_filter requires type '
1162
                                 'to be either cc, snmp, up or usk')
1163
            _xmlFiltertype = etree.SubElement(xmlRoot, 'type')
1164
            _xmlFiltertype.text = filter_type
1165
1166
        return etree.tostring(xmlRoot).decode('utf-8')
1167
1168
    def modify_group_command(self, group_id, kwargs):
1169
        if not group_id:
@@ 273-307 (lines=35) @@
270
271
        return etree.tostring(xmlRoot).decode('utf-8')
272
273
    def create_filter_command(self, name, make_unique, kwargs):
274
275
        xmlRoot = etree.Element('create_filter')
276
        _xmlName = etree.SubElement(xmlRoot, 'name')
277
        _xmlName.text = name
278
        _xmlUnique = etree.SubElement(_xmlName, 'make_unique')
279
        if make_unique:
280
            _xmlUnique.text = '1'
281
        else:
282
            _xmlUnique.text = '0'
283
284
        comment = kwargs.get('comment', '')
285
        if comment:
286
            _xmlComment = etree.SubElement(xmlRoot, 'comment')
287
            _xmlComment.text = comment
288
289
        copy = kwargs.get('copy', '')
290
        if copy:
291
            _xmlCopy = etree.SubElement(xmlRoot, 'copy')
292
            _xmlCopy.text = copy
293
294
        term = kwargs.get('term', '')
295
        if term:
296
            _xmlTerm = etree.SubElement(xmlRoot, 'term')
297
            _xmlTerm.text = term
298
299
        filter_type = kwargs.get('type', '')
300
        if filter_type:
301
            if filter_type not in FILTER_NAMES:
302
                raise ValueError('create_filter requires type '
303
                                 'to be either cc, snmp, up or usk')
304
            _xmlFiltertype = etree.SubElement(xmlRoot, 'type')
305
            _xmlFiltertype.text = filter_type
306
307
        return etree.tostring(xmlRoot).decode('utf-8')
308
309
    def create_group_command(self, name, kwargs):
310