Conditions | 2 |
Total Lines | 58 |
Code Lines | 21 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | # -*- coding: utf-8 -*- |
||
35 | @patch('builtins.input', lambda *args: 'y') |
||
36 | @patch('gvm.protocols.latest.Gmp', new_callable=GmpMockFactory) |
||
37 | def test_sent_task(self, mock_gmp: GmpMockFactory): |
||
38 | task_xml_path = CWD / 'example_task.xml' |
||
39 | task_xml_str = task_xml_path.read_text() |
||
40 | |||
41 | self.send_tasks.numerical_option = MagicMock(return_value=1) |
||
42 | |||
43 | configs_file = CWD / 'get_configs.xml' |
||
44 | configs = configs_file.read_text() |
||
45 | mock_gmp.mock_response('get_configs', configs) |
||
46 | |||
47 | mock_gmp.mock_response( |
||
48 | 'get_scanners', |
||
49 | '<get_scanners_response status="200" status_text="OK">' |
||
50 | '<scanner id="c1c85af7-0cca-4690-8ccc-c79feb5588cf">' |
||
51 | '<name>as</name>' |
||
52 | '</scanner>' |
||
53 | '<scanner id="6acd0832-df90-11e4-b9d5-28d24461215b">' |
||
54 | '<name>CVE</name>' |
||
55 | '</scanner>' |
||
56 | '<scanner id="08b69003-5fc2-4037-a479-93b440211c73">' |
||
57 | '<name>OpenVAS Default</name>' |
||
58 | '</scanner>' |
||
59 | '</get_scanners_response>', |
||
60 | ) |
||
61 | |||
62 | mock_gmp.mock_response( |
||
63 | 'get_targets', |
||
64 | '<get_targets_response status="200" status_text="OK">' |
||
65 | '<target id="60f95d0e-029e-4931-a13a-b1d11260517d">' |
||
66 | '<name>own</name>' |
||
67 | '</target>' |
||
68 | '<target id="ead9576c-5a4d-4081-b98d-ccd77d5d16f8">' |
||
69 | '<name>Target for xn</name>' |
||
70 | '</target>' |
||
71 | '<target id="6c9f73f5-f14c-42bf-ab44-edb8d2493dbc">' |
||
72 | '<name>Unnamed</name>' |
||
73 | '</target>' |
||
74 | '<target id="a1f478c1-27d0-4d8c-959f-150625186421">' |
||
75 | '<name>work</name>' |
||
76 | '</target>' |
||
77 | '<target id="5ca97fe1-694d-4e4a-bd4c-55529719d17e">' |
||
78 | '<name>work2</name>' |
||
79 | '</target>' |
||
80 | '</get_targets_response>', |
||
81 | ) |
||
82 | |||
83 | mock_gmp.mock_response( |
||
84 | 'create_task', |
||
85 | '<create_task_response status="201" status_text="OK,' |
||
86 | 'resource created" id="c8ef0597-e2c1-4e23-869f-072fa2914bf2"/>', |
||
87 | ) |
||
88 | |||
89 | task = etree.XML(task_xml_str) |
||
90 | |||
91 | tasks = self.send_tasks.parse_send_xml_tree(mock_gmp.gmp_protocol, task) |
||
92 | self.assertEqual(tasks, ['c8ef0597-e2c1-4e23-869f-072fa2914bf2']) |
||
93 |