polarpy.polar_response

Complexity

Total Complexity

13

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	PolarResponse.__init__()	0	5	1
A	PolarResponse.ene_hi()	0	3	1
A	PolarResponse.scattering_bins()	0	3	1
A	PolarResponse.scattering_bins_hi()	0	3	1
A	PolarResponse.interpolators()	0	3	1
A	PolarResponse.n_scattering_bins()	0	3	1
A	PolarResponse.ene_lo()	0	3	1
A	PolarResponse._interpolate_rsp()	0	60	4
A	PolarResponse.energy_mid()	0	3	1
A	PolarResponse.scattering_bins_lo()	0	3	1

import numpy as np

This module should have a docstring.

Unable to import 'numpy'

import h5py

Unable to import 'h5py'

import scipy.interpolate as interpolate

Unable to import 'scipy.interpolate'

class PolarResponse(object):

This class should have a docstring.

Too many instance attributes (9/7)

The variable __class__ seems to be unused.

    def __init__(self, response_file):

        self._rsp_file = response_file

        self._interpolate_rsp()

    # def _get_hist(self, ene,degree,angle):


    #     with h5py.File(self._rsp_file,'r') as f:



    #        # bins = np.array(f['bins'].value)

    #     return  tmp


    def _interpolate_rsp(self):
        """
        Builds the interpolator for the response. This is currently incredibly slow
        and should be improved

        """

        

Trailing whitespace

        # create a functions to get the histograms
        

Trailing whitespace

Trailing whitespace

        # now go through the response and extract things
        

Trailing whitespace

        with h5py.File(self._rsp_file,'r') as f:

Exactly one space required after comma

The name f does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

Trailing whitespace

Trailing whitespace

Trailing whitespace

            energy = f['energy'].value
            

Trailing whitespace

            ene_lo, ene_hi = [],[]

Exactly one space required after comma

            for ene in energy:

                ene_lo.append(ene-2.5)
                ene_hi.append(ene+2.5)
            

Trailing whitespace

Trailing whitespace

            pol_ang = np.array(f['pol_ang'].value)
        

Trailing whitespace

            pol_deg = np.array(f['pol_deg'].value)
        

Trailing whitespace

Trailing whitespace

            bins = np.array(f['bins'].value)

            

Trailing whitespace

            bin_center = 0.5 *(bins[:-1] + bins[1:])

            all_interp = []



            for i, bm in enumerate(bin_center):

The name bm does not conform to the variable naming conventions ((([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$).

The variable bm seems to be unused.

                this_interpolator = interpolate.RegularGridInterpolator((energy,pol_ang,pol_deg), f['matrix'][...,i])

This line is too long as per the coding-style (117/100).

Exactly one space required after comma

                all_interp.append(this_interpolator)
                

Trailing whitespace

            self._all_interp = all_interp
            

Trailing whitespace

            self._ene_lo = ene_lo
            self._ene_hi = ene_hi
            self._energy_mid = energy
            

Trailing whitespace

            self._n_scatter_bins = len(bin_center)
            self._scattering_bins = bin_center
            self._scattering_bins_lo = bins[:-1]
            self._scattering_bins_hi = bins[1:]


    @property
    def ene_lo(self):

This method should have a docstring.

        return self._ene_lo

    @property
    def ene_hi(self):

This method should have a docstring.

        return self._ene_hi

    @property
    def energy_mid(self):

This method should have a docstring.

        return self._energy_mid

    @property
    def n_scattering_bins(self):

This method should have a docstring.

        return self._n_scatter_bins

    @property
    def scattering_bins(self):

This method should have a docstring.

        return self._scattering_bins

    @property
    def scattering_bins_lo(self):

This method should have a docstring.

        return self._scattering_bins_lo

    @property
    def scattering_bins_hi(self):

This method should have a docstring.

        return self._scattering_bins_hi

    @property
    def interpolators(self):

This method should have a docstring.

        return self._all_interp
        

Trailing whitespace