AbstractResponse::__construct() - Code Metrics - Inspection of "Set read timeout" - graze/wipotec-checkweigher-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

by Brendan

created 2020-07-01 02:00 UTC

AbstractResponse::__construct() A

↳ Parent: AbstractResponse

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	8.2515

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
eloc	14
c	2
b	0
f	0
dl	0
loc	23
ccs	5
cts	14
cp	0.357
rs	9.7998
cc	4
nc	4
nop	1
crap	8.2515

<?php

namespace Graze\WipotecCheckweigherClient\Response;

use Exception;
use Graze\TelnetClient\TelnetResponseInterface;
use Graze\XmlUtils\XmlConverter;
use SimpleXMLElement;

class AbstractResponse implements ResponseInterface
{
    /** @var mixed[] */
    private $contents;

    /** @var string */
    private $error;

    /**
     * @param TelnetResponseInterface $telnetResponse
     */
    public function __construct(TelnetResponseInterface $telnetResponse)
    {
        try {
            $xml = @new SimpleXMLElement($telnetResponse->getResponseText(), 0, false, 'cw', true);
        } catch (Exception $e) {
            $this->setError($e->getMessage());
            return;
        }

        $xmlConverter = new XmlConverter();
        $this->contents = $xmlConverter->convertToArray($xml);

        if ($telnetResponse->isError()) {
            $error = 'unknown';
            if (isset($this->contents['error_info']['error_text'])) {
                $error = $this->contents['error_info']['error_text'];
            }

            $this->setError('Telnet response error: '.$error);
            return;
        }

        $this->parseContents($this->contents);
    }

    /**
     * @param string $error
     */
    private function setError($error)
    {
        $this->error = $error;
    }

    /**
     * Whether an error was returned.
     *
     * @return bool
     */
    public function hasError()
    {
        return (bool)$this->error;
    }

    /**
     * Get the error message.
     *
     * @return string
     */
    public function getError()
    {
        return $this->error;
    }

    /**
     * Extract specific information from the raw contents array for easier access.
     *
     * @param mixed[] $contents
     */
    protected function parseContents(array $contents)
    protected function parseContents(/** @scrutinizer ignore-unused */ array $contents)
    {
    }

    /**
     * Get the raw response as an array.
     *
     * @return mixed[]
     */
    public function getContents()
    {
        return $this->contents;
    }
}


graze / wipotec-checkweigher-client

Pull Request — master (#3)

AbstractResponse::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like