SerialiserBoxItem::serialise() - Code Metrics - Inspection of "Merge pull request #1 from graze/functioning-clien..." - graze/unicontroller-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 411d94...8fae9a )

by John

created 2016-11-16 22:49 UTC

SerialiserBoxItem::serialise() A

↳ Parent: SerialiserBoxItem

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
ccs	13
cts	13
cp	1
cc	1
eloc	13
nc	1
nop	1
crap	1

<?php
/**
 * This file is part of graze/unicontroller-client.
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/unicontroller-client/blob/master/LICENSE.md
 * @link https://github.com/graze/unicontroller-client
 */
namespace Graze\UnicontrollerClient\Serialiser\Serialiser;

use Graze\UnicontrollerClient\Serialiser\Serialiser\AbstractSerialiser;
use Graze\UnicontrollerClient\Serialiser\Serialiser\SerialiserInterface;
use Graze\UnicontrollerClient\Entity\Entity\EntityInterface;

class SerialiserBoxItem extends AbstractSerialiser implements SerialiserInterface
{
    /**
     * @param EntityInterface $entity
     * @return string
     */
    public function serialise(EntityInterface $entity)
    {
        $properties = [];
        $properties[] = $entity->getAnchorPoint();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getXPos();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getYPos();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getWidth();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getHeight();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getOrion();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $this->stringEscaper->escape($entity->getDescription());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getThickness();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getArc();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $properties[] = $entity->getPhantomField();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return implode(',', $properties);
    }
}


Push — master ( 411d94...8fae9a )

SerialiserBoxItem::serialise() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/**
3		* This file is part of graze/unicontroller-client.
4		*
5		* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @license https://github.com/graze/unicontroller-client/blob/master/LICENSE.md
11		* @link https://github.com/graze/unicontroller-client
12		*/
13		namespace Graze\UnicontrollerClient\Serialiser\Serialiser;
14
15		use Graze\UnicontrollerClient\Serialiser\Serialiser\AbstractSerialiser;
16		use Graze\UnicontrollerClient\Serialiser\Serialiser\SerialiserInterface;
17		use Graze\UnicontrollerClient\Entity\Entity\EntityInterface;
18
19		class SerialiserBoxItem extends AbstractSerialiser implements SerialiserInterface
20		{
21		/**
22		* @param EntityInterface $entity
23		* @return string
24		*/
25	1	public function serialise(EntityInterface $entity)
26		{
27	1	$properties = [];
28	1	$properties[] = $entity->getAnchorPoint();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getAnchorPoint()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ntity\EntityBarcodeItem`, `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
29	1	$properties[] = $entity->getXPos();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getXPos()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ntity\EntityBarcodeItem`, `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
30	1	$properties[] = $entity->getYPos();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getYPos()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ntity\EntityBarcodeItem`, `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
31	1	$properties[] = $entity->getWidth();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getWidth()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...Entity\EntityReadDesign`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
32	1	$properties[] = $entity->getHeight();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getHeight()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ntity\EntityBarcodeItem`, `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...Entity\EntityReadDesign`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
33	1	$properties[] = $entity->getOrion();
		0 ignored issues – show Bug introduced 2016-11-16 17:14 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Graze\UnicontrollerClien...\Entity\EntityInterface` as the method `getOrion()` does only exist in the following implementations of said interface: `Graze\UnicontrollerClien...ntity\EntityBarcodeItem`, `Graze\UnicontrollerClien...ty\Entity\EntityBoxItem`, `Graze\UnicontrollerClien...y\Entity\EntityLineItem`, `Graze\UnicontrollerClien...ntity\EntityPictureItem`, `Graze\UnicontrollerClien...ty\Entity\EntityTtfItem`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
34	1	$properties[] = $this->stringEscaper->escape($entity->getDescription());

graze / unicontroller-client

Push — master ( 411d94...8fae9a )

SerialiserBoxItem::serialise() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like