ParserShiftDefinition   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 28
Duplicated Lines 0 %

Test Coverage

Coverage 100%

Importance

Changes 1
Bugs 0 Features 0
Metric Value
eloc 14
c 1
b 0
f 0
dl 0
loc 28
ccs 14
cts 14
cp 1
rs 10
wmc 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getEntity() 0 3 1
A getProperties() 0 14 1
1
<?php
2
/**
3
 * This file is part of graze/unicontroller-client.
4
 *
5
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6
 *
7
 * For the full copyright and license information, please view the LICENSE
8
 * file that was distributed with this source code.
9
 *
10
 * @license https://github.com/graze/unicontroller-client/blob/master/LICENSE.md
11
 * @link https://github.com/graze/unicontroller-client
12
 */
13
namespace Graze\UnicontrollerClient\Parser\Parser;
14
15
use Graze\UnicontrollerClient\Parser\Parser\AbstractParser;
16
use Graze\UnicontrollerClient\Parser\Parser\ParserInterface;
17
use Graze\UnicontrollerClient\Entity\Entity\EntityShiftDefinition;
18
19
class ParserShiftDefinition extends AbstractParser implements ParserInterface
20
{
21
    /**
22
     * @return []
0 ignored issues
show
Documentation Bug introduced by
The doc comment [] at position 0 could not be parsed: Unknown type name '[' at position 0 in [].
Loading history...
23
     */
24 2
    protected function getProperties()
25
    {
26
        return [
27 2
            'fromDay',
28 2
            'fromHour',
29 2
            'fromMinutte',
30 2
            'toDay',
31 2
            'toHour',
32 2
            'toMinutte',
33 2
            'shiftText',
34 2
            'fromDay2',
35 2
            'toDay2',
36 2
            'from',
37
            'to'
38 2
        ];
39
    }
40
41
    /**
42
     * @return EntityShiftDefinition
43
     */
44 2
    protected function getEntity()
45
    {
46 2
        return new EntityShiftDefinition();
0 ignored issues
show
Bug Best Practice introduced by
The expression return new Graze\Unicont...EntityShiftDefinition() returns the type Graze\UnicontrollerClien...y\EntityShiftDefinition which is incompatible with the return type mandated by Graze\UnicontrollerClien...ractParser::getEntity() of Graze\UnicontrollerClien...\Entity\EntityInterface.

In the issue above, the returned value is violating the contract defined by the mentioned interface.

Let's take a look at an example:

interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
Loading history...
47
    }
48
}
49