Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | View Code Duplication | class FailedEnqueueExceptionTest extends TestCase |
|
|
|||
26 | { |
||
27 | /** @var AdapterInterface|MockInterface */ |
||
28 | private $adapter; |
||
29 | /** @var array */ |
||
30 | private $debug; |
||
31 | /** @var MessageInterface[]|MockInterface[] */ |
||
32 | private $messages; |
||
33 | /** @var Exception */ |
||
34 | private $previous; |
||
35 | /** @var FailedEnqueueException */ |
||
36 | private $exception; |
||
37 | |||
38 | public function setUp() |
||
51 | |||
52 | public function testInterface() |
||
56 | |||
57 | public function testGetAdapter() |
||
61 | |||
62 | public function testGetDebug() |
||
66 | |||
67 | public function testGetMessages() |
||
71 | |||
72 | public function testGetPrevious() |
||
76 | } |
||
77 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.