MethodNotSupportedExceptionTest::testGetMethod() - Code Metrics - Inspection of "use new make file" - graze/queue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#40)

by Harry

created 2017-03-20 18:01 UTC

MethodNotSupportedExceptionTest::testGetMethod() A

↳ Parent: MethodNotSupportedExceptionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/**
 * This file is part of graze/queue.
 *
 * Copyright (c) 2015 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/queue/blob/master/LICENSE MIT
 *
 * @link    https://github.com/graze/queue
 */

namespace Graze\Queue\Adapter\Exception;

use Exception;
use Graze\Queue\Adapter\AdapterInterface;
use Graze\Queue\Message\MessageInterface;
use Mockery as m;
use Mockery\MockInterface;
use PHPUnit_Framework_TestCase as TestCase;

class MethodNotSupportedExceptionTest extends TestCase
{
    /** @var AdapterInterface|MockInterface */
    private $adapter;
    /** @var array */
    private $debug;
    /** @var MessageInterface[]|MockInterface[] */
    private $messages;
    /** @var Exception */
    private $previous;
    /** @var MethodNotSupportedException */
    private $exception;

    public function setUp()
    {
        $this->adapter = m::mock(AdapterInterface::class);
        $this->debug = ['foo' => 'bar'];

        $a = m::mock(MessageInterface::class);

        $b = m::mock(MessageInterface::class);

        $c = m::mock(MessageInterface::class);

        $this->messages = [$a, $b, $c];

        $this->previous = new Exception();

        $this->exception = new MethodNotSupportedException(
            'method',
            $this->adapter,
            $this->messages,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->debug,
            $this->previous);
    }

    public function testInterface()
    {
        assertThat($this->exception, is(anInstanceOf(AdapterException::class)));
    }

    public function testGetMethod()
    {
        assertThat($this->exception->getMethod(), is(identicalTo('method')));
    }

    public function testGetAdapter()
    {
        assertThat($this->exception->getAdapter(), is(identicalTo($this->adapter)));
    }

    public function testGetDebug()
    {
        assertThat($this->exception->getDebug(), is(identicalTo($this->debug)));
    }

    public function testGetMessages()
    {
        assertThat($this->exception->getMessages(), is(identicalTo($this->messages)));
    }

    public function testGetPrevious()
    {
        assertThat($this->exception->getPrevious(), is(identicalTo($this->previous)));
    }
}


1			<?php
2
3			/**
4			* This file is part of graze/queue.
5			*
6			* Copyright (c) 2015 Nature Delivered Ltd. <https://www.graze.com>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*
11			* @license https://github.com/graze/queue/blob/master/LICENSE MIT
12			*
13			* @link https://github.com/graze/queue
14			*/
15
16			namespace Graze\Queue\Adapter\Exception;
17
18			use Exception;
19			use Graze\Queue\Adapter\AdapterInterface;
20			use Graze\Queue\Message\MessageInterface;
21			use Mockery as m;
22			use Mockery\MockInterface;
23			use PHPUnit_Framework_TestCase as TestCase;
24
25			class MethodNotSupportedExceptionTest extends TestCase
26			{
27			/** @var AdapterInterface\|MockInterface */
28			private $adapter;
29			/** @var array */
30			private $debug;
31			/** @var MessageInterface[]\|MockInterface[] */
32			private $messages;
33			/** @var Exception */
34			private $previous;
35			/** @var MethodNotSupportedException */
36			private $exception;
37
38			public function setUp()
39			{
40			$this->adapter = m::mock(AdapterInterface::class);
41			$this->debug = ['foo' => 'bar'];
42
43			$a = m::mock(MessageInterface::class);
			0 ignored issues – show Comprehensibility introduced 2017-03-20 18:12 UTC by Report Bug Copy Issue Report Avoid variables with short names like $a. Configured minimum length is 2. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
44			$b = m::mock(MessageInterface::class);
			0 ignored issues – show Comprehensibility introduced 2017-03-20 18:12 UTC by Report Bug Copy Issue Report Avoid variables with short names like $b. Configured minimum length is 2. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
45			$c = m::mock(MessageInterface::class);
			0 ignored issues – show Comprehensibility introduced 2017-03-20 18:12 UTC by Report Bug Copy Issue Report Avoid variables with short names like $c. Configured minimum length is 2. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
46			$this->messages = [$a, $b, $c];
47
48			$this->previous = new Exception();
49
50			$this->exception = new MethodNotSupportedException(
51			'method',
52			$this->adapter,
53			$this->messages,
			0 ignored issues – show Documentation introduced 2017-03-20 18:12 UTC by Report Bug Copy Issue Report `$this->messages` is of type `array<integer,object<Moc...kery\\MockInterface>"}>`, but the function expects a `array<integer,object<Gra...sage\MessageInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
54			$this->debug,
55			$this->previous);
56			}
57
58			public function testInterface()
59			{
60			assertThat($this->exception, is(anInstanceOf(AdapterException::class)));
61			}
62
63			public function testGetMethod()
64			{
65			assertThat($this->exception->getMethod(), is(identicalTo('method')));
66			}
67
68			public function testGetAdapter()
69			{
70			assertThat($this->exception->getAdapter(), is(identicalTo($this->adapter)));
71			}
72
73			public function testGetDebug()
74			{
75			assertThat($this->exception->getDebug(), is(identicalTo($this->debug)));
76			}
77
78			public function testGetMessages()
79			{
80			assertThat($this->exception->getMessages(), is(identicalTo($this->messages)));
81			}
82
83			public function testGetPrevious()
84			{
85			assertThat($this->exception->getPrevious(), is(identicalTo($this->previous)));
86			}
87			}
88

graze / queue

Pull Request — master (#40)

MethodNotSupportedExceptionTest::testGetMethod() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like