TestCase::compareOutputs() - Code Metrics - Inspection of "Write all the output from each process to the scre..." - graze/parallel-process - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

by Harry

created 2017-10-06 12:11 UTC

TestCase::compareOutputs() A

↳ Parent: TestCase

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	2

<?php

/**
 * This file is part of graze/parallel-process.
 *
 * Copyright (c) 2017 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/parallel-process/blob/master/LICENSE.md
 * @link    https://github.com/graze/parallel-process
 */

namespace Graze\ParallelProcess\Test;

class TestCase extends \PHPUnit_Framework_TestCase
{
    /**
     * Compare the outputs with an expected input.
     *
     * Each element in the array is a call to `write/writeln/reWrite`
     * Each element in the child array is a line to be written
     *
     * @param string[][] $expected Set of regular expressions to match against
     * @param string[][] $actual   The actual output
     */
    protected function compareOutputs(array $expected, array $actual)
    {
        $this->assertSameSize($expected, $actual);

        for ($i = 0; $i < count($expected); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $this->assertSameSize($expected[$i], $actual[$i]);
            for ($j = 0; $j < count($expected[$i]); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                $this->assertRegExp($expected[$i][$j], $actual[$i][$j], sprintf('group: %d, line: %d', $i + 1, $j + 1));
            }
        }
    }
}


1			<?php
2
3			/**
4			* This file is part of graze/parallel-process.
5			*
6			* Copyright (c) 2017 Nature Delivered Ltd. <https://www.graze.com>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*
11			* @license https://github.com/graze/parallel-process/blob/master/LICENSE.md
12			* @link https://github.com/graze/parallel-process
13			*/
14
15			namespace Graze\ParallelProcess\Test;
16
17			class TestCase extends \PHPUnit_Framework_TestCase
18			{
19			/**
20			* Compare the outputs with an expected input.
21			*
22			* Each element in the array is a call to `write/writeln/reWrite`
23			* Each element in the child array is a line to be written
24			*
25			* @param string[][] $expected Set of regular expressions to match against
26			* @param string[][] $actual The actual output
27			*/
28			protected function compareOutputs(array $expected, array $actual)
29			{
30			$this->assertSameSize($expected, $actual);
31
32			for ($i = 0; $i < count($expected); $i++) {
			0 ignored issues – show Performance Best Practice introduced 2017-10-06 11:26 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
33			$this->assertSameSize($expected[$i], $actual[$i]);
34			for ($j = 0; $j < count($expected[$i]); $j++) {
			0 ignored issues – show Performance Best Practice introduced 2017-10-06 11:26 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
35			$this->assertRegExp($expected[$i][$j], $actual[$i][$j], sprintf('group: %d, line: %d', $i + 1, $j + 1));
36			}
37			}
38			}
39			}
40

graze / parallel-process

Pull Request — master (#12)

TestCase::compareOutputs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like