Graze\ParallelProcess\PrioritisedTrait::setPriority()

Complexity

Conditions	5
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5

Importance

Changes

0

<?php
    public function setPriority($priority)
    {
        $oldPriority = $this->priority;
        $this->priority = $priority;
        if (!($this instanceof RunInterface && $this->hasStarted())
            && $this instanceof DispatcherInterface
            && $this instanceof PrioritisedInterface) {
            $this->dispatch(PriorityChangedEvent::CHANGED, new PriorityChangedEvent($this, $priority, $oldPriority));

It seems like dispatch() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method dispatch() does not exist on Graze\ParallelProcess\Event\DispatcherInterface. It seems like you code against a sub-type of said class. However, the method does not exist in Graze\ParallelProcess\RunInterface or Graze\ParallelProcess\PoolInterface. Are you sure you never get one of those?

The method dispatch() does not exist on Graze\ParallelProcess\PrioritisedInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Graze\ParallelProcess\PrioritisedInterface.

        }
        return $this;
    }