Conditions | 1 |
Paths | 1 |
Total Lines | 69 |
Code Lines | 51 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
34 | public function parseProvider() |
||
35 | { |
||
36 | return [ |
||
37 | // [ type, text, constraint, expected ] |
||
38 | ["PRIMARY KEY", "(a)", null, "PRIMARY KEY (`a`)"], |
||
39 | |||
40 | ["UNIQUE KEY", "(a)", null, "UNIQUE KEY `k1` (`a`)"], |
||
41 | ["UNIQUE KEY", "k (a)", null, "UNIQUE KEY `k` (`a`)"], |
||
42 | ["UNIQUE KEY", "(a)", 'foo', "UNIQUE KEY `foo` (`a`)"], |
||
43 | |||
44 | ["FULLTEXT KEY", "(a)", null, "FULLTEXT KEY `k1` (`a`)"], |
||
45 | ["FULLTEXT KEY", "k (a)", null, "FULLTEXT KEY `k` (`a`)"], |
||
46 | ["FULLTEXT KEY", "(a) WITH PARSER foo_parser", null, "FULLTEXT KEY `k1` (`a`) WITH PARSER foo_parser"], |
||
47 | |||
48 | ["KEY", "(a)", null, "KEY `k1` (`a`)"], |
||
49 | ["KEY", "(a ASC)", null, "KEY `k1` (`a`)"], |
||
50 | ["KEY", "(a DESC)", null, "KEY `k1` (`a`)"], |
||
51 | ["KEY", "k (a)", null, "KEY `k` (`a`)"], |
||
52 | ["KEY", "(a,b,c)", null, "KEY `k1` (`a`,`b`,`c`)"], |
||
53 | ["KEY", "(a,b,c)", null, "KEY `k1` (`a`,`b`,`c`)"], |
||
54 | ["KEY", "(a(10))", null, "KEY `k1` (`a`(10))"], |
||
55 | ["KEY", "(a(10),b(12))", null, "KEY `k1` (`a`(10),`b`(12))"], |
||
56 | ["KEY", "USING BTREE (a)", null, "KEY `k1` (`a`) USING BTREE"], |
||
57 | ["KEY", "k USING BTREE (a)", null, "KEY `k` (`a`) USING BTREE"], |
||
58 | ["KEY", "(a) USING BTREE", null, "KEY `k1` (`a`) USING BTREE"], |
||
59 | ["KEY", "(a) USING HASH", null, "KEY `k1` (`a`) USING HASH"], |
||
60 | ["KEY", "(a) KEY_BLOCK_SIZE 10", null, "KEY `k1` (`a`) KEY_BLOCK_SIZE=10"], |
||
61 | ["KEY", "(a) KEY_BLOCK_SIZE=10", null, "KEY `k1` (`a`) KEY_BLOCK_SIZE=10"], |
||
62 | ["KEY", "(a) KEY_BLOCK_SIZE=0", null, "KEY `k1` (`a`)"], |
||
63 | ["KEY", "(a) COMMENT 'foo'", null, "KEY `k1` (`a`) COMMENT 'foo'"], |
||
64 | ["KEY", "(a) COMMENT ''", null, "KEY `k1` (`a`)"], |
||
65 | ["KEY", "(a) COMMENT 'foo' USING BTREE KEY_BLOCK_SIZE=10", null, |
||
66 | "KEY `k1` (`a`) USING BTREE KEY_BLOCK_SIZE=10 COMMENT 'foo'"], |
||
67 | |||
68 | ["FOREIGN KEY", "(a) REFERENCES t(ta)", "c1", |
||
69 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`)"], |
||
70 | |||
71 | ["FOREIGN KEY", "(a) REFERENCES foo.t(ta)", "c1", |
||
72 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `foo`.`t` (`ta`)"], |
||
73 | |||
74 | ["FOREIGN KEY", "(a) REFERENCES t(ta(10))", "c1", |
||
75 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`(10))"], |
||
76 | |||
77 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON DELETE RESTRICT", "c1", |
||
78 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`)"], |
||
79 | |||
80 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON DELETE CASCADE", "c1", |
||
81 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON DELETE CASCADE"], |
||
82 | |||
83 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON DELETE NO ACTION", "c1", |
||
84 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON DELETE NO ACTION"], |
||
85 | |||
86 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON DELETE SET NULL", "c1", |
||
87 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON DELETE SET NULL"], |
||
88 | |||
89 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON UPDATE RESTRICT", "c1", |
||
90 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`)"], |
||
91 | |||
92 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON UPDATE CASCADE", "c1", |
||
93 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON UPDATE CASCADE"], |
||
94 | |||
95 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON UPDATE NO ACTION", "c1", |
||
96 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON UPDATE NO ACTION"], |
||
97 | |||
98 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON UPDATE SET NULL", "c1", |
||
99 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON UPDATE SET NULL"], |
||
100 | |||
101 | ["FOREIGN KEY", "(a) REFERENCES t(ta) ON UPDATE NO ACTION ON DELETE NO ACTION", "c1", |
||
102 | "CONSTRAINT `c1` FOREIGN KEY (`a`) REFERENCES `t` (`ta`) ON DELETE NO ACTION ON UPDATE NO ACTION"], |
||
103 | |||
202 |