Graze\Monolog\LoggerBuilderIntegrationTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	testBuild()	0	7	1
A	assertDefaultHandlers()	0	11	3
A	assertDefaultProcessors()	0	14	3

<?php
namespace Graze\Monolog;

use Monolog\Logger;

class LoggerBuilderIntegrationTest extends \PHPUnit_Framework_TestCase
{
    public function setUp()
    {
        $this->builder = new LoggerBuilder();

The property builder does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function assertDefaultHandlers(Logger $logger)

Function has parameters but no doc block

    {
        $handlers = array();

Short array syntax must be used to define arrays

        do {
            try {
                $handlers[] = $handler = $logger->popHandler();

The assignment to $handler is dead and can be removed.

            } catch (\Exception $e) {

Consider adding a comment why this CATCH block is empty.

            }
        } while (!isset($e));

        $this->assertSame(array(), $handlers, 'There are more handlers defined than should be');

Short array syntax must be used to define arrays

    }

    public function assertDefaultProcessors(Logger $logger)

Function has parameters but no doc block

    {
        $processors = array();

Short array syntax must be used to define arrays

        do {
            try {
                $processors[] = $processor = $logger->popProcessor();

The assignment to $processor is dead and can be removed.

            } catch (\Exception $e) {

Consider adding a comment why this CATCH block is empty.

            }
        } while (!isset($e));

        $this->assertInstanceOf('Graze\Monolog\Processor\ExceptionMessageProcessor', array_shift($processors));
        $this->assertInstanceOf('Graze\Monolog\Processor\EnvironmentProcessor', array_shift($processors));
        $this->assertInstanceOf('Graze\Monolog\Processor\HttpProcessor', array_shift($processors));
        $this->assertSame(array(), $processors, 'There are more processors defined than should be');

Short array syntax must be used to define arrays

    }

    public function testBuild()
    {
        $logger = $this->builder->build();

        $this->assertSame(LoggerBuilder::DEFAULT_NAME, $logger->getName());
        $this->assertDefaultHandlers($logger);
        $this->assertDefaultProcessors($logger);
    }
}