Graze\Monolog\ErrorHandlerBuilderIntegrationTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testBuildAndRegister()	0	6	1
A	setUp()	0	7	1
A	testBuild()	0	6	1
A	tearDown()	0	4	1

<?php
namespace Graze\Monolog;

class ErrorHandlerBuilderIntegrationTest extends \PHPUnit_Framework_TestCase
{
    public function setUp()
    {
        $this->defaultErrorHandler = set_error_handler(function(){});

The property defaultErrorHandler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

Expected 1 space after FUNCTION keyword; 0 found

        $this->defaultExceptionHandler = set_exception_handler(function(){});

The property defaultExceptionHandler does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

Expected 1 space after FUNCTION keyword; 0 found

        $this->tearDown();

        $this->builder = new ErrorHandlerBuilder();

The property builder does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function tearDown()
    {
        set_error_handler($this->defaultErrorHandler);
        set_exception_handler($this->defaultExceptionHandler);
    }

    public function testBuild()
    {
        $handler = $this->builder->build();

The assignment to $handler is dead and can be removed.

        $this->assertSame(set_error_handler(function(){}), $this->defaultErrorHandler);

Expected 1 space after FUNCTION keyword; 0 found

        $this->assertSame(set_exception_handler(function(){}), $this->defaultExceptionHandler);

Expected 1 space after FUNCTION keyword; 0 found

    }

    public function testBuildAndRegister()
    {
        $handler = $this->builder->buildAndRegister();

        $this->assertSame(set_error_handler(function(){}), array($handler, 'handleError'));

Expected 1 space after FUNCTION keyword; 0 found

Short array syntax must be used to define arrays

        $this->assertSame(set_exception_handler(function(){}), array($handler, 'handleException'));

Expected 1 space after FUNCTION keyword; 0 found

Short array syntax must be used to define arrays

    }
}