ClientTest::testSendAll() - Code Metrics - Inspection of "modernise the development environment a bit" - graze/guzzle-jsonrpc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Harry

created 2017-08-24 16:52 UTC

ClientTest::testSendAll() B

↳ Parent: ClientTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	37
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	1
eloc	28
nc	1
nop	0
dl	0
loc	37
rs	8.8571
c	2
b	0
f	0

<?php
/*
 * This file is part of Guzzle HTTP JSON-RPC
 *
 * Copyright (c) 2014 Nature Delivered Ltd. <http://graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see  http://github.com/graze/guzzle-jsonrpc/blob/master/LICENSE
 * @link http://github.com/graze/guzzle-jsonrpc
 */
namespace Graze\GuzzleHttp\JsonRpc;

use Graze\GuzzleHttp\JsonRpc\Message\RequestInterface;
use Graze\GuzzleHttp\JsonRpc\Test\UnitTestCase;
use Mockery;

class ClientTest extends UnitTestCase
{
    public function setup()
    {
        $this->httpClient = $this->mockHttpClient();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->httpHandler = $this->mockHttpHandler();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->messageFactory = $this->mockMessageFactory();
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->httpClient->shouldReceive('getConfig')->once()->with('handler')->andReturn($this->httpHandler);
        $this->httpHandler->shouldReceive('push')->times(4);

        $this->client = new Client($this->httpClient, $this->messageFactory);

    }

    public function testInterface()
    {
        $this->assertInstanceOf('Graze\GuzzleHttp\JsonRpc\ClientInterface', $this->client);

    }

    public function testStaticFactory()
    {
        $this->assertInstanceOf('Graze\GuzzleHttp\JsonRpc\ClientInterface', Client::factory('http://foo'));
    }

    public function testNotification()
    {
        $request = $this->mockRequest();
        $jsonrpc = ['jsonrpc'=>ClientInterface::SPEC, 'method'=>'foo'];
        $type = RequestInterface::NOTIFICATION;
        $uri = 'http://foo';

        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], $jsonrpc)->andReturn($request);

        $this->assertSame($request, $this->client->notification('foo'));

    }

    public function testNotificationWithParams()
    {
        $request = $this->mockRequest();
        $jsonrpc = ['jsonrpc'=>ClientInterface::SPEC, 'method'=>'foo', 'params'=>['bar'=>true]];
        $type = RequestInterface::NOTIFICATION;
        $uri = 'http://foo';

        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], $jsonrpc)->andReturn($request);

        $this->assertSame($request, $this->client->notification('foo', ['bar'=>true]));

    }

    public function testRequest()

    {
        $request = $this->mockRequest();
        $jsonrpc = ['jsonrpc'=>ClientInterface::SPEC, 'method'=>'foo', 'id'=>123];
        $type = RequestInterface::REQUEST;
        $uri = 'http://foo';

        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], $jsonrpc)->andReturn($request);

        $this->assertSame($request, $this->client->request(123, 'foo'));

    }

    public function testRequestWithParams()
    {
        $request = $this->mockRequest();
        $jsonrpc = ['jsonrpc'=>ClientInterface::SPEC, 'method'=>'foo', 'params'=>['bar'=>true], 'id'=>123];
        $type = RequestInterface::REQUEST;
        $uri = 'http://foo';

        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], $jsonrpc)->andReturn($request);

        $this->assertSame($request, $this->client->request(123, 'foo', ['bar'=>true]));

    }

    public function testRequestWithEmptyParams()

    {
        $request = $this->mockRequest();
        $jsonrpc = ['jsonrpc'=>ClientInterface::SPEC, 'method'=>'foo', 'id'=>123];
        $type = RequestInterface::REQUEST;
        $uri = 'http://foo';

        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], $jsonrpc)->andReturn($request);

        $this->assertSame($request, $this->client->request(123, 'foo', []));

    }

    public function testSendNotification()
    {
        $request = $this->mockRequest();
        $response = $this->mockResponse();
        $promise = $this->mockPromise();

        $request->shouldReceive('getRpcId')->once()->withNoArgs()->andReturn(null);
        $this->httpClient->shouldReceive('sendAsync')->once()->with($request)->andReturn($promise);
        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($response) {
            return null === $args($response);
        }))->andReturn($promise);
        $promise->shouldReceive('wait')->once()->withNoArgs()->andReturn(null);

        $this->assertNull($this->client->send($request));

    }

    public function testSendNotificationAsync()
    {
        $request = $this->mockRequest();
        $response = $this->mockResponse();
        $promise = $this->mockPromise();

        $request->shouldReceive('getRpcId')->once()->withNoArgs()->andReturn(null);
        $this->httpClient->shouldReceive('sendAsync')->once()->with($request)->andReturn($promise);
        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($response) {
            return null === $args($response);
        }))->andReturn($promise);

        $this->assertSame($promise, $this->client->sendAsync($request));

    }

    public function testSendRequest()
    {
        $request = $this->mockRequest();
        $response = $this->mockResponse();
        $promise = $this->mockPromise();

        $request->shouldReceive('getRpcId')->once()->withNoArgs()->andReturn('foo');
        $this->httpClient->shouldReceive('sendAsync')->once()->with($request)->andReturn($promise);
        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($response) {
            return $response === $args($response);
        }))->andReturn($promise);
        $promise->shouldReceive('wait')->once()->withNoArgs()->andReturn($response);

        $this->assertSame($response, $this->client->send($request));

    }

    public function testSendRequestAsync()
    {
        $request = $this->mockRequest();
        $response = $this->mockResponse();
        $promise = $this->mockPromise();

        $request->shouldReceive('getRpcId')->once()->withNoArgs()->andReturn('foo');
        $this->httpClient->shouldReceive('sendAsync')->once()->with($request)->andReturn($promise);
        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($response) {
            return $response === $args($response);
        }))->andReturn($promise);

        $this->assertSame($promise, $this->client->sendAsync($request));

    }

    public function testSendAll()
    {
        $promise = $this->mockPromise();
        $batchRequest = $this->mockRequest();
        $requestA = $this->mockRequest();
        $requestB = $this->mockRequest();
        $batchResponse = $this->mockResponse();
        $responseA = $this->mockResponse();
        $responseB = $this->mockResponse();

        $factory = $this->mockMessageFactory();
        $this->httpClient->messageFactory = $factory;

        $requestA->shouldReceive('getBody')->once()->withNoArgs()->andReturn('["foo"]');
        $requestB->shouldReceive('getBody')->once()->withNoArgs()->andReturn('["bar"]');

        $type = RequestInterface::BATCH;
        $uri = 'http://foo';
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], [['foo'], ['bar']])->andReturn($batchRequest);
        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->httpClient->shouldReceive('sendAsync')->once()->with($batchRequest)->andReturn($promise);

        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($batchResponse, $responseA, $responseB) {
            return [$responseA, $responseB] === $args($batchResponse);
        }))->andReturn($promise);
        $promise->shouldReceive('wait')->once()->withNoArgs()->andReturn([$responseA, $responseB]);

        $batchResponse->shouldReceive('getBody')->once()->withNoArgs()->andReturn('[["foo"], ["bar"]]');
        $batchResponse->shouldReceive('getStatusCode')->times(2)->withNoArgs()->andReturn(200);
        $batchResponse->shouldReceive('getHeaders')->times(2)->withNoArgs()->andReturn(['headers']);

        $this->messageFactory->shouldReceive('createResponse')->once()->with(200, ['headers'], ['foo'])->andReturn($responseA);
        $this->messageFactory->shouldReceive('createResponse')->once()->with(200, ['headers'], ['bar'])->andReturn($responseB);

        $this->assertSame([$responseA, $responseB], $this->client->sendAll([$requestA, $requestB]));

    }

    public function testSendAllAsync()
    {
        $promise = $this->mockPromise();
        $batchRequest = $this->mockRequest();
        $requestA = $this->mockRequest();
        $requestB = $this->mockRequest();
        $batchResponse = $this->mockResponse();
        $responseA = $this->mockResponse();
        $responseB = $this->mockResponse();

        $factory = $this->mockMessageFactory();
        $this->httpClient->messageFactory = $factory;

        $requestA->shouldReceive('getBody')->once()->withNoArgs()->andReturn('["foo"]');
        $requestB->shouldReceive('getBody')->once()->withNoArgs()->andReturn('["bar"]');

        $type = RequestInterface::BATCH;
        $uri = 'http://foo';
        $this->messageFactory->shouldReceive('createRequest')->once()->with($type, $uri, [], [['foo'], ['bar']])->andReturn($batchRequest);
        $this->httpClient->shouldReceive('getConfig')->once()->with('base_uri')->andReturn($uri);
        $this->httpClient->shouldReceive('getConfig')->once()->with('defaults')->andReturn([]);
        $this->httpClient->shouldReceive('sendAsync')->once()->with($batchRequest)->andReturn($promise);

        $promise->shouldReceive('then')->once()->with(Mockery::on(function ($args) use ($batchResponse, $responseA, $responseB) {
            return [$responseA, $responseB] === $args($batchResponse);
        }))->andReturn($promise);

        $batchResponse->shouldReceive('getBody')->once()->withNoArgs()->andReturn('[["foo"], ["bar"]]');
        $batchResponse->shouldReceive('getStatusCode')->times(2)->withNoArgs()->andReturn(200);
        $batchResponse->shouldReceive('getHeaders')->times(2)->withNoArgs()->andReturn(['headers']);

        $this->messageFactory->shouldReceive('createResponse')->once()->with(200, ['headers'], ['foo'])->andReturn($responseA);
        $this->messageFactory->shouldReceive('createResponse')->once()->with(200, ['headers'], ['bar'])->andReturn($responseB);

        $this->assertSame($promise, $this->client->sendAllAsync([$requestA, $requestB]));

    }
}


1			<?php
2			/*
3			* This file is part of Guzzle HTTP JSON-RPC
4			*
5			* Copyright (c) 2014 Nature Delivered Ltd. <http://graze.com>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @see http://github.com/graze/guzzle-jsonrpc/blob/master/LICENSE
11			* @link http://github.com/graze/guzzle-jsonrpc
12			*/
13			namespace Graze\GuzzleHttp\JsonRpc;
14
15			use Graze\GuzzleHttp\JsonRpc\Message\RequestInterface;
16			use Graze\GuzzleHttp\JsonRpc\Test\UnitTestCase;
17			use Mockery;
18
19			class ClientTest extends UnitTestCase
20			{
21			public function setup()
22			{
23			$this->httpClient = $this->mockHttpClient();
			0 ignored issues – show Bug introduced 2017-08-22 13:23 UTC by Report Bug Copy Issue Report The property `httpClient` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->httpHandler = $this->mockHttpHandler();
			0 ignored issues – show Bug introduced 2017-08-24 16:55 UTC by Report Bug Copy Issue Report The property `httpHandler` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			$this->messageFactory = $this->mockMessageFactory();
			0 ignored issues – show Bug introduced 2017-08-24 16:55 UTC by Report Bug Copy Issue Report The property `messageFactory` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26
27			$this->httpClient->shouldReceive('getConfig')->once()->with('handler')->andReturn($this->httpHandler);
28			$this->httpHandler->shouldReceive('push')->times(4);
29
30			$this->client = new Client($this->httpClient, $this->messageFactory);
			0 ignored issues – show Bug introduced 2017-08-24 16:55 UTC by Report Bug Copy Issue Report The property `client` does not seem to exist. Did you mean `httpClient`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
31			}
32
33			public function testInterface()
34			{
35			$this->assertInstanceOf('Graze\GuzzleHttp\JsonRpc\ClientInterface', $this->client);
			0 ignored issues – show Bug introduced 2017-08-22 13:23 UTC by Report Bug Copy Issue Report The property `client` does not seem to exist. Did you mean `httpClient`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...

graze / guzzle-jsonrpc

Pull Request — master (#30)

ClientTest::testSendAll() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like