HttpsAuthTest - Code Metrics - Inspection of "initial oauth2 commit" - graze/gigya-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Harry

created 2016-09-07 15:55 UTC

HttpsAuthTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	120
Duplicated Lines	63.33 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	0
cbo	5
dl	76
loc	120
rs	10

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testInstanceOf()	0	5	1
B	testKeySecretAndUserKeyIsPassedToParams()	0	30	1
A	testGetEventsHandlesBeforeAndSignsRequest()	8	8	1
B	testKeyAndSecretIsPassedToParams()	28	28	1
A	testAccessors()	7	7	1
A	testSubscriberDoesNotDoAnythingForNonHttpsRequests()	13	13	1
A	testSubscriberDoesNotDoAnythingForNonGigyaAuthRequests()	20	20	1

How to fix Duplicated Code

<?php
/**
 * This file is part of graze/gigya-client
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/gigya-client/blob/master/LICENSE.md
 * @link    https://github.com/graze/gigya-client
 */

namespace Graze\Gigya\Test\Unit\Auth;

use Graze\Gigya\Auth\GigyaAuthInterface;
use Graze\Gigya\Auth\HttpsAuth;
use Graze\Gigya\Test\TestCase;
use GuzzleHttp\Collection;
use GuzzleHttp\Event\BeforeEvent;
use GuzzleHttp\Event\RequestEvents;
use GuzzleHttp\Event\SubscriberInterface;
use GuzzleHttp\Message\RequestInterface;
use GuzzleHttp\Query;
use Mockery as m;

class HttpsAuthTest extends TestCase
{
    public function testInstanceOf()
    {
        $auth = new HttpsAuth('key', 'secret');
        static::assertInstanceOf(SubscriberInterface::class, $auth);
    }

    public function testGetEventsHandlesBeforeAndSignsRequest()

    {
        $auth = new HttpsAuth('key', 'secret');
        static::assertEquals(
            ['before' => ['sign', RequestEvents::SIGN_REQUEST]],
            $auth->getEvents()
        );
    }

    public function testKeyAndSecretIsPassedToParams()

    {
        $request = m::mock(RequestInterface::class);
        $event   = m::mock(BeforeEvent::class);
        $event->shouldReceive('getRequest')
              ->andReturn($request);

        $query  = m::mock(Query::class);
        $config = m::mock(Collection::class);

        $request->shouldReceive('getScheme')
                ->andReturn('https');
        $request->shouldReceive('getConfig')
                ->andReturn($config);
        $request->shouldReceive('getQuery')
                ->andReturn($query);

        $query->shouldReceive('offsetSet')
              ->with('apiKey', 'key');
        $query->shouldReceive('offsetSet')
              ->with('secret', 'secret');
        $config->shouldReceive('get')
               ->with('auth')
               ->andReturn('gigya');

        $auth = new HttpsAuth('key', 'secret');
        $auth->sign($event);
    }

    public function testKeySecretAndUserKeyIsPassedToParams()
    {
        $request = m::mock(RequestInterface::class);
        $event   = m::mock(BeforeEvent::class);
        $event->shouldReceive('getRequest')
              ->andReturn($request);

        $query  = m::mock(Query::class);
        $config = m::mock(Collection::class);

        $request->shouldReceive('getScheme')
                ->andReturn('https');
        $request->shouldReceive('getConfig')
                ->andReturn($config);
        $request->shouldReceive('getQuery')
                ->andReturn($query);

        $query->shouldReceive('offsetSet')
              ->with('apiKey', 'key');
        $query->shouldReceive('offsetSet')
              ->with('secret', 'secret');
        $query->shouldReceive('offsetSet')
              ->with('userKey', 'user');
        $config->shouldReceive('get')
               ->with('auth')
               ->andReturn('gigya');

        $auth = new HttpsAuth('key', 'secret', 'user');
        $auth->sign($event);
    }

    public function testAccessors()

    {
        $auth = new HttpsAuth('key', 'secret', 'user');
        static::assertEquals('key', $auth->getApiKey());
        static::assertEquals('secret', $auth->getSecret());
        static::assertEquals('user', $auth->getUserKey());
    }

    public function testSubscriberDoesNotDoAnythingForNonHttpsRequests()

    {
        $request = m::mock(RequestInterface::class);
        $event   = m::mock(BeforeEvent::class);
        $event->shouldReceive('getRequest')
              ->andReturn($request);

        $request->shouldReceive('getScheme')
                ->andReturn('http');

        $auth = new HttpsAuth('key', 'secret', 'user');
        $auth->sign($event);
    }

    public function testSubscriberDoesNotDoAnythingForNonGigyaAuthRequests()

    {
        $request = m::mock(RequestInterface::class);
        $event   = m::mock(BeforeEvent::class);
        $event->shouldReceive('getRequest')
              ->andReturn($request);

        $config = m::mock(Collection::class);
        $request->shouldReceive('getScheme')
                ->andReturn('https');
        $request->shouldReceive('getConfig')
                ->andReturn($config);

        $config->shouldReceive('get')
               ->with('auth')
               ->andReturn('oauth');

        $auth = new HttpsAuth('key', 'secret', 'user');
        $auth->sign($event);
    }
}


1		<?php
2		/**
3		* This file is part of graze/gigya-client
4		*
5		* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @license https://github.com/graze/gigya-client/blob/master/LICENSE.md
11		* @link https://github.com/graze/gigya-client
12		*/
13
14		namespace Graze\Gigya\Test\Unit\Auth;
15
16		use Graze\Gigya\Auth\GigyaAuthInterface;
17		use Graze\Gigya\Auth\HttpsAuth;
18		use Graze\Gigya\Test\TestCase;
19		use GuzzleHttp\Collection;
20		use GuzzleHttp\Event\BeforeEvent;
21		use GuzzleHttp\Event\RequestEvents;
22		use GuzzleHttp\Event\SubscriberInterface;
23		use GuzzleHttp\Message\RequestInterface;
24		use GuzzleHttp\Query;
25		use Mockery as m;
26
27		class HttpsAuthTest extends TestCase
28		{
29		public function testInstanceOf()
30		{
31		$auth = new HttpsAuth('key', 'secret');
32		static::assertInstanceOf(SubscriberInterface::class, $auth);
33		}
34
35	View Code Duplication	public function testGetEventsHandlesBeforeAndSignsRequest()
		0 ignored issues – show Duplication introduced 2016-08-24 11:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$auth = new HttpsAuth('key', 'secret');
38		static::assertEquals(
39		['before' => ['sign', RequestEvents::SIGN_REQUEST]],
40		$auth->getEvents()
41		);
42		}
43
44	View Code Duplication	public function testKeyAndSecretIsPassedToParams()
		0 ignored issues – show Duplication introduced 2016-08-24 11:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		$request = m::mock(RequestInterface::class);
47		$event = m::mock(BeforeEvent::class);
48		$event->shouldReceive('getRequest')
49		->andReturn($request);
50
51		$query = m::mock(Query::class);
52		$config = m::mock(Collection::class);
53
54		$request->shouldReceive('getScheme')
55		->andReturn('https');
56		$request->shouldReceive('getConfig')
57		->andReturn($config);
58		$request->shouldReceive('getQuery')
59		->andReturn($query);
60
61		$query->shouldReceive('offsetSet')
62		->with('apiKey', 'key');
63		$query->shouldReceive('offsetSet')
64		->with('secret', 'secret');
65		$config->shouldReceive('get')
66		->with('auth')
67		->andReturn('gigya');
68
69		$auth = new HttpsAuth('key', 'secret');
70		$auth->sign($event);
71		}
72
73		public function testKeySecretAndUserKeyIsPassedToParams()
74		{
75		$request = m::mock(RequestInterface::class);
76		$event = m::mock(BeforeEvent::class);
77		$event->shouldReceive('getRequest')
78		->andReturn($request);
79
80		$query = m::mock(Query::class);
81		$config = m::mock(Collection::class);
82
83		$request->shouldReceive('getScheme')
84		->andReturn('https');
85		$request->shouldReceive('getConfig')
86		->andReturn($config);
87		$request->shouldReceive('getQuery')
88		->andReturn($query);
89
90		$query->shouldReceive('offsetSet')
91		->with('apiKey', 'key');
92		$query->shouldReceive('offsetSet')
93		->with('secret', 'secret');
94		$query->shouldReceive('offsetSet')
95		->with('userKey', 'user');
96		$config->shouldReceive('get')
97		->with('auth')
98		->andReturn('gigya');
99
100		$auth = new HttpsAuth('key', 'secret', 'user');
101		$auth->sign($event);
102		}
103
104	View Code Duplication	public function testAccessors()
		0 ignored issues – show Duplication introduced 2016-08-24 11:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
105		{
106		$auth = new HttpsAuth('key', 'secret', 'user');
107		static::assertEquals('key', $auth->getApiKey());
108		static::assertEquals('secret', $auth->getSecret());
109		static::assertEquals('user', $auth->getUserKey());
110		}
111
112	View Code Duplication	public function testSubscriberDoesNotDoAnythingForNonHttpsRequests()
		0 ignored issues – show Duplication introduced 2016-08-24 11:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		$request = m::mock(RequestInterface::class);
115		$event = m::mock(BeforeEvent::class);
116		$event->shouldReceive('getRequest')
117		->andReturn($request);
118
119		$request->shouldReceive('getScheme')
120		->andReturn('http');
121
122		$auth = new HttpsAuth('key', 'secret', 'user');
123		$auth->sign($event);
124		}
125
126	View Code Duplication	public function testSubscriberDoesNotDoAnythingForNonGigyaAuthRequests()
		0 ignored issues – show Duplication introduced 2016-08-24 11:31 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$request = m::mock(RequestInterface::class);
129		$event = m::mock(BeforeEvent::class);
130		$event->shouldReceive('getRequest')
131		->andReturn($request);
132
133		$config = m::mock(Collection::class);
134		$request->shouldReceive('getScheme')
135		->andReturn('https');
136		$request->shouldReceive('getConfig')
137		->andReturn($config);
138
139		$config->shouldReceive('get')
140		->with('auth')
141		->andReturn('oauth');
142
143		$auth = new HttpsAuth('key', 'secret', 'user');
144		$auth->sign($event);
145		}
146		}
147

graze / gigya-client

Pull Request — master (#20)

HttpsAuthTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like