Graze\Dynamark3Client\Dynamark3Client

Complexity

Total Complexity

5

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

69.69%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	__call()	0	6	1
A	send()	0	22	2
A	build()	0	14	1

<?php

/**
 * This file is part of graze/dynamark3-client.
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/dynamark3-client/blob/master/LICENSE.md
 * @link https://github.com/graze/dynamark3-client
 */

namespace Graze\Dynamark3Client;

use Graze\TelnetClient\TelnetClientInterface;
use Graze\Dynamark3Client\CommandResolver;
use Graze\Dynamark3Client\Command\CommandInterface;
use Graze\TelnetClient\TelnetClient;
use Graze\Dynamark3Client\Dynamark3Constants;

class Dynamark3Client
{
    /**
     * @var TelnetClientInterface
     */
    protected $telnet;

    /**
     * @var CommandResolver
     */
    protected $commandResolver;

    /**
     * @param TelnetClientInterface $telnet
     * @param CommandResolver $commandResolver
     */
    public function __construct(TelnetClientInterface $telnet, CommandResolver $commandResolver)
    {
        $this->telnet = $telnet;
        $this->commandResolver = $commandResolver;
    }

    /**
     * @param string $name
     * @param array $arguments
     *
     * @return Graze\Dynamark3Client\Dynamark3Response;

The doc-type Graze\Dynamark3Client\Dynamark3Response; could not be parsed: Expected "|" or "end of type", but got ";" at position 39. (view supported doc-types)

     */
    public function __call($name, array $arguments)
    {
        $command = $this->commandResolver->resolve($name);
        array_unshift($arguments, $command);
        return call_user_func_array([$this, 'send'], $arguments);
    }

    /**
     * @param CommandInterface $command
     *
     * @return Graze\Dynamark3Client\Dynamark3Response;

The doc-type Graze\Dynamark3Client\Dynamark3Response; could not be parsed: Expected "|" or "end of type", but got ";" at position 39. (view supported doc-types)

     */
    protected function send(CommandInterface $command)

The parameter $command is not used and could be removed.

    {
        $arguments =  func_get_args();
        $command = array_shift($arguments);

        $argumentsString = '';
        if ($arguments) {

The expression $arguments of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            // add quotes to arguments
            array_walk($arguments, function (&$value) {
                $value = sprintf('"%s"', $value);
            });

            $argumentsString = ' ' . implode(' ', $arguments);
        }

        $telnetResponse = $this->telnet->execute(
            $command->getCommandText() . $argumentsString,
            $command->getPrompt()
        );

        return $command->parseResponse($telnetResponse);
    }

    /**
     * @param string $dsn
     *
     * @return Dynamark3Client
     */
    public static function build($dsn)
    {
        $telnetClient = TelnetClient::build(
            $dsn,
            Dynamark3Constants::PROMPT,
            Dynamark3Constants::PROMPT_ERROR,
            Dynamark3Constants::LINE_ENDING
        );

        return new static(
            $telnetClient,
            new CommandResolver()
        );
    }
}