Dynamark3ClientTest::testConnect() - Code Metrics - Inspection of "Don't connect on conststruct" - graze/dynamark3-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by John

created 2016-03-02 11:32 UTC

Dynamark3ClientTest::testConnect() A

↳ Parent: Dynamark3ClientTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	19
rs	9.4285
cc	1
eloc	14
nc	1
nop	0

<?php

/**
 * This file is part of graze/dynamark3-client.
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/dynamark3-client/blob/master/LICENSE.md
 * @link https://github.com/graze/dynamark3-client
 */

namespace Graze\Dynamark3Client\Test\Unit;

use \Graze\TelnetClient\TelnetResponseInterface;
use \Graze\Dynamark3Client\Command\CommandInterface;
use \Graze\TelnetClient\TelnetClientInterface;
use \Graze\Dynamark3Client\CommandResolver;
use \Graze\Dynamark3Client\Dynamark3Client;
use \Graze\Dynamark3Client\Dynamark3ResponseInterface;
use \Graze\Dynamark3Client\Dynamark3Constants;
use \Mockery as m;

class Dynamark3ClientTest extends \PHPUnit_Framework_TestCase
{
    public function testSend()
    {
        $telnetResponse = m::mock(TelnetResponseInterface::class);
        $telnet = m::mock(TelnetClientInterface::class)
            ->shouldReceive('execute')
            ->with('COMMAND ARGS', null)
            ->andReturn($telnetResponse)
            ->once()
            ->getMock();

        $dynamark3Response = m::mock(Dynamark3ResponseInterface::class);
        $command = m::mock(CommandInterface::class)
            ->shouldReceive('getCommandText')
            ->andReturn('COMMAND')
            ->once()
            ->shouldReceive('getArgumentText')
            ->andReturn(' ARGS')
            ->once()
            ->shouldReceive('getPrompt')
            ->andReturn(null)
            ->once()
            ->shouldReceive('parseResponse')
            ->with($telnetResponse)
            ->andReturn($dynamark3Response)
            ->once()
            ->getMock();
        $commandResolver = m::mock(CommandResolver::class)
            ->shouldReceive('resolve')
            ->with('command')
            ->andReturn($command)
            ->once()
            ->getMock();

        $client = new Dynamark3Client($telnet, $commandResolver);
        $resp = $client->command();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->assertSame($dynamark3Response, $resp);
    }

    public function testFactory()
    {
        $this->assertInstanceOf(Dynamark3Client::class, Dynamark3Client::factory());
    }

    public function testConnect()
    {
        $dsn = '127.0.0.1:23';
        $telnet = m::mock(TelnetClientInterface::class)
            ->shouldReceive('connect')
            ->with(
                $dsn,
                Dynamark3Constants::PROMPT,
                Dynamark3Constants::PROMPT_ERROR,
                Dynamark3Constants::LINE_ENDING
            )
            ->once()
            ->getMock();

        $commandResolver = m::mock(CommandResolver::class);

        $client = new Dynamark3Client($telnet, $commandResolver);
        $client->connect($dsn);
    }
}


1			<?php
2
3			/**
4			* This file is part of graze/dynamark3-client.
5			*
6			* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*
11			* @license https://github.com/graze/dynamark3-client/blob/master/LICENSE.md
12			* @link https://github.com/graze/dynamark3-client
13			*/
14
15			namespace Graze\Dynamark3Client\Test\Unit;
16
17			use \Graze\TelnetClient\TelnetResponseInterface;
18			use \Graze\Dynamark3Client\Command\CommandInterface;
19			use \Graze\TelnetClient\TelnetClientInterface;
20			use \Graze\Dynamark3Client\CommandResolver;
21			use \Graze\Dynamark3Client\Dynamark3Client;
22			use \Graze\Dynamark3Client\Dynamark3ResponseInterface;
23			use \Graze\Dynamark3Client\Dynamark3Constants;
24			use \Mockery as m;
25
26			class Dynamark3ClientTest extends \PHPUnit_Framework_TestCase
27			{
28			public function testSend()
29			{
30			$telnetResponse = m::mock(TelnetResponseInterface::class);
31			$telnet = m::mock(TelnetClientInterface::class)
32			->shouldReceive('execute')
33			->with('COMMAND ARGS', null)
34			->andReturn($telnetResponse)
35			->once()
36			->getMock();
37
38			$dynamark3Response = m::mock(Dynamark3ResponseInterface::class);
39			$command = m::mock(CommandInterface::class)
40			->shouldReceive('getCommandText')
41			->andReturn('COMMAND')
42			->once()
43			->shouldReceive('getArgumentText')
44			->andReturn(' ARGS')
45			->once()
46			->shouldReceive('getPrompt')
47			->andReturn(null)
48			->once()
49			->shouldReceive('parseResponse')
50			->with($telnetResponse)
51			->andReturn($dynamark3Response)
52			->once()
53			->getMock();
54			$commandResolver = m::mock(CommandResolver::class)
55			->shouldReceive('resolve')
56			->with('command')
57			->andReturn($command)
58			->once()
59			->getMock();
60
61			$client = new Dynamark3Client($telnet, $commandResolver);
62			$resp = $client->command();
			0 ignored issues – show Documentation Bug introduced 2016-03-02 11:28 UTC by Report Bug Copy Issue Report The method `command` does not exist on `object<Graze\Dynamark3Client\Dynamark3Client>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
63			$this->assertSame($dynamark3Response, $resp);
64			}
65
66			public function testFactory()
67			{
68			$this->assertInstanceOf(Dynamark3Client::class, Dynamark3Client::factory());
69			}
70
71			public function testConnect()
72			{
73			$dsn = '127.0.0.1:23';
74			$telnet = m::mock(TelnetClientInterface::class)
75			->shouldReceive('connect')
76			->with(
77			$dsn,
78			Dynamark3Constants::PROMPT,
79			Dynamark3Constants::PROMPT_ERROR,
80			Dynamark3Constants::LINE_ENDING
81			)
82			->once()
83			->getMock();
84
85			$commandResolver = m::mock(CommandResolver::class);
86
87			$client = new Dynamark3Client($telnet, $commandResolver);
88			$client->connect($dsn);
89			}
90			}
91

graze / dynamark3-client

Pull Request — master (#7)

Dynamark3ClientTest::testConnect() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like