Issues in ImmutableFlatContainerTest.php (master) - Issues in master - graze/data-structure - Measure and Improve Code Quality continuously with Scrutinizer

Issues (49)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

test/unit/Container/ImmutableFlatContainerTest.php (8 issues)

Labels

Duplication 8

Severity

Informational 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Graze\DataStructure\Container;

use PHPUnit_Framework_TestCase as TestCase;

class ImmutableFlatContainerTest extends TestCase
{
    public function testInterface()
    {
        $cont = new ImmutableFlatContainer();

        $this->assertInstanceOf('Graze\DataStructure\Container\ContainerInterface', $cont);
        $this->assertInstanceOf('Serializable', $cont);
    }

    public function testConstructor()

    {
        $params = ['foo' => 'a', 'bar' => 'b', 'baz' => 'c'];
        $cont = new ImmutableFlatContainer($params);

        $this->assertEquals($params, $cont->getAll());
    }

    public function testAdd()

    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b']);
        $result = $cont->add('baz', 'c');

        $this->assertEquals(['foo' => 'a', 'bar' => 'b'], $cont->getAll());
        $this->assertEquals(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], $result->getAll());
        $this->assertNotSame($cont, $result);
        $this->assertInstanceOf(ImmutableFlatContainer::class, $result);
    }

    /**
     * @expectedException \Graze\DataStructure\Exception\RegisteredKeyException
     */
    public function testAddDuplicate()
    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);

        $cont->add('baz', 'd');
    }

    public function testForAll()
    {
        $params = ['foo' => 'a', 'bar' => 'b', 'baz' => 'c'];
        $seen = [];

        $cont = new ImmutableFlatContainer($params);
        $cont->forAll(function ($value, $key) use (&$seen) {
            $seen[$key] = $value;
        });

        $this->assertEquals($params, $seen);
    }

    public function testGet()
    {
        $cont = new ImmutableFlatContainer(['foo' => ['child' => 'a'], 'bar' => 'b', 'baz' => 'c']);

        $this->assertEquals('a', $cont->get('foo.child'));
    }

    public function testGetMissing()
    {
        $cont = new ImmutableFlatContainer();

        $this->assertNull($cont->get('foo'));
    }

    public function testGetIterator()
    {
        $cont = new ImmutableFlatContainer();

        $this->assertInstanceOf('Iterator', $cont->getIterator());
    }

    public function testHasIsTrue()
    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);

        $this->assertTrue($cont->has('foo'));
    }

    public function testHasIsFalse()
    {
        $cont = new ImmutableFlatContainer(['FOO' => 'a', 'bar' => 'b', 'baz' => 'c']);

        $this->assertFalse($cont->has('foo'));
    }

    public function testRemove()
    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e'], 'baz' => 'c']);
        $result = $cont->remove('bar.b');

        $this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e'], 'baz' => 'c'], $cont->getAll());
        $this->assertEquals(['foo' => 'a', 'bar' => ['d' => 'e'], 'baz' => 'c'], $result->getAll());
        $this->assertNotSame($cont, $result);
        $this->assertInstanceOf(ImmutableFlatContainer::class, $result);
    }

    public function testRemoveMissing()

    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b']);
        $result = $cont->remove('baz');

        $this->assertEquals(['foo' => 'a', 'bar' => 'b'], $cont->getAll());
        $this->assertEquals(['foo' => 'a', 'bar' => 'b'], $result->getAll());
        $this->assertSame($cont, $result);
        $this->assertInstanceOf(ImmutableFlatContainer::class, $result);
    }

    public function testSet()
    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c']]);
        $result = $cont->set('bar.d', 'e');

        $this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c']], $cont->getAll());
        $this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']], $result->getAll());
        $this->assertNotSame($cont, $result);
        $this->assertInstanceOf(ImmutableFlatContainer::class, $result);
    }

    public function testSetDuplicate()
    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']]);
        $result = $cont->set('bar.d', 'f');

        $this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']], $cont->getAll());
        $this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'f']], $result->getAll());
        $this->assertNotSame($cont, $result);
        $this->assertInstanceOf(ImmutableFlatContainer::class, $result);
    }

    public function testSerialize()

    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);

        $this->assertEquals(
            'C:52:"Graze\DataStructure\Container\ImmutableFlatContainer":60:{a:3:{s:3:"foo";s:1:"a";s:3:"bar";s:1:"b";s:3:"baz";s:1:"c";}}',
            serialize($cont)
        );
    }

    public function testUnserialize()
    {
        $cont = unserialize('C:52:"Graze\DataStructure\Container\ImmutableFlatContainer":60:{a:3:{s:3:"foo";s:1:"a";s:3:"bar";s:1:"b";s:3:"baz";s:1:"c";}}');

        $this->assertEquals(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], $cont->getAll());
    }

    public function testArrayAccessUnset()

    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);

        unset($cont['baz']);
        $this->assertTrue($cont->has('baz'));
    }

    public function testArrayAccessSet()

    {
        $cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);

        $cont['baz'] = 'd';
        $this->assertEquals('c', $cont->get('baz'));
    }

    public function testImmutableChildren()
    {
        $cont = new ImmutableFlatContainer(
            ['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'h'])])]
        );

        $output = $cont->set('c.f.g', 'i');

        $this->assertEquals(
            ['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'h'])])],
            $cont->getAll()
        );
        $this->assertEquals(
            ['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'i'])])],
            $output->getAll()
        );
    }

    public function testImmutableChildReferences()

    {
        $child = new Container(['a' => 'b', 'c' => 'd']);
        $container = new ImmutableFlatContainer(['child' => $child]);

        $child->set('c', 'e');

        $this->assertEquals(
            ['child' => new Container(['a' => 'b', 'c' => 'd'])],
            $container->getAll()
        );
    }

    public function testExtractedChildDoesNotModifyParent()

    {
        $cont = new ImmutableFlatContainer(['a' => 'b', 'c' => new Container(['d' => 'e'])]);

        $child = $cont->get('c');

        $child->set('d', 'f');

        $this->assertEquals(
            ['a' => 'b', 'c' => new Container(['d' => 'e'])],
            $cont->getAll(),
            'modifying a child object should not modify the parent container'
        );
    }
}


1		<?php
2
3		namespace Graze\DataStructure\Container;
4
5		use PHPUnit_Framework_TestCase as TestCase;
6
7		class ImmutableFlatContainerTest extends TestCase
8		{
9		public function testInterface()
10		{
11		$cont = new ImmutableFlatContainer();
12
13		$this->assertInstanceOf('Graze\DataStructure\Container\ContainerInterface', $cont);
14		$this->assertInstanceOf('Serializable', $cont);
15		}
16
17	View Code Duplication	public function testConstructor()
		0 ignored issues – show Duplication introduced 2017-11-22 11:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		$params = ['foo' => 'a', 'bar' => 'b', 'baz' => 'c'];
20		$cont = new ImmutableFlatContainer($params);
21
22		$this->assertEquals($params, $cont->getAll());
23		}
24
25	View Code Duplication	public function testAdd()
		0 ignored issues – show Duplication introduced 2017-11-22 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b']);
28		$result = $cont->add('baz', 'c');
29
30		$this->assertEquals(['foo' => 'a', 'bar' => 'b'], $cont->getAll());
31		$this->assertEquals(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], $result->getAll());
32		$this->assertNotSame($cont, $result);
33		$this->assertInstanceOf(ImmutableFlatContainer::class, $result);
34		}
35
36		/**
37		* @expectedException \Graze\DataStructure\Exception\RegisteredKeyException
38		*/
39		public function testAddDuplicate()
40		{
41		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);
42
43		$cont->add('baz', 'd');
44		}
45
46		public function testForAll()
47		{
48		$params = ['foo' => 'a', 'bar' => 'b', 'baz' => 'c'];
49		$seen = [];
50
51		$cont = new ImmutableFlatContainer($params);
52		$cont->forAll(function ($value, $key) use (&$seen) {
53		$seen[$key] = $value;
54		});
55
56		$this->assertEquals($params, $seen);
57		}
58
59		public function testGet()
60		{
61		$cont = new ImmutableFlatContainer(['foo' => ['child' => 'a'], 'bar' => 'b', 'baz' => 'c']);
62
63		$this->assertEquals('a', $cont->get('foo.child'));
64		}
65
66		public function testGetMissing()
67		{
68		$cont = new ImmutableFlatContainer();
69
70		$this->assertNull($cont->get('foo'));
71		}
72
73		public function testGetIterator()
74		{
75		$cont = new ImmutableFlatContainer();
76
77		$this->assertInstanceOf('Iterator', $cont->getIterator());
78		}
79
80		public function testHasIsTrue()
81		{
82		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);
83
84		$this->assertTrue($cont->has('foo'));
85		}
86
87		public function testHasIsFalse()
88		{
89		$cont = new ImmutableFlatContainer(['FOO' => 'a', 'bar' => 'b', 'baz' => 'c']);
90
91		$this->assertFalse($cont->has('foo'));
92		}
93
94		public function testRemove()
95		{
96		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e'], 'baz' => 'c']);
97		$result = $cont->remove('bar.b');
98
99		$this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e'], 'baz' => 'c'], $cont->getAll());
100		$this->assertEquals(['foo' => 'a', 'bar' => ['d' => 'e'], 'baz' => 'c'], $result->getAll());
101		$this->assertNotSame($cont, $result);
102		$this->assertInstanceOf(ImmutableFlatContainer::class, $result);
103		}
104
105	View Code Duplication	public function testRemoveMissing()
		0 ignored issues – show Duplication introduced 2017-11-22 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b']);
108		$result = $cont->remove('baz');
109
110		$this->assertEquals(['foo' => 'a', 'bar' => 'b'], $cont->getAll());
111		$this->assertEquals(['foo' => 'a', 'bar' => 'b'], $result->getAll());
112		$this->assertSame($cont, $result);
113		$this->assertInstanceOf(ImmutableFlatContainer::class, $result);
114		}
115
116		public function testSet()
117		{
118		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c']]);
119		$result = $cont->set('bar.d', 'e');
120
121		$this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c']], $cont->getAll());
122		$this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']], $result->getAll());
123		$this->assertNotSame($cont, $result);
124		$this->assertInstanceOf(ImmutableFlatContainer::class, $result);
125		}
126
127		public function testSetDuplicate()
128		{
129		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']]);
130		$result = $cont->set('bar.d', 'f');
131
132		$this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'e']], $cont->getAll());
133		$this->assertEquals(['foo' => 'a', 'bar' => ['b' => 'c', 'd' => 'f']], $result->getAll());
134		$this->assertNotSame($cont, $result);
135		$this->assertInstanceOf(ImmutableFlatContainer::class, $result);
136		}
137
138	View Code Duplication	public function testSerialize()
		0 ignored issues – show Duplication introduced 2017-11-22 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
139		{
140		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);
141
142		$this->assertEquals(
143		'C:52:"Graze\DataStructure\Container\ImmutableFlatContainer":60:{a:3:{s:3:"foo";s:1:"a";s:3:"bar";s:1:"b";s:3:"baz";s:1:"c";}}',
144		serialize($cont)
145		);
146		}
147
148		public function testUnserialize()
149		{
150		$cont = unserialize('C:52:"Graze\DataStructure\Container\ImmutableFlatContainer":60:{a:3:{s:3:"foo";s:1:"a";s:3:"bar";s:1:"b";s:3:"baz";s:1:"c";}}');
151
152		$this->assertEquals(['foo' => 'a', 'bar' => 'b', 'baz' => 'c'], $cont->getAll());
153		}
154
155	View Code Duplication	public function testArrayAccessUnset()
		0 ignored issues – show Duplication introduced 2017-11-22 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
156		{
157		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);
158
159		unset($cont['baz']);
160		$this->assertTrue($cont->has('baz'));
161		}
162
163	View Code Duplication	public function testArrayAccessSet()
		0 ignored issues – show Duplication introduced 2017-11-22 16:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
164		{
165		$cont = new ImmutableFlatContainer(['foo' => 'a', 'bar' => 'b', 'baz' => 'c']);
166
167		$cont['baz'] = 'd';
168		$this->assertEquals('c', $cont->get('baz'));
169		}
170
171		public function testImmutableChildren()
172		{
173		$cont = new ImmutableFlatContainer(
174		['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'h'])])]
175		);
176
177		$output = $cont->set('c.f.g', 'i');
178
179		$this->assertEquals(
180		['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'h'])])],
181		$cont->getAll()
182		);
183		$this->assertEquals(
184		['a' => 'b', 'c' => new Container(['d' => 'e', 'f' => new Container(['g' => 'i'])])],
185		$output->getAll()
186		);
187		}
188
189	View Code Duplication	public function testImmutableChildReferences()
		0 ignored issues – show Duplication introduced 2017-11-24 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
190		{
191		$child = new Container(['a' => 'b', 'c' => 'd']);
192		$container = new ImmutableFlatContainer(['child' => $child]);
193
194		$child->set('c', 'e');
195
196		$this->assertEquals(
197		['child' => new Container(['a' => 'b', 'c' => 'd'])],
198		$container->getAll()
199		);
200		}
201
202	View Code Duplication	public function testExtractedChildDoesNotModifyParent()
		0 ignored issues – show Duplication introduced 2017-11-24 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
203		{
204		$cont = new ImmutableFlatContainer(['a' => 'b', 'c' => new Container(['d' => 'e'])]);
205
206		$child = $cont->get('c');
207
208		$child->set('d', 'f');
209
210		$this->assertEquals(
211		['a' => 'b', 'c' => new Container(['d' => 'e'])],
212		$cont->getAll(),
213		'modifying a child object should not modify the parent container'
214		);
215		}
216		}
217

graze / data-structure

Issues (49)

Security Analysis no request data

test/unit/Container/ImmutableFlatContainerTest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like