Graze\DataStructure\Container\FlatContainer

Complexity

Total Complexity

22

Size/Duplication

Total Lines	139
Duplicated Lines	15.11 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getChild()	0	12	3
A	splitToLast()	0	8	1
A	has()	7	7	2
A	get()	8	8	2
A	set()	0	4	1
B	doSet()	3	21	6
A	remove()	0	4	1
B	doRemove()	3	21	6

<?php
/*
 * This file is part of Graze DataStructure
 *
 * Copyright (c) 2017 Nature Delivered Ltd. <http://graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @see  http://github.com/graze/data-structure/blob/master/LICENSE
 * @link http://github.com/graze/data-structure
 */

namespace Graze\DataStructure\Container;

use ArrayAccess;

/**
 * FlatContainer accepts key access using a delimiter to represent child arrays
 *
 * ## Examples
 *
 * ```php
 * $container = new FlatContainer(['first' => 'value', 'second' => ['child' => 1, 'other' => 2]]);
 *
 * $container->get('second.child')
 * // 1
 *
 * ($container->has('first.child'))
 * // false
 *
 * $container->set('second.third', 3);
 * $container->getAll();
 * // ['first' => 'value', 'second' => ['child' => 1, 'other' => 2, 'third'=> 3]]
 *
 * $container->remove('second.other');
 * $container->getAll();
 * // ['first' => 'value', 'second' => ['child' => 1, 'third'=> 3]]
 * ```
 */
class FlatContainer extends Container
{
    const DELIMITER = '.';

    /**
     * @param string $key
     *
     * @return mixed|null
     */
    private function getChild($key)
    {
        $top = $this->params;

        foreach (explode(static::DELIMITER, $key) as $node) {
            if (!isset($top[$node])) {
                return null;
            }
            $top = $top[$node];
        }
        return $top;
    }

    /**
     * @param string $key
     *
     * @return string[] split the key into everything up to the last delimiter, and the last key
     */
    private function splitToLast($key)
    {
        $split = explode(static::DELIMITER, $key);
        $key = implode(static::DELIMITER, array_slice($split, 0, -1));

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

        $last = end($split);

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

        return [$key, $last];
    }

    /**
     * @param string $key
     *
     * @return bool
     */
    public function has($key)

This method seems to be duplicated in your project.

    {
        if (mb_strpos($key, static::DELIMITER) !== false) {
            return (!is_null($this->getChild($key)));
        }
        return parent::has($key);
    }

    /**
     * @param string $key
     *
     * @return mixed|null
     */
    public function get($key)

This method seems to be duplicated in your project.

    {
        if (mb_strpos($key, static::DELIMITER) !== false) {
            return $this->getChild($key);
        }

        return parent::get($key);
    }

    /**
     * @param string $key
     * @param mixed  $value
     *
     * @return ContainerInterface
     */
    public function set($key, $value)
    {
        return $this->doSet($key, $value);
    }

    /**
     * @param string $key
     * @param mixed  $value
     *
     * @return ContainerInterface
     */
    protected function doSet($key, $value)
    {
        if (mb_strpos($key, static::DELIMITER) !== false) {
            list($key, $last) = $this->splitToLast($key);

            $top = $this->get($key);
            if (is_null($top) || (!is_array($top) && !($top instanceof ArrayAccess))) {

This code seems to be duplicated across your project.

                $top = [];
            }

            if ($top instanceof ContainerInterface) {
                $top = $top->set($last, $value);
            } else {
                $top[$last] = $value;
            }

            return $this->doSet($key, $top);
        }

        return parent::set($key, $value);

It seems like you call parent on a different method (set() instead of doSet()). Are you sure this is correct? If so, you might want to change this to $this->set().

    }

    /**
     * @param string $key
     *
     * @return ContainerInterface
     */
    public function remove($key)
    {
        return $this->doRemove($key);
    }

    /**
     * @param string $key
     *
     * @return ContainerInterface
     */
    protected function doRemove($key)
    {
        if (mb_strpos($key, static::DELIMITER) !== false) {
            list($key, $last) = $this->splitToLast($key);

            $top = $this->get($key);
            if (is_null($top) || (!is_array($top) && !($top instanceof ArrayAccess))) {

This code seems to be duplicated across your project.

                return $this;
            }

            if ($top instanceof ContainerInterface) {
                $top = $top->remove($last);
            } else {
                unset($top[$last]);
            }

            return $this->doSet($key, $top);
        }

        return parent::remove($key);

It seems like you call parent on a different method (remove() instead of doRemove()). Are you sure this is correct? If so, you might want to change this to $this->remove().

    }
}