Issues in FileWriterTest.php (master) - Issues in master - graze/data-file - Measure and Improve Code Quality continuously with Scrutinizer

Issues (144)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/unit/IO/FileWriterTest.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This file is part of graze/data-file
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/data-file/blob/master/LICENSE.md
 * @link    https://github.com/graze/data-file
 */

namespace Graze\DataFile\Test\Unit\IO;

use Graze\DataFile\Format\CsvFormat;
use Graze\DataFile\Format\FormatAwareInterface;
use Graze\DataFile\Format\Formatter\FormatterFactoryInterface;
use Graze\DataFile\Format\Formatter\FormatterInterface;
use Graze\DataFile\Format\JsonFormat;
use Graze\DataFile\IO\FileWriter;
use Graze\DataFile\IO\WriterInterface;
use Graze\DataFile\Node\FileNodeInterface;
use Graze\DataFile\Node\NodeStreamInterface;
use Graze\DataFile\Test\TestCase;
use InvalidArgumentException;
use Mockery as m;

class FileWriterTest extends TestCase
{
    public function testNodeStreamFileWillGetAStream()

    {
        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        $format = m::mock(CsvFormat::class)
                   ->makePartial();

        $writer = new FileWriter($file, $format);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertInstanceOf(WriterInterface::class, $writer);
    }

    public function testFileNodeWillThrowAnException()
    {
        $file = m::mock(FileNodeInterface::class);

        static::expectException(InvalidArgumentException::class);
        new FileWriter($file);
    }

    public function testNodeWithNoFormatAndNoFormatSpecifiedWillThrowAnException()

    {
        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        static::expectException(InvalidArgumentException::class);
        new FileWriter($file);
    }

    public function testNodeWithFormatWillUseThatFormat()

    {
        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class, FormatAwareInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        $format = m::mock(CsvFormat::class)
                   ->makePartial();

        $file->shouldReceive('getFormat')
             ->andReturn($format);

        $writer = new FileWriter($file);

        static::assertInstanceOf(WriterInterface::class, $writer);
    }

    public function testProvidingAParserFactoryWillUseTheFactory()
    {
        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        $format = m::mock(JsonFormat::class)
                   ->makePartial();
        $factory = m::mock(FormatterFactoryInterface::class);
        $formatter = m::mock(FormatterInterface::class);
        $factory->shouldReceive('getFormatter')
                ->with($format)
                ->andReturn($formatter);

        $writer = new FileWriter($file, $format, $factory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        static::assertInstanceOf(WriterInterface::class, $writer);
    }

    /**
     * @return resource
     */
    private function getStream()
    {
        return fopen('php://temp', 'c+b');
    }

    public function testInsertAll()

    {
        $data = [
            ['a', 'b', 'c', 'd'],
            ['e', 'f', 'g', 'h'],
        ];

        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        $format = m::mock(CsvFormat::class)->makePartial();
        $formatter = m::mock(FormatterInterface::class);
        $factory = m::mock(FormatterFactoryInterface::class);
        $factory->shouldReceive('getFormatter')
                ->with($format)
                ->andReturn($formatter);
        $writer = new FileWriter($file, $format, $factory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $formatter->shouldReceive('format')
                  ->with(['a', 'b', 'c', 'd'])
                  ->andReturn('first line');
        $formatter->shouldReceive('format')
                  ->with(['e', 'f', 'g', 'h'])
                  ->andReturn('second line');
        $formatter->shouldReceive('getInitialBlock')
                  ->andReturn('initial' . "\n");
        $formatter->shouldReceive('getClosingBlock')
                  ->andReturn("\n" . 'close');
        $formatter->shouldReceive('getRowSeparator')
                  ->andReturn("\n");

        $expected = <<<CSV
initial
first line
second line
close
CSV;

        $writer->insertAll($data);

        fseek($stream, 0, SEEK_SET);
        static::assertEquals($expected, stream_get_contents($stream));
    }

    public function testInsertOne()

    {
        $stream = $this->getStream();

        $file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
        $file->shouldReceive('getStream')
             ->with('c+b')
             ->andReturn($stream);

        $format = m::mock(CsvFormat::class)->makePartial();
        $formatter = m::mock(FormatterInterface::class);
        $factory = m::mock(FormatterFactoryInterface::class);
        $factory->shouldReceive('getFormatter')
                ->with($format)
                ->andReturn($formatter);
        $writer = new FileWriter($file, $format, $factory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $formatter->shouldReceive('format')
                  ->with(['a', 'b', 'c', 'd'])
                  ->andReturn('first line');
        $formatter->shouldReceive('format')
                  ->with(['e', 'f', 'g', 'h'])
                  ->andReturn('second line');
        $formatter->shouldReceive('getInitialBlock')
                  ->andReturn('initial' . "\n");
        $formatter->shouldReceive('getClosingBlock')
                  ->andReturn("\n" . 'close');
        $formatter->shouldReceive('getRowSeparator')
                  ->andReturn("\n");

        $expected = <<<CSV
initial
first line
second line
close
CSV;

        $writer->insert(['a', 'b', 'c', 'd']);
        $writer->insert(['e', 'f', 'g', 'h']);

        fseek($stream, 0, SEEK_SET);
        static::assertEquals($expected, stream_get_contents($stream));
    }
}


1		<?php
2		/**
3		* This file is part of graze/data-file
4		*
5		* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @license https://github.com/graze/data-file/blob/master/LICENSE.md
11		* @link https://github.com/graze/data-file
12		*/
13
14		namespace Graze\DataFile\Test\Unit\IO;
15
16		use Graze\DataFile\Format\CsvFormat;
17		use Graze\DataFile\Format\FormatAwareInterface;
18		use Graze\DataFile\Format\Formatter\FormatterFactoryInterface;
19		use Graze\DataFile\Format\Formatter\FormatterInterface;
20		use Graze\DataFile\Format\JsonFormat;
21		use Graze\DataFile\IO\FileWriter;
22		use Graze\DataFile\IO\WriterInterface;
23		use Graze\DataFile\Node\FileNodeInterface;
24		use Graze\DataFile\Node\NodeStreamInterface;
25		use Graze\DataFile\Test\TestCase;
26		use InvalidArgumentException;
27		use Mockery as m;
28
29		class FileWriterTest extends TestCase
30		{
31	View Code Duplication	public function testNodeStreamFileWillGetAStream()
		0 ignored issues – show Duplication introduced 2016-07-04 12:20 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$stream = $this->getStream();
34
35		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
36		$file->shouldReceive('getStream')
37		->with('c+b')
38		->andReturn($stream);
39
40		$format = m::mock(CsvFormat::class)
41		->makePartial();
42
43		$writer = new FileWriter($file, $format);
		0 ignored issues – show Documentation introduced 2016-06-07 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$format` is of type `object<Mockery\Mock>`, but the function expects a `null\|object<Graze\DataFi...Format\FormatInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44
45		static::assertInstanceOf(WriterInterface::class, $writer);
46		}
47
48		public function testFileNodeWillThrowAnException()
49		{
50		$file = m::mock(FileNodeInterface::class);
51
52		static::expectException(InvalidArgumentException::class);
53		new FileWriter($file);
54		}
55
56	View Code Duplication	public function testNodeWithNoFormatAndNoFormatSpecifiedWillThrowAnException()
		0 ignored issues – show Duplication introduced 2016-06-07 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$stream = $this->getStream();
59
60		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
61		$file->shouldReceive('getStream')
62		->with('c+b')
63		->andReturn($stream);
64
65		static::expectException(InvalidArgumentException::class);
66		new FileWriter($file);
67		}
68
69	View Code Duplication	public function testNodeWithFormatWillUseThatFormat()
		0 ignored issues – show Duplication introduced 2016-06-07 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
70		{
71		$stream = $this->getStream();
72
73		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class, FormatAwareInterface::class);
74		$file->shouldReceive('getStream')
75		->with('c+b')
76		->andReturn($stream);
77
78		$format = m::mock(CsvFormat::class)
79		->makePartial();
80
81		$file->shouldReceive('getFormat')
82		->andReturn($format);
83
84		$writer = new FileWriter($file);
85
86		static::assertInstanceOf(WriterInterface::class, $writer);
87		}
88
89		public function testProvidingAParserFactoryWillUseTheFactory()
90		{
91		$stream = $this->getStream();
92
93		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
94		$file->shouldReceive('getStream')
95		->with('c+b')
96		->andReturn($stream);
97
98		$format = m::mock(JsonFormat::class)
99		->makePartial();
100		$factory = m::mock(FormatterFactoryInterface::class);
101		$formatter = m::mock(FormatterInterface::class);
102		$factory->shouldReceive('getFormatter')
103		->with($format)
104		->andReturn($formatter);
105
106		$writer = new FileWriter($file, $format, $factory);
		0 ignored issues – show Documentation introduced 2016-09-21 14:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$format` is of type `object<Mockery\Mock>`, but the function expects a `null\|object<Graze\DataFi...Format\FormatInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
107
108		static::assertInstanceOf(WriterInterface::class, $writer);
109		}
110
111		/**
112		* @return resource
113		*/
114		private function getStream()
115		{
116		return fopen('php://temp', 'c+b');
117		}
118
119	View Code Duplication	public function testInsertAll()
		0 ignored issues – show Duplication introduced 2016-06-07 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		{
121		$data = [
122		['a', 'b', 'c', 'd'],
123		['e', 'f', 'g', 'h'],
124		];
125
126		$stream = $this->getStream();
127
128		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
129		$file->shouldReceive('getStream')
130		->with('c+b')
131		->andReturn($stream);
132
133		$format = m::mock(CsvFormat::class)->makePartial();
134		$formatter = m::mock(FormatterInterface::class);
135		$factory = m::mock(FormatterFactoryInterface::class);
136		$factory->shouldReceive('getFormatter')
137		->with($format)
138		->andReturn($formatter);
139		$writer = new FileWriter($file, $format, $factory);
		0 ignored issues – show Documentation introduced 2016-09-21 14:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$format` is of type `object<Mockery\Mock>`, but the function expects a `null\|object<Graze\DataFi...Format\FormatInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
140
141		$formatter->shouldReceive('format')
142		->with(['a', 'b', 'c', 'd'])
143		->andReturn('first line');
144		$formatter->shouldReceive('format')
145		->with(['e', 'f', 'g', 'h'])
146		->andReturn('second line');
147		$formatter->shouldReceive('getInitialBlock')
148		->andReturn('initial' . "\n");
149		$formatter->shouldReceive('getClosingBlock')
150		->andReturn("\n" . 'close');
151		$formatter->shouldReceive('getRowSeparator')
152		->andReturn("\n");
153
154		$expected = <<<CSV
155		initial
156		first line
157		second line
158		close
159		CSV;
160
161		$writer->insertAll($data);
162
163		fseek($stream, 0, SEEK_SET);
164		static::assertEquals($expected, stream_get_contents($stream));
165		}
166
167	View Code Duplication	public function testInsertOne()
		0 ignored issues – show Duplication introduced 2016-06-07 09:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		$stream = $this->getStream();
170
171		$file = m::mock(FileNodeInterface::class, NodeStreamInterface::class);
172		$file->shouldReceive('getStream')
173		->with('c+b')
174		->andReturn($stream);
175
176		$format = m::mock(CsvFormat::class)->makePartial();
177		$formatter = m::mock(FormatterInterface::class);
178		$factory = m::mock(FormatterFactoryInterface::class);
179		$factory->shouldReceive('getFormatter')
180		->with($format)
181		->andReturn($formatter);
182		$writer = new FileWriter($file, $format, $factory);
		0 ignored issues – show Documentation introduced 2016-09-21 14:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$format` is of type `object<Mockery\Mock>`, but the function expects a `null\|object<Graze\DataFi...Format\FormatInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
183
184		$formatter->shouldReceive('format')
185		->with(['a', 'b', 'c', 'd'])
186		->andReturn('first line');
187		$formatter->shouldReceive('format')
188		->with(['e', 'f', 'g', 'h'])
189		->andReturn('second line');
190		$formatter->shouldReceive('getInitialBlock')
191		->andReturn('initial' . "\n");
192		$formatter->shouldReceive('getClosingBlock')
193		->andReturn("\n" . 'close');
194		$formatter->shouldReceive('getRowSeparator')
195		->andReturn("\n");
196
197		$expected = <<<CSV
198		initial
199		first line
200		second line
201		close
202		CSV;
203
204		$writer->insert(['a', 'b', 'c', 'd']);
205		$writer->insert(['e', 'f', 'g', 'h']);
206
207		fseek($stream, 0, SEEK_SET);
208		static::assertEquals($expected, stream_get_contents($stream));
209		}
210		}
211

graze / data-file

Issues (144)

Security Analysis no request data

tests/unit/IO/FileWriterTest.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like