Graze\DataFile\Test\Unit\IO\StreamReaderTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	66
Duplicated Lines	27.27 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	buildReader()	0	12	1
A	testFetchWithNoCallable()	0	8	1
A	testFetchAllWithNoCallable()	8	8	1
A	testFetchWithCallable()	0	13	1
A	testFetchAllWithCallable()	10	10	1

<?php
/**
 * This file is part of graze/data-file
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/data-file/blob/master/LICENSE.md
 * @link    https://github.com/graze/data-file
 */

namespace Graze\DataFile\Test\Unit\IO;

use ArrayIterator;
use Graze\DataFile\Format\Parser\ParserInterface;
use Graze\DataFile\IO\StreamReader;
use Graze\DataFile\Test\Helper\CreateStreamTrait;
use Graze\DataFile\Test\TestCase;
use Iterator;
use Mockery as m;
use Mockery\MockInterface;

class StreamReaderTest extends TestCase
{
    use CreateStreamTrait;

    /**
     * @param string   $string
     * @param Iterator $iterator
     *
     * @return StreamReader
     */
    private function buildReader($string, Iterator $iterator)
    {
        $stream = $this->createStream($string);
        /** @var ParserInterface|MockInterface $parser */
        $parser = m::mock(ParserInterface::class);

        $parser->shouldReceive('parse')

The method shouldReceive does only exist in Mockery\MockInterface, but not in Graze\DataFile\Format\Parser\ParserInterface.

               ->with($stream)
               ->andReturn($iterator);

        return new StreamReader($stream, $parser);

It seems like $parser defined by \Mockery::mock(\Graze\DataFile\Format\Parser\ParserInterface::class) on line 39 can also be of type object<Mockery\MockInterface>; however, Graze\DataFile\IO\StreamReader::__construct() does only seem to accept object<Graze\DataFile\Format\Parser\ParserInterface>, maybe add an additional type check?

    }

    public function testFetchWithNoCallable()
    {
        $iterator = new ArrayIterator(['some', 'text']);
        $reader = $this->buildReader("some text in a stream", $iterator);

        $actual = $reader->fetch();
        static::assertSame($iterator, $actual);
    }

    public function testFetchAllWithNoCallable()

This method seems to be duplicated in your project.

    {
        $iterator = new ArrayIterator(['some', 'text']);
        $reader = $this->buildReader("some text in a stream", $iterator);

        $actual = $reader->fetchAll();
        static::assertEquals(['some', 'text'], $actual);
    }

    public function testFetchWithCallable()
    {
        $iterator = new ArrayIterator(['some', 'text']);
        $reader = $this->buildReader("some text in a stream", $iterator);

        $actual = $reader->fetch(function ($item) {
            return $item == 'some';
        });
        static::assertNotSame($iterator, $actual);

        $result = iterator_to_array($actual);
        static::assertEquals(['some'], $result);
    }

    public function testFetchAllWithCallable()

This method seems to be duplicated in your project.

    {
        $iterator = new ArrayIterator(['some', 'text']);
        $reader = $this->buildReader("some text in a stream", $iterator);

        $actual = $reader->fetchAll(function ($item) {
            return $item == 'text';
        });
        static::assertEquals(['text'], array_values($actual));
    }
}