CsvParserTest::parseLineData() - Code Metrics - Inspection of "Code tidy" - graze/data-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Harry

created 2016-05-20 09:09 UTC

CsvParserTest::parseLineData() A

↳ Parent: CsvParserTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	56
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	56
rs	9.7251
cc	1
eloc	35
nc	1
nop	0

How to fix Long Method

<?php
/**
 * This file is part of graze/data-file
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/data-file/blob/master/LICENSE.md
 * @link    https://github.com/graze/data-file
 */

namespace Graze\DataFile\Test\Unit\Format\Parser;

use Graze\DataFile\Format\CsvFormat;
use Graze\DataFile\Format\CsvFormatInterface;
use Graze\DataFile\Format\Parser\CsvParser;
use Graze\DataFile\Test\Helper\CreateStreamTrait;
use Graze\DataFile\Test\TestCase;
use Mockery as m;

class CsvParserTest extends TestCase
{
    use CreateStreamTrait;

    /**
     * @dataProvider parseLineData
     *
     * @param CsvFormatInterface $format
     * @param string             $line
     * @param array              $expected
     */
    public function testParse(CsvFormatInterface $format, $line, array $expected)
    {
        $parser = new CsvParser($format);

        $iterator = $parser->parse($this->createStream($line));
        $actual = iterator_to_array($iterator);
        $actual = array_values(array_map('iterator_to_array', $actual));

        static::assertEquals($expected, $actual);
    }

    /**
     * @return array
     */
    public function parseLineData()
    {
        return [
            [
                new CsvFormat([CsvFormat::OPTION_HEADERS => 0]),
                '"a","b",c,1,true,0.2,false,", enclosed","\\n \\r stuff",\\N',
                [['a', 'b', 'c', '1', 'true', '0.2', 'false', ', enclosed', "n r stuff", null]],
            ],
            [
                new CsvFormat([
                    CsvFormat::OPTION_DELIMITER       => '|',
                    CsvFormat::OPTION_ESCAPE          => '~',
                    CsvFormat::OPTION_QUOTE_CHARACTER => '`',
                    CsvFormat::OPTION_NULL_OUTPUT     => 'null',
                    CsvFormat::OPTION_HEADERS         => 0,
                    CsvFormat::OPTION_DOUBLE_QUOTE    => true,
                ]),
                '`string`|`other,thing`|some stuff|escaped ~\\n|``` all the `` quotes `|null',
                [['string', 'other,thing', 'some stuff', 'escaped \n', '` all the ` quotes ', null]],
            ],
            [
                new CsvFormat([
                    CsvFormat::OPTION_QUOTE_CHARACTER => "\\",
                    CsvFormat::OPTION_DELIMITER       => '|',
                    CsvFormat::OPTION_ESCAPE          => "\\",
                    CsvFormat::OPTION_HEADERS         => 0,
                ]),
                'a|b|c|d\\|e',
                [['a', 'b', 'c', 'd|e']],
            ],
            [
                new CsvFormat([
                    CsvFormat::OPTION_HEADERS      => 1,
                    CsvFormat::OPTION_DOUBLE_QUOTE => true,
                ]),
                file_get_contents(__DIR__ . '/../../../fixtures/csv_file.csv'),
                [
                    ['0', 'my name', 'i like " quotes', 'question?'],
                    ['1', 'your name', 'potatoes! ' . "\n" . 'and stuff', 'think'],
                    ['2', 'your , nice', 'fish"', '","'],
                ],
            ],
            [
                new CsvFormat([
                    CsvFormat::OPTION_HEADERS      => 0,
                    CsvFormat::OPTION_LIMIT        => 2,
                    CsvFormat::OPTION_DOUBLE_QUOTE => true,
                ]),
                file_get_contents(__DIR__ . '/../../../fixtures/csv_file.csv'),
                [
                    ['id', 'name', 'things', 'stuff'],
                    ['0', 'my name', 'i like " quotes', 'question?'],
                ],
            ],
        ];
    }
}


1			<?php
2			/**
3			* This file is part of graze/data-file
4			*
5			* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*
10			* @license https://github.com/graze/data-file/blob/master/LICENSE.md
11			* @link https://github.com/graze/data-file
12			*/
13
14			namespace Graze\DataFile\Test\Unit\Format\Parser;
15
16			use Graze\DataFile\Format\CsvFormat;
17			use Graze\DataFile\Format\CsvFormatInterface;
18			use Graze\DataFile\Format\Parser\CsvParser;
19			use Graze\DataFile\Test\Helper\CreateStreamTrait;
20			use Graze\DataFile\Test\TestCase;
21			use Mockery as m;
22
23			class CsvParserTest extends TestCase
24			{
25			use CreateStreamTrait;
26
27			/**
28			* @dataProvider parseLineData
29			*
30			* @param CsvFormatInterface $format
31			* @param string $line
32			* @param array $expected
33			*/
34			public function testParse(CsvFormatInterface $format, $line, array $expected)
35			{
36			$parser = new CsvParser($format);
37
38			$iterator = $parser->parse($this->createStream($line));
39			$actual = iterator_to_array($iterator);
40			$actual = array_values(array_map('iterator_to_array', $actual));
41
42			static::assertEquals($expected, $actual);
43			}
44
45			/**
46			* @return array
47			*/
48			public function parseLineData()
49			{
50			return [
51			[
52			new CsvFormat([CsvFormat::OPTION_HEADERS => 0]),
53			'"a","b",c,1,true,0.2,false,", enclosed","\\n \\r stuff",\\N',
54			[['a', 'b', 'c', '1', 'true', '0.2', 'false', ', enclosed', "n r stuff", null]],
55			],
56			[
57			new CsvFormat([
58			CsvFormat::OPTION_DELIMITER => '\|',
59			CsvFormat::OPTION_ESCAPE => '~',
60			CsvFormat::OPTION_QUOTE_CHARACTER => '`',
61			CsvFormat::OPTION_NULL_OUTPUT => 'null',
62			CsvFormat::OPTION_HEADERS => 0,
63			CsvFormat::OPTION_DOUBLE_QUOTE => true,
64			]),
65			'`string`\|`other,thing`\|some stuff\|escaped ~\\n\|``` all the `` quotes `\|null',
66			[['string', 'other,thing', 'some stuff', 'escaped \n', '` all the ` quotes ', null]],
67			],
68			[
69			new CsvFormat([
70			CsvFormat::OPTION_QUOTE_CHARACTER => "\\",
71			CsvFormat::OPTION_DELIMITER => '\|',
72			CsvFormat::OPTION_ESCAPE => "\\",
73			CsvFormat::OPTION_HEADERS => 0,
74			]),
75			'a\|b\|c\|d\\\|e',
76			[['a', 'b', 'c', 'd\|e']],
77			],
78			[
79			new CsvFormat([
80			CsvFormat::OPTION_HEADERS => 1,
81			CsvFormat::OPTION_DOUBLE_QUOTE => true,
82			]),
83			file_get_contents(__DIR__ . '/../../../fixtures/csv_file.csv'),
84			[
85			['0', 'my name', 'i like " quotes', 'question?'],
86			['1', 'your name', 'potatoes! ' . "\n" . 'and stuff', 'think'],
87			['2', 'your , nice', 'fish"', '","'],
88			],
89			],
90			[
91			new CsvFormat([
92			CsvFormat::OPTION_HEADERS => 0,
93			CsvFormat::OPTION_LIMIT => 2,
94			CsvFormat::OPTION_DOUBLE_QUOTE => true,
95			]),
96			file_get_contents(__DIR__ . '/../../../fixtures/csv_file.csv'),
97			[
98			['id', 'name', 'things', 'stuff'],
99			['0', 'my name', 'i like " quotes', 'question?'],
100			],
101			],
102			];
103			}
104			}
105

graze / data-file

Pull Request — master (#4)

CsvParserTest::parseLineData() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like