FileNode::getFilesystem() - Code Metrics - Inspection of "Support get adapter" - graze/data-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Harry

created 2016-07-18 11:03 UTC

FileNode::getFilesystem() A

↳ Parent: FileNode

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
/**
 * This file is part of graze/data-file
 *
 * Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @license https://github.com/graze/data-file/blob/master/LICENSE.md
 * @link    https://github.com/graze/data-file
 */

namespace Graze\DataFile\Node;

use Graze\DataFile\Format\FormatAwareInterface;
use Graze\DataFile\Format\FormatAwareTrait;
use Graze\DataFile\Modify\Compress\CompressionAwareInterface;
use Graze\DataFile\Modify\Compress\CompressionAwareTrait;
use Graze\DataFile\Modify\Encoding\EncodingAwareInterface;
use Graze\DataFile\Modify\Encoding\EncodingAwareTrait;
use Graze\DataFile\Modify\Exception\CopyFailedException;
use Graze\DataFile\Node\FileSystem\FilesystemWrapper;
use Graze\DataFile\Node\FileSystem\FileSystemWrapperInterface;
use League\Flysystem\File;
use League\Flysystem\FilesystemInterface;

class FileNode extends File implements FileNodeInterface, FormatAwareInterface, CompressionAwareInterface, EncodingAwareInterface
{
    use FormatAwareTrait;
    use CompressionAwareTrait;
    use EncodingAwareTrait;

    /**
     * FileNode constructor.
     *
     * @param FilesystemInterface $filesystem
     * @param null|string         $path
     */
    public function __construct(FilesystemInterface $filesystem, $path)
    {
        $wrapper = new FilesystemWrapper($filesystem);
        parent::__construct($wrapper, $path);
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return $this->getPath();
    }

    /**
     * @return mixed
     */
    public function getDirectory()
    {
        return pathinfo($this->path, PATHINFO_DIRNAME) . '/';
    }

    /**
     * @return string
     */
    public function getFilename()
    {
        return pathinfo($this->path, PATHINFO_BASENAME);
    }

    /**
     * Returns the contents of the file as an array.
     *
     * @return array
     */
    public function getContents()
    {
        if ($this->exists()) {
            return explode("\n", trim($this->read()));
        } else {
            return [];
        }
    }

    /**
     * @param string|null $newPath
     *
     * @return static
     * @throws CopyFailedException When it is unable to copy the file
     */
    public function copy($newPath = null)
    {
        if (is_null($newPath)) {
            $newPath = $this->path . '-copy';
        }

        if (@$this->filesystem->copy($this->path, $newPath)) {
            return $this->getClone()->setPath($newPath);
        } else {
            $lastError = error_get_last();
            throw new CopyFailedException($this, $newPath, $lastError['message']);
        }
    }

    /**
     * @return FileSystemWrapperInterface
     */
    public function getFilesystem()
    {
        return parent::getFilesystem();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Return a clone of this object
     *
     * @return static
     */
    public function getClone()
    {
        return clone $this;
    }

    /**
     * Clone sub objects
     */
    public function __clone()
    {
        if ($this->format) {
            $this->format = clone $this->format;
        }
    }
}


1		<?php
2		/**
3		* This file is part of graze/data-file
4		*
5		* Copyright (c) 2016 Nature Delivered Ltd. <https://www.graze.com>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*
10		* @license https://github.com/graze/data-file/blob/master/LICENSE.md
11		* @link https://github.com/graze/data-file
12		*/
13
14		namespace Graze\DataFile\Node;
15
16		use Graze\DataFile\Format\FormatAwareInterface;
17		use Graze\DataFile\Format\FormatAwareTrait;
18		use Graze\DataFile\Modify\Compress\CompressionAwareInterface;
19		use Graze\DataFile\Modify\Compress\CompressionAwareTrait;
20		use Graze\DataFile\Modify\Encoding\EncodingAwareInterface;
21		use Graze\DataFile\Modify\Encoding\EncodingAwareTrait;
22		use Graze\DataFile\Modify\Exception\CopyFailedException;
23		use Graze\DataFile\Node\FileSystem\FilesystemWrapper;
24		use Graze\DataFile\Node\FileSystem\FileSystemWrapperInterface;
25		use League\Flysystem\File;
26		use League\Flysystem\FilesystemInterface;
27
28		class FileNode extends File implements FileNodeInterface, FormatAwareInterface, CompressionAwareInterface, EncodingAwareInterface
29		{
30		use FormatAwareTrait;
31		use CompressionAwareTrait;
32		use EncodingAwareTrait;
33
34		/**
35		* FileNode constructor.
36		*
37		* @param FilesystemInterface $filesystem
38		* @param null\|string $path
39		*/
40	112	public function __construct(FilesystemInterface $filesystem, $path)
41		{
42	112	$wrapper = new FilesystemWrapper($filesystem);
43	112	parent::__construct($wrapper, $path);
44	112	}
45
46		/**
47		* @return string
48		*/
49	14	public function __toString()
50		{
51	14	return $this->getPath();
52		}
53
54		/**
55		* @return mixed
56		*/
57	10	public function getDirectory()
58		{
59	10	return pathinfo($this->path, PATHINFO_DIRNAME) . '/';
60		}
61
62		/**
63		* @return string
64		*/
65	18	public function getFilename()
66		{
67	18	return pathinfo($this->path, PATHINFO_BASENAME);
68		}
69
70		/**
71		* Returns the contents of the file as an array.
72		*
73		* @return array
74		*/
75	21	public function getContents()
76		{
77	21	if ($this->exists()) {
78	19	return explode("\n", trim($this->read()));
79		} else {
80	2	return [];
81		}
82		}
83
84		/**
85		* @param string\|null $newPath
86		*
87		* @return static
88		* @throws CopyFailedException When it is unable to copy the file
89		*/
90	4	public function copy($newPath = null)
91		{
92	4	if (is_null($newPath)) {
93	1	$newPath = $this->path . '-copy';
94	1	}
95
96	4	if (@$this->filesystem->copy($this->path, $newPath)) {
97	3	return $this->getClone()->setPath($newPath);
98		} else {
99	1	$lastError = error_get_last();
100	1	throw new CopyFailedException($this, $newPath, $lastError['message']);
101		}
102		}
103
104		/**
105		* @return FileSystemWrapperInterface
106		*/
107	16	public function getFilesystem()
108		{
109	16	return parent::getFilesystem();
		0 ignored issues – show Bug Best Practice introduced 2016-07-18 10:55 UTC by Report Bug Copy Issue Report The return type of `return parent::getFilesystem();` (`League\Flysystem\FilesystemInterface`) is incompatible with the return type declared by the interface `Graze\DataFile\Node\File...nterface::getFilesystem` of type `Graze\DataFile\Node\FilesystemWrapperInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
110		}
111
112		/**
113		* Return a clone of this object
114		*
115		* @return static
116		*/
117	57	public function getClone()
118		{
119	57	return clone $this;
120		}
121
122		/**
123		* Clone sub objects
124		*/
125	57	public function __clone()
126		{
127	57	if ($this->format) {
128	1	$this->format = clone $this->format;
129	1	}
130	57	}
131		}
132

graze / data-file

Pull Request — master (#14)

FileNode::getFilesystem() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like