LocalFile::getContents() - Code Metrics - Inspection of "process file refactoring" - graze/data-file - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6695d4...9bc3b7 )

by Harry

created 2016-02-21 13:36 UTC

LocalFile::getContents() A

↳ Parent: LocalFile

Complexity

Conditions	3
Paths	2

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4.125

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	4
cts	8
cp	0.5
rs	9.4285
cc	3
eloc	9
nc	2
nop	0
crap	4.125

<?php

namespace Graze\DataFile\Node;

use Graze\DataFile\Modify\Compress\CompressionType;
use League\Flysystem\Adapter\Local;
use League\Flysystem\Filesystem;

class LocalFile extends FileNode implements LocalFileNodeInterface
{
    /**
     * @var string - CompressionType::
     */
    protected $compression;

    /**
     * @var string|null
     */
    protected $encoding;

    /**
     * @param string $path
     */
    public function __construct($path)
    {
        parent::__construct(new FileSystem(new Local('/')), $path);

        $this->compression = CompressionType::NONE;
        $this->encoding = null;
    }

    /**
     * @return string
     */
    public function getEncoding()
    {
        return $this->encoding;
    }

    /**
     * @param string $encoding
     *
     * @return $this
     */
    public function setEncoding($encoding)
    {
        $this->encoding = $encoding;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getContents()
    {
        if ($this->exists() &&
            $this->getCompression() != CompressionType::NONE
        ) {
            $uncompressed = $this->decompress();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $content = $uncompressed->getContents();
            $uncompressed->delete();
            return $content;
        } else {
            return parent::getContents();
        }
    }

    /**
     * @return string - see CompressionType::
     */
    public function getCompression()
    {
        return $this->compression;
    }

    /**
     * @param string $compression - @see CompressionType::
     *
     * @return $this
     */
    public function setCompression($compression)
    {
        $this->compression = $compression;

        return $this;
    }
}


1		<?php
2
3		namespace Graze\DataFile\Node;
4
5		use Graze\DataFile\Modify\Compress\CompressionType;
6		use League\Flysystem\Adapter\Local;
7		use League\Flysystem\Filesystem;
8
9		class LocalFile extends FileNode implements LocalFileNodeInterface
10		{
11		/**
12		* @var string - CompressionType::
13		*/
14		protected $compression;
15
16		/**
17		* @var string\|null
18		*/
19		protected $encoding;
20
21		/**
22		* @param string $path
23		*/
24	89	public function __construct($path)
25		{
26	89	parent::__construct(new FileSystem(new Local('/')), $path);
27
28	89	$this->compression = CompressionType::NONE;
29	89	$this->encoding = null;
30	89	}
31
32		/**
33		* @return string
34		*/
35	10	public function getEncoding()
36		{
37	10	return $this->encoding;
38		}
39
40		/**
41		* @param string $encoding
42		*
43		* @return $this
44		*/
45	10	public function setEncoding($encoding)
46		{
47	10	$this->encoding = $encoding;
48
49	10	return $this;
50		}
51
52		/**
53		* {@inheritdoc}
54		*/
55	16	public function getContents()
56		{
57	16	if ($this->exists() &&
58	16	$this->getCompression() != CompressionType::NONE
59		) {
60		$uncompressed = $this->decompress();
		0 ignored issues – show Documentation Bug introduced 2016-02-19 19:01 UTC by Report Bug Copy Issue Report The method `decompress` does not exist on `object<Graze\DataFile\Node\LocalFile>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
61		$content = $uncompressed->getContents();
62		$uncompressed->delete();
63		return $content;
64		} else {
65	16	return parent::getContents();
66		}
67		}
68
69		/**
70		* @return string - see CompressionType::
71		*/
72	25	public function getCompression()
73		{
74	25	return $this->compression;
75		}
76
77		/**
78		* @param string $compression - @see CompressionType::
79		*
80		* @return $this
81		*/
82	16	public function setCompression($compression)
83		{
84	16	$this->compression = $compression;
85
86	16	return $this;
87		}
88		}
89

graze / data-file

Push — master ( 6695d4...9bc3b7 )

LocalFile::getContents() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like