Issues in PdoAdapter.php (master) - Issues in master - graze/data-db - Measure and Improve Code Quality continuously with Scrutinizer

Issues (44)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Adapter/PdoAdapter.php (1 issue)

Labels

Duplication 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Graze\DataDb\Adapter;

use Graze\DataDb\Dialect\DialectInterface;
use PDO;
use PDOStatement;
use Traversable;

class PdoAdapter implements AdapterInterface
{
    /** @var PDO */
    private $pdo;
    /** @var DialectInterface */
    private $dialect;

    /**
     * @param PDO              $pdo
     * @param DialectInterface $dialect
     */
    public function __construct(PDO $pdo, DialectInterface $dialect)
    {
        $this->pdo = $pdo;
        $this->dialect = $dialect;
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function query($sql, array $bind = [])
    {
        $statement = $this->pdo->prepare($sql);
        return $statement->execute($bind);
    }

    /**
     * @param string $sql
     * @param array  $bind
     * @param array  $options Extra set of options to pass to prepare
     *
     * @return PDOStatement
     */
    private function prepareQuery($sql, array $bind = [], array $options = [])
    {
        $statement = $this->pdo->prepare($sql, $options);
        foreach ($bind as $key => $value) {
            $statement->bindValue($key, $value);
        }
        return $statement;
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return Traversable
     */
    public function fetch($sql, array $bind = [])
    {
        $iterator = $this->prepareQuery($sql, $bind, [PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => false]);
        return $iterator;
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array
     */
    public function fetchAll($sql, array $bind = [])
    {
        return $this->prepareQuery($sql, $bind)->fetchAll();
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return array|bool
     */
    public function fetchRow($sql, array $bind = [])
    {
        return $this->prepareQuery($sql, $bind)->fetch();
    }

    /**
     * @param string $sql
     * @param array  $bind
     *
     * @return mixed
     */
    public function fetchOne($sql, array $bind = [])

    {
        $row = $this->fetchRow($sql, $bind);
        if ($row) {
            return $row[0];
        }

        return false;
    }

    /**
     * @param mixed $value
     *
     * @return string
     */
    public function quoteValue($value)
    {
        return $this->pdo->quote($value);
    }

    /**
     * Start a transaction
     *
     * @return static
     */
    public function beginTransaction()
    {
        $this->pdo->beginTransaction();
        return $this;
    }

    /**
     * @return static
     */
    public function commit()
    {
        $this->pdo->commit();
        return $this;
    }

    /**
     * @return static
     */
    public function rollback()
    {
        $this->pdo->rollBack();
        return $this;
    }

    /**
     * @return DialectInterface
     */
    public function getDialect()
    {
        return $this->dialect;
    }
}


1		<?php
2
3		namespace Graze\DataDb\Adapter;
4
5		use Graze\DataDb\Dialect\DialectInterface;
6		use PDO;
7		use PDOStatement;
8		use Traversable;
9
10		class PdoAdapter implements AdapterInterface
11		{
12		/** @var PDO */
13		private $pdo;
14		/** @var DialectInterface */
15		private $dialect;
16
17		/**
18		* @param PDO $pdo
19		* @param DialectInterface $dialect
20		*/
21		public function __construct(PDO $pdo, DialectInterface $dialect)
22		{
23		$this->pdo = $pdo;
24		$this->dialect = $dialect;
25		}
26
27		/**
28		* @param string $sql
29		* @param array $bind
30		*
31		* @return mixed
32		*/
33		public function query($sql, array $bind = [])
34		{
35		$statement = $this->pdo->prepare($sql);
36		return $statement->execute($bind);
37		}
38
39		/**
40		* @param string $sql
41		* @param array $bind
42		* @param array $options Extra set of options to pass to prepare
43		*
44		* @return PDOStatement
45		*/
46		private function prepareQuery($sql, array $bind = [], array $options = [])
47		{
48		$statement = $this->pdo->prepare($sql, $options);
49		foreach ($bind as $key => $value) {
50		$statement->bindValue($key, $value);
51		}
52		return $statement;
53		}
54
55		/**
56		* @param string $sql
57		* @param array $bind
58		*
59		* @return Traversable
60		*/
61		public function fetch($sql, array $bind = [])
62		{
63		$iterator = $this->prepareQuery($sql, $bind, [PDO::MYSQL_ATTR_USE_BUFFERED_QUERY => false]);
64		return $iterator;
65		}
66
67		/**
68		* @param string $sql
69		* @param array $bind
70		*
71		* @return array
72		*/
73		public function fetchAll($sql, array $bind = [])
74		{
75		return $this->prepareQuery($sql, $bind)->fetchAll();
76		}
77
78		/**
79		* @param string $sql
80		* @param array $bind
81		*
82		* @return array\|bool
83		*/
84		public function fetchRow($sql, array $bind = [])
85		{
86		return $this->prepareQuery($sql, $bind)->fetch();
87		}
88
89		/**
90		* @param string $sql
91		* @param array $bind
92		*
93		* @return mixed
94		*/
95	View Code Duplication	public function fetchOne($sql, array $bind = [])
		0 ignored issues – show Duplication introduced 2016-09-27 11:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		{
97		$row = $this->fetchRow($sql, $bind);
98		if ($row) {
99		return $row[0];
100		}
101
102		return false;
103		}
104
105		/**
106		* @param mixed $value
107		*
108		* @return string
109		*/
110		public function quoteValue($value)
111		{
112		return $this->pdo->quote($value);
113		}
114
115		/**
116		* Start a transaction
117		*
118		* @return static
119		*/
120		public function beginTransaction()
121		{
122		$this->pdo->beginTransaction();
123		return $this;
124		}
125
126		/**
127		* @return static
128		*/
129		public function commit()
130		{
131		$this->pdo->commit();
132		return $this;
133		}
134
135		/**
136		* @return static
137		*/
138		public function rollback()
139		{
140		$this->pdo->rollBack();
141		return $this;
142		}
143
144		/**
145		* @return DialectInterface
146		*/
147		public function getDialect()
148		{
149		return $this->dialect;
150		}
151		}
152

graze / data-db

Issues (44)

Security Analysis no request data

src/Adapter/PdoAdapter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like