Graze\CiffRenderer\Renderer\FieldRenderer\GraphicPrimitive\AbstractBoxRenderer

Complexity

Total Complexity

3

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	factory()	0	3	1
A	render()	0	24	2

<?php

namespace Graze\CiffRenderer\Renderer\FieldRenderer\GraphicPrimitive;

use Graze\CiffRenderer\Renderer\FieldRenderer\FieldRendererInterface;
use Intervention\Image\ImageManager;
use Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface;

abstract class AbstractBoxRenderer implements FieldRendererInterface
{
    /**
     * @param ImageManager $imageManager
     * @param FieldParserInterface $parser
     * @param null|callable $fontResolver
     * @param null|callable $graphicResolver
     * @return \Intervention\Image\Image
     */
    public function render(
        ImageManager $imageManager,
        FieldParserInterface $parser,
        callable $fontResolver = null,
        callable $graphicResolver = null
    ) {
        $canvas = $imageManager->canvas($parser->getWidth(), $parser->getHeight());

        $rectangleConf = function ($rectangle) use ($parser) {
            $rectangle->border($parser->getLineWeight(), '#000');

The method getLineWeight() does not exist on Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface. It seems like you code against a sub-type of Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface such as Graze\CiffRenderer\Parser\FieldParser\FieldParserGraphicPrimitive or Graze\CiffRenderer\Parser\FieldParser\FieldParserGraphicPrimitive.

            if ($this->isFilled()) {
                $rectangle->background('#000');
            }
        };

        $canvas->rectangle(
            0,
            0,
            $parser->getWidth() - $parser->getLineWeight(),
            $parser->getHeight() - $parser->getLineWeight(),
            $rectangleConf
        );

        return $canvas;
    }

    /**
     * Is the box filled, or just an outline?
     *
     * @var bool
     */
    abstract protected function isFilled();

    /**
     * @return FieldParserInterface
     */
    public static function factory()
    {
        return new static();

The expression return new static() returns the type Graze\CiffRenderer\Renderer\FieldRenderer\GraphicPrimitive\AbstractBoxRenderer which is incompatible with the documented return type Graze\CiffRenderer\Parser\FieldParser\FieldParserInterface.

    }
}